Skip to content

Pull Requests

Ed Mozley edited this page Nov 11, 2026 · 1 revision

Pull requests

Every pull request contributed to FreeITSM, what happened to it, and where the review is written up.

Each pull request gets one verdict before anything is done with it:

  • Merge - sound as it is. It goes in under the contributor's name.
  • Merge + fix - a sound design with a few fixable issues. It goes in under the contributor's name, then my own commits fix what needed fixing - usually the five complete languages, the in-app help, and anything that landed on main after the branch was cut.
  • Rewrite - the idea is right but the code is not safe to apply. I write it myself from their design, credit them as co-author, and close the pull request as complete.

Why the reviews are written down: a review page says what was checked, what was changed on top and why, and what a later change must not undo. Read it before changing that code - it is how a fix stays fixed. Bugs found and fixed by a pull request are also listed in Bugs resolved; people who made a substantial contribution are credited in System β†’ Contributors.

Want to contribute? Start with Contributing.


Reviewed

Newest first. "Write-up" is the review page where there is one; otherwise the page that documents what the pull request built.

Merged Pull request What it did By Verdict Write-up
Nov 2026 #300 Software inventory columns say what they count - Installations and Licence seats Dr4inder Merge + fix Software count columns
Nov 2026 #299 Preference templates can include the two preferences they left out Dr4inder Merge + fix Preference template coverage
Nov 2026 #297 CMDB relationships name both ends, so they read correctly in every language Dr4inder Merge + fix CMDB relationship wording
Nov 2026 #295 Hyper-V VMs report their guest OS Dr4inder Merge + fix Hyper-V guest OS
Nov 2026 #291 System β†’ Maintenance, the home for tools that find data left behind vsc55 Merge + fix System Maintenance
Nov 2026 #290 Impact and Risk impact told apart on a change Dr4inder Merge + fix Change impact wording
Nov 2026 #289 Back from a full-screen ticket keeps your layout and your draft Dr4inder Merge + fix Back from a full-screen ticket
Nov 2026 #265 Organisation chart follow-up - everybody under a manager counted vsc55 Merge Organisation chart
Nov 2026 #258 Change risk matrix cells line up with their headings Dr4inder Merge (cherry-picked) -
Nov 2026 #256 German says "Bearbeiter" for the ticket owner Dr4inder Merge -
Nov 2026 #255 Knowledge article previews decode HTML codes Dr4inder Merge Article previews showed HTML codes
Nov 2026 #253 Knowledge links can pick an internal article Dr4inder Merge Knowledge
Nov 2026 #252 Links to Knowledge articles open in all four layouts Dr4inder Merge, review kept the folder move narrow A link to a Knowledge article did not open
Nov 2026 #251 Clicking a folder while reading an article shows the folder Dr4inder Merge (cherry-picked) Clicking a folder left the open article on screen
Nov 2026 #247 Empty Procedures fold with the other Work sections Dr4inder Merge, one small fix Empty Procedures fold
Nov 2026 #242 People: an organisation chart from the reporting lines vsc55 Merge (cherry-picked), small fixes Organisation chart
Nov 2026 #237-#240 Entra follow-ups: directory groups, protected imported people, automatic import, the script in cron/ vsc55 Merge, small fixes Entra follow-ups
Nov 2026 #236 An unheld asset goes to its Intune primary user vsc55 Merge Intune primary user
Nov 2026 #235 Microsoft Entra ID as a people source vsc55 Merge + fix Entra directory sync
Oct 2026 #223 Ticket table: full width, split view and pager Dr4inder Merge + fix Ticket table split view
Oct 2026 #211-#213 Ticket workspace, tasks edited inside it, paginated queue and CSV export Dr4inder Merge + fix Ticket workspace
Oct 2026 #198 Long forms no longer cut off in a task's Work view Dr4inder Merge + fix Long forms in a task's Work view
Oct 2026 #195-#197 REST API: custom asset fields, change evidence, inventory reports Dr4inder Merge + fix Custom fields, evidence and inventory
Oct 2026 #174 Analyst provisioning in the REST API, with OIDC claim mapping Kraleemil Rewrite - built from the patch and design, credited as co-author REST API - Analysts
Oct 2026 #167 Proxmox VE and VMware Cloud Director sync turbay-a Merge Proxmox and Cloud Director - Developer Guide
Oct 2026 #166 Microsoft Teams and Mattermost channels, and CSAT in the chat turbay-a Merge + fix Teams and Mattermost - Developer Guide
Oct 2026 #164 Asset reconciliation, tags and labels srinivasansanthosh Merge Asset reconciliation, tags and labels
Oct 2026 #159 Telegram channel, contact matching, localisation and attachments turbay-a Merge + fix Telegram - Developer Guide
Sep 2026 Branch, issue #155 SSO: roles given at first sign-in, and profiles kept in step srinivasansanthosh Merge + fix - review notes worked through before merging SSO JIT roles and profile sync
Sep 2026 #141 The SOP Checklists module and its workflow action srinivasansanthosh Merge + fix Checklists house style, closure gating
Sep 2026 #140 Background image uploads on every branding screen respect their scope srinivasansanthosh Merge System branding - Developer Guide
Aug 2026 #119 Separate SMTP login for Basic IMAP mailboxes Kraleemil Rewrite - built on main, credited Basic IMAP mailboxes
Jun 2026 #23 Google mailbox OAuth set-up abdulaziz-git Merge Gmail mail collection - Developer Guide

Closed without merging

Closed Pull request Why By
Nov 2026 #232 Withdrawn by its author to meet the contribution guidelines; came back as #235-#240 vsc55
Oct 2026 #206 Split into three smaller pull requests, #211-#213 Dr4inder
Oct 2026 #165 Replaced by its author with #166 turbay-a
Sep 2026 #139 Replaced by its author with #140 srinivasansanthosh

Open

  • #264 by vsc55 - directory sources and Imported people. Waiting for its author to move Imported people under System β†’ Maintenance (#291).

Adding a review: name the page <Thing>-PR-Review, start it with the line PR [#N](link) by [handle](link) Β· Verdict: ..., and cover what was checked, what was changed and what a later change must not undo - System Maintenance is a good model. Then add a row at the top of the table above, and a ↳ πŸ› οΈ ... - review (#N) line under its module in the sidebar.

FreeITSM

Getting Started

Modules

Multi-tenancy (planned)

Responses to feedback

Blue sky thinking

Bugs resolved

Pull requests

Links

Clone this wiki locally