-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/v0.45.2.1 #2
base: master
Are you sure you want to change the base?
Commits on Nov 4, 2022
-
Migrate UserInviteForm to formik (metabase#26216) (metabase#26235)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 9fd09a0 - Browse repository at this point
Copy the full SHA 9fd09a0View commit details -
Migrate UserProfileForm to formik (metabase#26231) (metabase#26238)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 8432de5 - Browse repository at this point
Copy the full SHA 8432de5View commit details -
Add FormTextArea (metabase#26257) (metabase#26259)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 809a644 - Browse repository at this point
Copy the full SHA 809a644View commit details
Commits on Nov 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0cf1ea4 - Browse repository at this point
Copy the full SHA 0cf1ea4View commit details
Commits on Nov 7, 2022
-
replace quotation marks (metabase#26252) (metabase#26271)
Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 504270c - Browse repository at this point
Copy the full SHA 504270cView commit details -
Bump woodstox : CVE-2022-40151 (metabase#26269) (metabase#26274)
First seen in trivy report: https://github.com/metabase/metabase/pull/26161/checks?check_run_id=9326286850 CVE: https://avd.aquasec.com/nvd/cve-2022-40151 xstream: Xstream to serialise XML data was vulnerable to Denial of Service attacks High Package: com.fasterxml.woodstox:woodstox-core Installed Version: 6.2.6 Vulnerability CVE-2022-40151 Severity: HIGH Fixed Version: 5.4.0, 6.4.0 Bumping deps and comparing `clj -X:deps tree` shows the change only adds the new dep top level and no new deps are brought in by the change. ``` ❯ diff --unified deps deps-updated --- deps 2022-11-07 08:43:21.000000000 -0600 +++ deps-updated 2022-11-07 08:49:56.000000000 -0600 @@ -9,6 +9,8 @@ X org.slf4j/slf4j-api 1.7.25 :use-top X org.apache.logging.log4j/log4j-api 2.18.0 :use-top X org.apache.logging.log4j/log4j-core 2.18.0 :use-top +com.fasterxml.woodstox/woodstox-core 6.4.0 + . org.codehaus.woodstox/stax2-api 4.2.1 joda-time/joda-time 2.10.13 commons-codec/commons-codec 1.15 weavejester/dependency 0.2.1 @@ -285,8 +287,7 @@ . org.apache.santuario/xmlsec 2.3.0 X org.slf4j/slf4j-api 1.7.32 :use-top X commons-codec/commons-codec 1.15 :use-top - . com.fasterxml.woodstox/woodstox-core 6.2.6 - . org.codehaus.woodstox/stax2-api 4.2.1 + X com.fasterxml.woodstox/woodstox-core 6.2.6 :use-top . jakarta.xml.bind/jakarta.xml.bind-api 2.3.3 . jakarta.activation/jakarta.activation-api 1.2.2 . org.opensaml/opensaml-xmlsec-api 3.4.6 ``` Co-authored-by: dpsutton <dan@dpsutton.com>
Configuration menu - View commit details
-
Copy full SHA for c4efeee - Browse repository at this point
Copy the full SHA c4efeeeView commit details -
Migrate timeline forms to formik (metabase#26247) (metabase#26278)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for ab08c3d - Browse repository at this point
Copy the full SHA ab08c3dView commit details -
docs - add week function (metabase#26152) (metabase#26280)
* add week function * Update docs/questions/query-builder/expressions-list.md Co-authored-by: Natalie <nat@metabase.com> * update copy * formatting Co-authored-by: Natalie <nat@metabase.com> Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for ffc654b - Browse repository at this point
Copy the full SHA ffc654bView commit details -
Deprecate form framework components (metabase#26270) (metabase#26277)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 3955db2 - Browse repository at this point
Copy the full SHA 3955db2View commit details -
Adding Tests for hasColumnSettings, Fixing currency bug (metabase#26171…
…) (metabase#26282) * Adding Tests for hasColumnSettings * Updating Comment Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 5b7ffcc - Browse repository at this point
Copy the full SHA 5b7ffccView commit details
Commits on Nov 8, 2022
-
Change the remaning columns that has text type in mysql,mariadb to lo…
…ngtext (metabase#26223) (metabase#26287) * Change the remaning columns that has text type in mysql,mariadb to longtext Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3e8aff7 - Browse repository at this point
Copy the full SHA 3e8aff7View commit details -
Fix newly created models not appearing in the QB (metabase#26275) (me…
…tabase#26288) Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 77602cc - Browse repository at this point
Copy the full SHA 77602ccView commit details
Commits on Nov 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b7bb6ae - Browse repository at this point
Copy the full SHA b7bb6aeView commit details -
Use all text scorers in the final result to increase scoring signal (m…
…etabase#26026) (metabase#26307) * Uses all text scorers in the final result - instead of just the maximum one - add tests * add prefix scorer test + fix text-score-with * linter fixes * pass in number of results to find * refactor test function * fix linter by removing unused namespace: metabase.util * limit arity of serialize to 3 * make oss-score and ee-score different things - They were defined to be exactly the same, but should be different! - Update some tests that broke when a test function was fixed * remove extra let * move rseq back out of sorted-take * improve test feedback * force weight of text based scorers always weigh 10 * handle 0 score/weights when normalizing scores * add nil check * fix more subtle test differences * more test fiddling - still test that :offset and :limit respect limits * reuse bit->boolean from api collection * clean up some tests - filter -> remove - replace some magic numbers - revert to testing entire maps instead of names of sorted items * add test, docstring, and weight * sort ns requires * responding to most of the review comments * start our zero-score sum check with 0 * do not tokenize / normalize nil raw-search-string * force equality in basic search test * modify test to work in dev and test environments * use display_name in results when appropriate - This was looking for the _first_ column that had a non-zero score, but actually we need to consider all relevant columns. - Uses them to figure out if there is a display name, and if there is, to use it. - Coppied over the logic about showing :context from the prior approach Co-authored-by: Bryan Maass <bryan.maass@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e99c2cc - Browse repository at this point
Copy the full SHA e99c2ccView commit details -
change schema to allow empty strings as table descriptions (metabase#…
…26302) (metabase#26308) Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for bda5a02 - Browse repository at this point
Copy the full SHA bda5a02View commit details -
Handcrafted manual backport from metabase#26250 and metabase#26249 to…
… avoid conflict resolution (metabase#26314)
Configuration menu - View commit details
-
Copy full SHA for e06f091 - Browse repository at this point
Copy the full SHA e06f091View commit details -
add arabic as supported language (metabase#26295) (metabase#26321)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d51e144 - Browse repository at this point
Copy the full SHA d51e144View commit details -
docs - filters (metabase#26220) (metabase#26322)
Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 223346e - Browse repository at this point
Copy the full SHA 223346eView commit details -
Upgrade
@cypress/grep
library (metabase#26299) (metabase#26324)* Upgrade `cypress/grep` library * Update Cypress config Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 5ef077a - Browse repository at this point
Copy the full SHA 5ef077aView commit details -
Fix loader-utils (metabase#26320) (metabase#26332)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for fd73801 - Browse repository at this point
Copy the full SHA fd73801View commit details
Commits on Nov 10, 2022
-
Log errors caught during sync steps (metabase#26306) (metabase#26337)
* log errors caught during sync steps * remove accidental extra parens Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a1c4025 - Browse repository at this point
Copy the full SHA a1c4025View commit details -
Errors combining datetime interval addition with datetime functions (m…
…etabase#26279) (metabase#26338) * Add failing tests * Fix failing tests * Update shared/src/metabase/mbql/util.cljc Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> * datetime-add and datetime subtract should annotate type by col type * Fix infer-expression-type for datetime-add/subtract with second, minute, hour * Undo last commit; they actually always return :type/DateTime * Fix test based on last commit * Undo unrelated refactor * Only test drivers that support expressions * Only test drivers that support expressions, again * Update tests from legacy mbql * Change infered-col-type to be a function again, not macro * Fix test Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4f9a5e3 - Browse repository at this point
Copy the full SHA 4f9a5e3View commit details -
Upgrade webpack, webpack-cli and webpack-dev-server (metabase#26313) (m…
…etabase#26341) Co-authored-by: Luis Paolini <paoliniluis@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 97d9d84 - Browse repository at this point
Copy the full SHA 97d9d84View commit details -
Fix stacked static chart render failure (metabase#26285) (metabase#26352
) * Fix stacked static chart render failure This fixes metabase#20752 where static chart will fail to render stacked bar charts when data contain gaps. * Make the code easier to read Co-authored-by: Mahatthana (Kelvin) Nomsawadi <mahatthana.n@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f3a0cb2 - Browse repository at this point
Copy the full SHA f3a0cb2View commit details -
Fix form reinitialization with formik (metabase#26292) (metabase#26370)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 017f3f0 - Browse repository at this point
Copy the full SHA 017f3f0View commit details -
[E2E] Skip erroring questions tests (metabase#26369) (metabase#26371)
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 30b24ab - Browse repository at this point
Copy the full SHA 30b24abView commit details -
Migrate some driver tests to GitHub Actions (metabase#25769) (metabas…
…e#26378) * Migrate some driver tests to GitHub Actions * Druid * MariaDB 10.2 * MariaDB latest * MongoDB 4.0 * MongoDB 5.0 * MongoDB latest * MySQL 5.7 * Postgres 9.6 * Postgres latest * Presto * Spark * SQLite * SQL Server 2017 * Don't use Buildjet runner * Don't run the driver tests for draft PRs * Use Buildjet for Spark driver tests * Use Buildjet for Druid driver tests Co-authored-by: Ariya Hidayat <ariya@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for b2b4b69 - Browse repository at this point
Copy the full SHA b2b4b69View commit details -
Configuration menu - View commit details
-
Copy full SHA for eadd353 - Browse repository at this point
Copy the full SHA eadd353View commit details -
Configuration menu - View commit details
-
Copy full SHA for c910fbf - Browse repository at this point
Copy the full SHA c910fbfView commit details
Commits on Nov 11, 2022
-
Datetime extraction and arithmetics for text column in mongo (metabas…
…e#26339) (metabase#26395) Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3a50f44 - Browse repository at this point
Copy the full SHA 3a50f44View commit details -
fix mongo not able to filter by UUID (metabase#26367) (metabase#26396)
Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e72c3c8 - Browse repository at this point
Copy the full SHA e72c3c8View commit details -
[CI] Increase drivers tests timeout (metabase#26398) (metabase#26399)
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f2b36f1 - Browse repository at this point
Copy the full SHA f2b36f1View commit details -
Call blur if activeElement is in popover content (metabase#26335) (me…
…tabase#26393) Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for e6223ce - Browse repository at this point
Copy the full SHA e6223ceView commit details -
[E2E] Fix grep spec filtering (metabase#26387) (metabase#26403)
* [E2E] Fix grep spec filtering * Add undocumented `grepIntegrationFolder`
Configuration menu - View commit details
-
Copy full SHA for 1df37e1 - Browse repository at this point
Copy the full SHA 1df37e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b423229 - Browse repository at this point
Copy the full SHA b423229View commit details -
Configuration menu - View commit details
-
Copy full SHA for 075cdaf - Browse repository at this point
Copy the full SHA 075cdafView commit details -
Remove
@types/isomorphic-fetch
(metabase#26408) (metabase#26414)Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e34b33e - Browse repository at this point
Copy the full SHA e34b33eView commit details -
Remove unused
underscore
import (metabase#26410) (metabase#26423)Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for bf59886 - Browse repository at this point
Copy the full SHA bf59886View commit details -
Migrate slack forms to formik (metabase#26273) (metabase#26420)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 3f245c1 - Browse repository at this point
Copy the full SHA 3f245c1View commit details -
Fix Bigquery timestamp to date/datetime conversion with report time z…
…one (metabase#26383) (metabase#26427) * Refactor: replace cast and add `mt/with-driver :bigquery-cloud-sdk` where report-timezone is relevant * Add failing tests * Fix failing tests * Technically it should be bigquery-type Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for fb0fdc1 - Browse repository at this point
Copy the full SHA fb0fdc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0363029 - Browse repository at this point
Copy the full SHA 0363029View commit details -
Make sure lazy seqs get realized during CSV exports (metabase#26327) (m…
…etabase#26433) * realize lazy seqs during exports * add test & helper * update based on tamas's comment * use mapv * remove unused import * try to fix test * switch to using just a LocalDate for the second test since the ZonedDateTime test was failing for certain drivers and not others, and that isnt relevant to this test Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 5f4bebf - Browse repository at this point
Copy the full SHA 5f4bebfView commit details
Commits on Nov 12, 2022
-
Add dashboard-id to remarks in Redshift driver (metabase#26086) (meta…
…base#26464) * Adding parameters based on the comment * add tests Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by: Luis Paolini <paoliniluis@gmail.com> Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cde4cb1 - Browse repository at this point
Copy the full SHA cde4cb1View commit details
Commits on Nov 14, 2022
-
Allow for "deep-copy" of a dashboard (metabase#25530) (metabase#26476)
Co-authored-by: dpsutton <dan@dpsutton.com>
Configuration menu - View commit details
-
Copy full SHA for 62bfcf1 - Browse repository at this point
Copy the full SHA 62bfcf1View commit details
Commits on Nov 15, 2022
-
Rerun flaky workflows on
master
andrelease
branches (metabase#26495) (metabase#26498) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0f1f954 - Browse repository at this point
Copy the full SHA 0f1f954View commit details -
Move the config-from-file code into the advanced-config directory sin…
…ce that's the feature we want to flag on (metabase#26461) (metabase#26496) Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c1df5cb - Browse repository at this point
Copy the full SHA c1df5cbView commit details -
Row chart polish (metabase#26183) (metabase#26511)
* fix showing placeholder series * row chart polish * wip * don't use nice x ticks for stacked expand chart * make grouped row not clickable * update specs * update specs
Configuration menu - View commit details
-
Copy full SHA for 740fd58 - Browse repository at this point
Copy the full SHA 740fd58View commit details -
Fix inconsistency in number of documents scanned (metabase#26514) (me…
…tabase#26515) The docs say that Metabase scans the first X documents of a collection where X is first "ten thousand" and later "200", looking at the file with git blame the most recent value edited is "ten thousand" so I expect that to be the correct one. Co-authored-by: Davide Lettieri <davide.lettieri@gmail.com> Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by: Davide Lettieri <davide.lettieri@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8e01863 - Browse repository at this point
Copy the full SHA 8e01863View commit details -
Extract common error messages (metabase#26432) (metabase#26524)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for cf6a3c2 - Browse repository at this point
Copy the full SHA cf6a3c2View commit details -
Reveal new sample db tables by default (metabase#26505) (metabase#26522)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 554d3a4 - Browse repository at this point
Copy the full SHA 554d3a4View commit details -
🤖 backported "Add a way to pause/resume and reset each authentication…
… method" (metabase#26521) * Add a way to pause/resume and reset each authentication method (metabase#26430) * Fix type issue Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 6da3f84 - Browse repository at this point
Copy the full SHA 6da3f84View commit details -
docs - basic env var doc gen (metabase#26428) (metabase#26527)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c2fd903 - Browse repository at this point
Copy the full SHA c2fd903View commit details
Commits on Nov 16, 2022
-
Adding option to hide edit button on ChartSettingOrderedSimple compon…
…ent (metabase#26394) (metabase#26533) * Adding option to hide edit button on ChartSettingOrderedSimple component * Small Cleanup Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 211313d - Browse repository at this point
Copy the full SHA 211313dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bff533d - Browse repository at this point
Copy the full SHA bff533dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27b368c - Browse repository at this point
Copy the full SHA 27b368cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d3ad96 - Browse repository at this point
Copy the full SHA 1d3ad96View commit details -
[CI] Optimize workflows - skip runs on unrelated changes (metabase#26518
) (metabase#26535) * Simplify filter glob pattern for frontend tests Take a look at the cheat sheet: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet '**/docs/**' matches `docs/hello.md` and `dir/docs/my-file.txt` * Ignore unrelated paths for `backend` workflow even in `master` * Ignore unrelated paths for `drivers` workflow even in `master` * Ignore clojure tests in E2E workflows * Increase the ignored paths scope for `uberjar` workflow
Configuration menu - View commit details
-
Copy full SHA for 85ec93f - Browse repository at this point
Copy the full SHA 85ec93fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 612499d - Browse repository at this point
Copy the full SHA 612499dView commit details -
Separate MBQL schema for time vs date/datetime literals (metabase#26502…
…) (metabase#26537) * Create TemporalLiteral, DateOrDatetimeLiteral, TimeLiteral * Remove unused TemporalLiteralString schema * Add tests * Fix test for cljs * Only test clj Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1ebf6c3 - Browse repository at this point
Copy the full SHA 1ebf6c3View commit details -
[CI] Upgrade
deploysentinel
tov0.5.8
(metabase#26525) (metabase#……26540) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e01cfb0 - Browse repository at this point
Copy the full SHA e01cfb0View commit details -
Add app DB and version to common snowplow event context (metabase#26390…
…) (metabase#26546) * add app DB and version to common snowplow event context * use .getDatabaseProductName for db type * fix kondo error * add new instance schema with app db type and version fields * add maxLength to new fields * address cam's feedback Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 83b7ce1 - Browse repository at this point
Copy the full SHA 83b7ce1View commit details -
[CI] Upgrade
deploysentinel
tov0.6.0
(metabase#26558) (metabase#……26560) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 281fea2 - Browse repository at this point
Copy the full SHA 281fea2View commit details -
docs - update people (metabase#26493) (metabase#26561)
Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 5d70c2a - Browse repository at this point
Copy the full SHA 5d70c2aView commit details -
Adding Color Picker for Metrics (metabase#26486) (metabase#26544)
* Adding Color Picker for Metrics * Adding support for breakout charts * Addressing some PR Feedback * Adding pillSize to color picker components * Moving updateSeriesColor logic to visualizations/lib * Typing viz/lib/series * Final PR Feedback adjustments Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 7b0b2e1 - Browse repository at this point
Copy the full SHA 7b0b2e1View commit details
Commits on Nov 17, 2022
-
Wrap sidebar actions in Query Builder View Footer (metabase#26553) (m…
…etabase#26562) Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 09aa68c - Browse repository at this point
Copy the full SHA 09aa68cView commit details -
Initial support for datetimeDiff (metabase#25722) (metabase#26557)
* Initial support for pg for `date-diff` * Make the useful-dates closer to one day * Add simple FE stuff * shorter test bodies * Ensure we can use datediff functions in arithmetic expressions * Correctly disable datediff for redshift * simplify var names * Support week * cleanup test * :datediff -> :datetimediff * ngoc's suggestions * Better acceptance test for datetimediff * sort ns * embrace the different cases for results * bigquery day month year * Reverse args * Update test * Centralize tests * Change postgres day, month, year behaviour * Refactor keep identity * Tidy tests * Tidy * Fix bigquery week * Add week tests * Fix bigquery week * Change mysql day, month, year behaviour * Add test for hour, minute, second * Fix postgres hour minute second * Formatting * Fix bigquery hour, minute, second * Formatting * Fix postgres timestamptz * WIP * Allow literals in datediff clauses * Uncomment tests * Fix bigquery when reporting timezone is not UTC * Linting * Moving away from dataset based tests * Add timezone tests for week and tidy * Remove unused import * Consolidate tests * Remove with-time-column dataset * Remove more-useful-dates defdataset * Remove redshift driver WIP * Typo * Move DatetimeLiteral clause into DateTimeExpressionArg * Try changing test order * Remove mt/with-report-timezone-id nil * Add year report timezone tests * Rename * Rename * Remove unused tables from useful-dates * Remove useful-dates * Update helper-text-strings * Tidy * Swap order of mt/with-report-timezone-id * Change with-report-timezone-id; notify databases after running test * Use temp setting for report-timezone instead * Update helper-test-strings * Handle literals in `datetimediff-base-base` * Update src/metabase/driver/postgres.clj Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * Simplify postgres second * Tidy: prefer hx arithmetic functions * Drop coercion for string timestamp args for now * Extract helper * Revert "Change with-report-timezone-id; notify databases after running test" This reverts commit 7abb543. * Use ->timestamptz * Use hx/->timestamp * Rename dataset * Undo changes to datetime-arithmetics? as these will not match by default * Use proper format for offset datetime literals * Shorten datetime literals in tests * Removing notify-all-databases-updated from report-timezone setting * Fix datetime-arithmetics test * Revert "Fix datetime-arithmetics test" This reverts commit 9141582. * Revert "Undo changes to datetime-arithmetics? as these will not match by default" This reverts commit 9cb05f5. * Add UTC timezone to tests * Coerce strings to datetimes for ISO formats * Revert "Removing notify-all-databases-updated from report-timezone setting" This reverts commit 3735643. * Add comment to postgres driver implementation * Formatting * Disable datediff from redshift for the moment (for ever?) * Override redshift driver/database-supports? * Fix comments mixed up by refactoring * Fix comments mixed up by refactoring 2 * Tidy comment * Rename datetimediff to datetime-diff/datetimeDiff * date-add -> datetime-add * Linting * add datetime-subtract to `datetime-arithmetics?` rework tests a bit as well. * Update docstring * Use ->temporal-type and trunc to handle report-timezone for bigquery * Log errors caught during sync steps (metabase#26306) * log errors caught during sync steps * remove accidental extra parens * Errors combining datetime interval addition with datetime functions (metabase#26279) * Add failing tests * Fix failing tests * Update shared/src/metabase/mbql/util.cljc Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> * datetime-add and datetime subtract should annotate type by col type * Fix infer-expression-type for datetime-add/subtract with second, minute, hour * Undo last commit; they actually always return :type/DateTime * Fix test based on last commit * Undo unrelated refactor * Only test drivers that support expressions * Only test drivers that support expressions, again * Update tests from legacy mbql * Change infered-col-type to be a function again, not macro * Fix test Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> * whitespace * Remove comments * Add explanation for datetime_diff * Refactor: replace cast and add `mt/with-driver :bigquery-cloud-sdk` where report-timezone is relevant * Add failing tests * Fix failing tests * Technically it should be bigquery-type * Update modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com> * Move documentation to metabase.mbql.schema * Update DatetimeDiffUnits Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com> * Add error type and optimize case expressions to driver implementations * refactor for brevity * Fix error with postgres * Fix error with postgres * Handle string literal parsing in wrap-value-literals * Remove ->timestamptz * Add comments + TODOs showing arithmetic expressions should return numeric values * Add explanation of arithmetic expression as docstring * Add test for normalize-mbql-clause-tokens * Remove unused import * Remove unused form * Switch tests to use attempted-murders dataset * Undo optimization that broke tests * Validate non-temporal types for bigquery * Add error handling for incorrect types * Fix mysql type checking * Fix mysql type checking * invalid-parameter -> invalid-query * Use date-trunc and extract * Remove unit error handling * DatetimeLiteral -> DateOrDatetimeLiteral * Remove unused binding * Fix mysql type checking Co-authored-by: Callum Herries <hi@callumherries.com> Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com> Co-authored-by: dpsutton <dan@dpsutton.com> Co-authored-by: Callum Herries <hi@callumherries.com> Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for bf1129e - Browse repository at this point
Copy the full SHA bf1129eView commit details -
Always apply the :settings section first in the config file (metabase…
…#26462) (metabase#26552) * Move the config-from-file code into the advanced-config directory since that's the feature we want to flag on * Always apply the :settings section first in the config file * Apply suggestions from code review Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com> Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8d0ff55 - Browse repository at this point
Copy the full SHA 8d0ff55View commit details -
🍒 Backport "Fix sqlserver does not respect start-of-week when bucket …
…by week" (metabase#26551) * Fix sqlserver does not respect `start-of-week` when bucket by `week` (metabase#26474) - Add tests to check when bucketing by week and week-of-year behave consistently, Closes metabase#4910 - While doing the above, found that sqlserver does not respect `start-of-week` setting, so fix that. Fix metabase#25356 * fix failing tests for sqlite (metabase#26543) Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7a793d8 - Browse repository at this point
Copy the full SHA 7a793d8View commit details -
Fix resetting inputs on data model page (metabase#26550) (metabase#26568
Configuration menu - View commit details
-
Copy full SHA for 22c10d4 - Browse repository at this point
Copy the full SHA 22c10d4View commit details -
Fix feedback on dashcard resizing (metabase#26569) (metabase#26570)
Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 59db945 - Browse repository at this point
Copy the full SHA 59db945View commit details -
Fix mongo failed to parse
absolute-datetime
(metabase#26509) (metab……ase#26574) Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8147939 - Browse repository at this point
Copy the full SHA 8147939View commit details
Commits on Nov 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 26c89d8 - Browse repository at this point
Copy the full SHA 26c89d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b2a498 - Browse repository at this point
Copy the full SHA 4b2a498View commit details -
Simplify two-case-functions-test (metabase#26485) (metabase#26605)
Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a80b564 - Browse repository at this point
Copy the full SHA a80b564View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d344dd - Browse repository at this point
Copy the full SHA 7d344ddView commit details -
Fix hidden columns click behavior (metabase#26547) (metabase#26603)
* handle null value correctly on the row chart (metabase#26528) * Fix invisible columns click behavior [ci nocache] (metabase#26547)
Configuration menu - View commit details
-
Copy full SHA for 771856e - Browse repository at this point
Copy the full SHA 771856eView commit details -
Use clone icon for duplicate in dashboard page (metabase#26607) (meta…
…base#26618) Co-authored-by: Gustavo Saiani <gus@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 3e51854 - Browse repository at this point
Copy the full SHA 3e51854View commit details -
Fix dependabot issues for 45 (metabase#26604) (metabase#26622)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 97d5789 - Browse repository at this point
Copy the full SHA 97d5789View commit details
Commits on Nov 19, 2022
-
Group Axes for Multi-series static viz (metabase#26145) (metabase#26626)
* First pass at grouping axes This PR uses the results_metadata key to look at fingerprints for numerical axes to try determine if each series on the Y axis can be sanely represented on the same axis. This is done by calculating an overlap (some value between 0 and 1) and grouping all axes on the LEFT if they pass the threshold, which is some value between 0 and 1. The overlap is always calculated when there is SOME overlap between the ranges of each axis, and is calculated as: ```clojure (/ (- (max maximums) (min minimums)) (- (min maxiumums) (max minimums))) ``` This is done to try catch situations where one column's range is entirely inside the other, but is much smaller (- max min); such a case would have a small percent overlap by the above calculation, and implies that it might be better to split the axes. * Address feedback. * Fix shape of data in tests of 2 private fns * Add test for split axes * Fixed error in test util * render-utils does with-redef, disallows parallel tests. Makes sense Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 92b4b59 - Browse repository at this point
Copy the full SHA 92b4b59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5995df8 - Browse repository at this point
Copy the full SHA 5995df8View commit details
Commits on Nov 21, 2022
-
Upgrade jest to the latest major version 29 (metabase#26566) (metabas…
…e#26636) * Upgrade `jest` to the latest version (29.3.1) * Add `jest-environment-jsdom` as a separate package This was a breaking change since the version 28 * Upgrade `@types/jest` to the latest version * Upgrade `babel-jest` to the latest version * Upgrade `@testing-library/jest-dom` to the latest version * Upgrade `@types/testing-library__jest-dom` to the latest version * Upgrade `jest-localstorage-mock` to the latest version * Upgrade `jest-watch-typeahead` to the latest version * fix jest config for v29 * fix specs Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com> Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1fdbade - Browse repository at this point
Copy the full SHA 1fdbadeView commit details -
Serdes v2: Fixing some more cases of malformed SQL with empty databas…
…es (metabase#26134) (metabase#26653) Mostly this was caused by `:id [:in []]` empty lists if eg. you don't have any non-personal collections, or no dashboards exist. Also I broke the argument passing to the selective dump command `extract-subtrees` a while back and this fixes it. Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for a9bf5f0 - Browse repository at this point
Copy the full SHA a9bf5f0View commit details
Commits on Nov 22, 2022
-
[E2E] Optimize testing matrix on
master
andrelease
branches (met……abase#26638) (metabase#26642) - run all EE tests against EE uberjar and only a small subset of OSS-specific tests against OSS uberjar
Configuration menu - View commit details
-
Copy full SHA for 137c3a4 - Browse repository at this point
Copy the full SHA 137c3a4View commit details -
[CI] Ignore backend changes in
frontend
workflow (metabase#26595) (m……etabase#26664) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c2d5896 - Browse repository at this point
Copy the full SHA c2d5896View commit details -
[E2E] Remove
cy2
(hosted library for sorry-cypress dashboard analyt……ics) (metabase#26644) (metabase#26665) * Remove `cy2` (SorryCypress library) * Stop recording Cypress tests using Currents dashboard service
Configuration menu - View commit details
-
Copy full SHA for 3474d58 - Browse repository at this point
Copy the full SHA 3474d58View commit details -
Serdes v2: Include a Card's
:result_metadata
in serdes (metabase#26154) (metabase#26668) It can theoretically be reconstructed on the other side, but it can be expensive, and also causes problems when Cards depend on other Cards. (The metadata of the parent card is needed by the child, but it is assumed to exist, not recursively reconstructed.) Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for b9308d5 - Browse repository at this point
Copy the full SHA b9308d5View commit details -
Serdes v2: Don't overwrite Database.details with nil when deserializi…
…ng (metabase#26133) (metabase#26674) Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 030714c - Browse repository at this point
Copy the full SHA 030714cView commit details
Commits on Nov 23, 2022
-
Refactor mbql schema for numeric-expressions and date-time-expressions (
metabase#26635) (metabase#26675) Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 32adf6e - Browse repository at this point
Copy the full SHA 32adf6eView commit details -
convert-timezone for postgres (metabase#25698) (metabase#26689)
Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 96581c1 - Browse repository at this point
Copy the full SHA 96581c1View commit details -
Fix static gauge chart that segments has their min and max swapped (m…
…etabase#26692) (metabase#26694) Co-authored-by: Mahatthana (Kelvin) Nomsawadi <mahatthana.n@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 328ea3f - Browse repository at this point
Copy the full SHA 328ea3fView commit details -
fix row chart bugs (metabase#26683) (metabase#26696)
* fix row chart bugs * review
Configuration menu - View commit details
-
Copy full SHA for d667a21 - Browse repository at this point
Copy the full SHA d667a21View commit details -
docs - notes on model search (metabase#26681) (metabase#26702)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cdfb296 - Browse repository at this point
Copy the full SHA cdfb296View commit details -
docs - prometheus (metabase#26616) (metabase#26707)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3aabfc9 - Browse repository at this point
Copy the full SHA 3aabfc9View commit details -
Fix Click Behavior not working for Funnel (metabase#26340) (metabase#…
…26703) Co-authored-by: swk777 <swk777@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ce02796 - Browse repository at this point
Copy the full SHA ce02796View commit details -
note on translation (metabase#26705) (metabase#26709)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b909aad - Browse repository at this point
Copy the full SHA b909aadView commit details -
Serdes v2: Backfill entity_id based on identity-hash before serdes (m…
…etabase#26118) (metabase#26708) This makes deserialization faster since entity_id columns are indexed. Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 0e936d3 - Browse repository at this point
Copy the full SHA 0e936d3View commit details -
Serdes v2: Search for dependencies both on the filesystem and the app…
…db (metabase#26217) (metabase#26710) This allows smaller selective exports that (for example) don't need to include the data model if you know the other side has it. Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for ba088c4 - Browse repository at this point
Copy the full SHA ba088c4View commit details -
Serdes v2: Migrate
DashboardCard
s to be inlined in their `Dashboard……`s (metabase#26330) (metabase#26712) Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for d045bb5 - Browse repository at this point
Copy the full SHA d045bb5View commit details -
Make it clearer you're creating a new question when saving (metabase#…
…26048) (metabase#26693) * make it clearer you're creating a new question * fix the function Co-authored-by: Maz Ameli <maz@metabase.com> Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9489d27 - Browse repository at this point
Copy the full SHA 9489d27View commit details -
docs - update sync, scan troubleshooting (metabase#26572) (metabase#2…
…6716) Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for de8f061 - Browse repository at this point
Copy the full SHA de8f061View commit details -
Serdes v2: Inline TimelineEvents under Timelines (metabase#26489) (me…
…tabase#26719) This also changes the semantics of `metabase.models.serialization.base/load-find-local` to return the whole entity, not just the ID. `load-one!` always needs the whole entity (if it exists) anyway, and some of the `load-find-local` implementations had the entity already loaded but just passed along the ID. This saves some double lookups, especially for inlining eg. `DashboardCard`s under `Dashboard`. Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 7992284 - Browse repository at this point
Copy the full SHA 7992284View commit details -
remove unused file (metabase#26715) (metabase#26718)
Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0eef08b - Browse repository at this point
Copy the full SHA 0eef08bView commit details
Commits on Nov 24, 2022
-
return white text color more frequently (metabase#26723) (metabase#26735
Configuration menu - View commit details
-
Copy full SHA for f800b66 - Browse repository at this point
Copy the full SHA f800b66View commit details -
Serdes v2: Add more human-friendly labels to more models (metabase#26508
) (metabase#26734) Card, Dashboard, Dimension, Metric, NativeQuerySnippet, Segment and Timeline all now using their `:name` fields for the file label. File names should now be more human-friendly. Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 05bcdbe - Browse repository at this point
Copy the full SHA 05bcdbeView commit details -
Serdes v2: Properly export and import
Field.fk_target_field_id
(met……abase#26556) (metabase#26738) This was breaking Metabase's understanding of foreign keys after deserialization. Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 6dc8cab - Browse repository at this point
Copy the full SHA 6dc8cabView commit details -
sort order copy fix (metabase#26722) (metabase#26745)
Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e3d0d51 - Browse repository at this point
Copy the full SHA e3d0d51View commit details
Commits on Nov 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fd836ae - Browse repository at this point
Copy the full SHA fd836aeView commit details -
Fix weird static viz data point value rounding (metabase#26748) (meta…
…base#26751) * Fix weird static viz data point values rounding * Fix incorrect static viz formatting * Fix failing tests Co-authored-by: Mahatthana (Kelvin) Nomsawadi <mahatthana.n@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 658f631 - Browse repository at this point
Copy the full SHA 658f631View commit details
Commits on Nov 28, 2022
-
remove console polluting error (metabase#26767) (metabase#26768)
Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1625481 - Browse repository at this point
Copy the full SHA 1625481View commit details -
docs - data reference updates (metabase#26772) (metabase#26775)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8e298be - Browse repository at this point
Copy the full SHA 8e298beView commit details -
Manual backport color name autocompletion (metabase#26753)
* Make it possible to autocomplete `color()` function (metabase#26732) * Fix partial palette not working (metabase#26752)
Configuration menu - View commit details
-
Copy full SHA for 116aad6 - Browse repository at this point
Copy the full SHA 116aad6View commit details -
docs - update signed embedding (metabase#26741) (metabase#26779)
Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 5ebb8a4 - Browse repository at this point
Copy the full SHA 5ebb8a4View commit details
Commits on Nov 29, 2022
-
convert timezone requires source timezone (metabase#26763) (metabase#…
…26781) convert-timezone now requires source-timezone if the input column doesn't have timezone Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7e3f531 - Browse repository at this point
Copy the full SHA 7e3f531View commit details -
Add "migrate down" command to roll back to last major version schema (m…
…etabase#26429) (metabase#26778) * Adds rollback where necessary to v45 migrations * Adds linter for migrations requiring rollback key * Removes unused writeback table migrations * Removes migrate down-one subcommand Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1e077f0 - Browse repository at this point
Copy the full SHA 1e077f0View commit details -
org.apache.xmlgraphics/batik-all 1.14 -> 1.16 (metabase#26780) (metab…
…ase#26808) Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ebcd424 - Browse repository at this point
Copy the full SHA ebcd424View commit details -
Replacing xmlhttprequest with https.request (metabase#26727) (metabas…
…e#26805) Co-authored-by: Luis Paolini <paoliniluis@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a0a756e - Browse repository at this point
Copy the full SHA a0a756eView commit details -
Changing border color for fill-barckground Segmented Control (metabas…
…e#26756) (metabase#26774) Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 8e91b0f - Browse repository at this point
Copy the full SHA 8e91b0fView commit details
Commits on Nov 30, 2022
-
Doing isBreakout check sooner, removing column formatting from 2nd di…
…mension (metabase#26777) (metabase#26813) * Doing isBreakout check sooner, removing column formatting from 2nd dimension * PR Feedback * separating showColumnSettings and showColumnSettingsForIndicies Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 3d6a8d3 - Browse repository at this point
Copy the full SHA 3d6a8d3View commit details -
🤖 backported "Match static combo chart colors and legends with app vi…
…z colors" (metabase#26782) * Match static combo chart colors and legends with app viz colors (metabase#26211) * Match static combo chart colors with app viz colors * Match colors when individual series color is set * Remove tests that test colors Since colors is now determined in FE * Fix static viz Series type * Match static progress bar colors with app viz colors * Simplify Clojure code, makes it more idiomatic * Fix certain combo charts don't respect whitelabel colors * Make Clojure code more idiomatic * Fix Series type * Add colors back to static internal page * Simplify type predicate * fix colors matching for multiple series with mulitple metrics or dimensions * Handle legends not formatted in static viz in some cases * Fix failed BE tests after BE API changed * Fix failed BE tests after BE API changed * Add multiple series dashcard test to `getSeriesWithColors` test * Add `getSeriesWithLegends` tests * Fix URL `/_internal/static-viz` not loading due to API change * Correctly render legend when having dashcard title set * Simplify combo-chart API don't really need `settings-seqs` yet * Make static combo chart component type easier to understand * Address review: refactor `render-multiple-lab-chart` * Make variable names easier to understand * Simplify color API * Address review on `body.clj` * Address review, make parameter name more consistent * Fix multiple scalars not rendering * Remove unused imports * Fix conflict from auto backport Co-authored-by: Mahatthana (Kelvin) Nomsawadi <mahatthana.n@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 401aab5 - Browse repository at this point
Copy the full SHA 401aab5View commit details -
Serdes v2: Inline
Dimension
s under their parentField
s (metabase#……26669) (metabase#26796) Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 08da575 - Browse repository at this point
Copy the full SHA 08da575View commit details -
Adding graph.series_order_dimension (metabase#26624) (metabase#26720)
* Adding graph.series_order_dimension * Handling adding and removing order items * Adding test for funnel viz * PR Feedback * Simplifying ChartSettingOrderedSimple. Moving logic to Settings Defs * Fixing Row Chart rendering, adding bar chart test * Resolving type check errors * Adjusting series_order empty values * Updating orderItem prop check * adjusting getOrderedSeries Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 49c7020 - Browse repository at this point
Copy the full SHA 49c7020View commit details -
Make all toggles inline (metabase#26744) (metabase#26749)
Co-authored-by: Nick Fitzpatrick <nick@metabase.com> Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e54e307 - Browse repository at this point
Copy the full SHA e54e307View commit details -
convert-timezone expression for sqlserver, mysql, mariadb, oracle, ve…
…rtica (metabase#25790) (metabase#26827) * convert-timezone for mysql, mariadb, sqlserver, oracle * sqlserver doesn't understand Asia/Ho_Chi_Minh * vertica * skip report-tz tests for sqlserver * use the util fn to check args for convert-timezone * fix for vertica not formatting in report-tz 🎉 Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e2854b5 - Browse repository at this point
Copy the full SHA e2854b5View commit details -
adding border to pivot table sort buttons (metabase#26733) (metabase#…
…26773) * adding border to pivot table sort buttons * Changing to use Button component Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for f4e765e - Browse repository at this point
Copy the full SHA f4e765eView commit details -
Adjusting style of Column Title label in Table Viz (metabase#26757) (m…
…etabase#26814) * Adjusting style of Column Title label in Table Viz * removing all form-field lable types Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for fbd2f6f - Browse repository at this point
Copy the full SHA fbd2f6fView commit details -
docs - rough serialization and config file updates (metabase#26389) (m…
…etabase#26831) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a03ea9e - Browse repository at this point
Copy the full SHA a03ea9eView commit details -
Athena driver (metabase#26301) (metabase#26811)
* Include Amazon Athena support for dacort/metabase-athena-driver * Use Metabase Maven repo to fetch Athena driver * Copy test extensions from Damon's Athena driver repo * Some code cleanup. * Move namespaces => metabase.driver.athena * Clean up the test extensions namespace * 42 failures, 16 errors * Fix regex support; disable a few tests * Minor tweaks * Fix data-source-name * Fix :week and :day-of-week impls (mostly): 2 failures, 3 errors * Fix OFFSET, :week-of-year; skip test that has TIME column * Add Athena to CircleCI config. Don't wait for Java 11 tests to finish before driver tests. * ALL TESTS ARE PASSING! <3 * Copy fixes for dacort/metabase-athena-driver#115; add test * We don't need to prep source files or fetch dependencies before running backend tests. * Fix Eastwood error. * Tweak CircleCI config. * Fix TIMESTAMP WITH TIME ZONE * Include the Athena/Redshift repos in the build-drivers deps.edn * Build and release scripts need to have the :mvn/repos as well * Revert change that enabled test for Presto * Un-enable failing test for Snowflake as well. * moves all is clauses into the test - previously only the first few tests were being run * Sort ns in `metabase.driver.athena-test` * Prevent athena's log4j2.properties file from becoming log config athena includes log4j2.properties top-level with the properties: ``` status = debug rootLogger.level=debug ``` And this kills our beautifully crafted logging. Set "log4j2.configurationFile" in bootstrap to our own log4j2.xml. Log4j2 looks in a few places for its logging config, the first of which is the properties file. So when the jar is loaded, log4j2 considers this a logging config change and we lose our logging. Co-authored-by: Damon P. Cortesi <d.lifehacker@gmail.com> Co-authored-by: Bryan Maass <bryan.maass@gmail.com> Co-authored-by: dan sutton <dan@dpsutton.com> Co-authored-by: Damon P. Cortesi <d.lifehacker@gmail.com> Co-authored-by: Bryan Maass <bryan.maass@gmail.com> Co-authored-by: dan sutton <dan@dpsutton.com>
Configuration menu - View commit details
-
Copy full SHA for dc789df - Browse repository at this point
Copy the full SHA dc789dfView commit details
Commits on Dec 1, 2022
-
allow null dataset query (metabase#26654) (metabase#26855)
Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for fe2f81e - Browse repository at this point
Copy the full SHA fe2f81eView commit details -
Make sure the new datetime functions work with literal (metabase#26706)…
… (metabase#26854) * datetime-add, datetime-subtract, temporal-extract, convert-timezone now can takes datetime literal as argument * fix vertica Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for aaf8354 - Browse repository at this point
Copy the full SHA aaf8354View commit details -
Convert-timezone for bigquery, snowflake, redshift (metabase#26633) (m…
…etabase#26875) * Bigquery * Redshift * Snowflake * no convert-timezone for sparksql because it only has one timestamp data type * redshift -- wrap type when adding interval * don't override results-timezone-id in tests * fix redshift ignore timezone when insert timestamp with time zone test data Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8dbfcf5 - Browse repository at this point
Copy the full SHA 8dbfcf5View commit details -
Fix sticky filters in embed mode (metabase#26857) (metabase#26870)
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for d8d03b6 - Browse repository at this point
Copy the full SHA d8d03b6View commit details -
Fix bug where grouping strategy would NPE when fingerprint was
nil
(m……etabase#26659) (metabase#26686) * Fix bug where grouping strategy would NPE when fingerprint was `nil` The axes grouping relies on fingerprint data existing, AND for now only works on :type/Number columns, so this bugfix guards against those situations where the logic would fail. The bug that brought this to my attention came up when there was a Custom column. This set the col-meta count to be one greater than the count of the 'real' columns, which threw off my old assumptions, where if the grouped-columns count was less than the total col-meta count, you had a potential grouping. This broke in part because some custom columns are essentially derived from a real column, and so will most likely be groupable with the column they're derived from. Anyway, this filters out columns that won't work, so we hopefully eliminate the problem. * Update src/metabase/pulse/render/body.clj Co-authored-by: Tim Macdonald <tim@metabase.com> * Fix some broken logic Co-authored-by: Tim Macdonald <tim@metabase.com> Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by: Tim Macdonald <tim@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 6b54667 - Browse repository at this point
Copy the full SHA 6b54667View commit details -
Update datetime-diff tests to support more drivers (metabase#26817) (m…
…etabase#26846) * Replace attempted-murders where possible * Replace mt/rows with mt/formatted-rows * Remove integer test and change comment Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 395275c - Browse repository at this point
Copy the full SHA 395275cView commit details -
Remove
is_write
card property on the FE (metabase#26879) (metabase#……26883) Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2316e65 - Browse repository at this point
Copy the full SHA 2316e65View commit details -
inputs ui unification (metabase#26593) (metabase#26877)
Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3fde8e5 - Browse repository at this point
Copy the full SHA 3fde8e5View commit details -
🤖 backported "Respect chart orders in static viz" (metabase#26884)
* Respect chart orders in static viz (metabase#26797) * Refactor so static combo chart is ready for reordering * Correct test names * Clean up static viz combo chart BE API * sort static combo chart * Order static funnel chart * Remove unused import and function * Fix BE tests * Remove custom column name tests since logic is moved to FE * Remove graph.series_order when changing dimensions (metabase#26842) * review Co-authored-by: Nick Fitzpatrick <nick@metabase.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com> * fix import Co-authored-by: Mahatthana (Kelvin) Nomsawadi <mahatthana.n@gmail.com> Co-authored-by: Nick Fitzpatrick <nick@metabase.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dcd6836 - Browse repository at this point
Copy the full SHA dcd6836View commit details -
Serdes v2: Rebuild the directory structure to be more human-friendly (m…
…etabase#26793) (metabase#26888) There are now three top-level trees: - regular `collections/path/to/collection/...` - `:namespace :snippet` collections in `snippets/path/to/collection/...` - `databases/mydb/schemas/PUBLIC/tables/customers/fields/name.yaml` The path for any given entity is determined by the `serdes.base/storage-path` multimethod. On the ingestion side, things are a bit tricky because the paths don't map directly to `:serdes/meta` hierarchies anymore. Instead each model registers a function to turn a file path into either a `:serdes/meta` hierarcy or nil for a bad match. Ingestion will fetch all these functions once and then try them all in arbitrary order until one matches. Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for b71efd9 - Browse repository at this point
Copy the full SHA b71efd9View commit details -
Build datetime filters as datetime before question is saved (metabase…
…#26679) (metabase#26909) Co-authored-by: Gustavo Saiani <gus@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for e2ecebc - Browse repository at this point
Copy the full SHA e2ecebcView commit details
Commits on Dec 2, 2022
-
fix audit dashboards click behavior (metabase#26908) (metabase#26915)
Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 6762a1c - Browse repository at this point
Copy the full SHA 6762a1cView commit details -
docs - note on dashboard deep copy (metabase#26921) (metabase#26924)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e4f79b7 - Browse repository at this point
Copy the full SHA e4f79b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for bda06f5 - Browse repository at this point
Copy the full SHA bda06f5View commit details -
Pie percentages switch (metabase#26721) (metabase#26925)
* pie percent switch * review * Migrate to card viz-settings v.2 (metabase#26798) * Migrate to card viz-settings v.2 This uses the new :pie.percent_visibility key (an enum) instead of a collection of booleans [metabase#26776] * Move to def-json-migration * Don't migrate empty values * fix specs Co-authored-by: Tim Macdonald <tim@metabase.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by: Tim Macdonald <tim@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 4627075 - Browse repository at this point
Copy the full SHA 4627075View commit details -
Bump SSHd => 2.9.2 (metabase#26878) (metabase#26927)
Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b1a3859 - Browse repository at this point
Copy the full SHA b1a3859View commit details -
Add Arabic and update all translations for x.45 (metabase#26913) (met…
…abase#26931) * update pot for x.45 * create new po file for arabic * add translation changes * pull in finished translations Co-authored-by: Maz Ameli <maz@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for b62282c - Browse repository at this point
Copy the full SHA b62282cView commit details -
Fix
has-user-setup
Setting not being cached correctly (metabase#26841……) (metabase#26933) * Fix `has-user-setup` Setting not being cached correctly * Fix Kondo error Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f5497e5 - Browse repository at this point
Copy the full SHA f5497e5View commit details -
docs - convertTimezone, datetimeAdd, datetimeSubtract, and datetimeDi…
…ff (metabase#26685) (metabase#26929) Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 975ef4b - Browse repository at this point
Copy the full SHA 975ef4bView commit details -
Fixes remapped columns support for the row chart type (metabase#26845) (
metabase#26880) * fix row chart for remapped columns * static viz remapped values
Configuration menu - View commit details
-
Copy full SHA for 411cb5f - Browse repository at this point
Copy the full SHA 411cb5fView commit details -
Extract sample DB to plugins directory on startup (metabase#26828) (m…
…etabase#26876) * initial implementation * some refactor and improved error handling * another refactor * fix reflection warning * add test and more refactor * another test * misc comment improvements and formatting * fix tests * small refactor * fix function call * address tamas's comments Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 20a6f76 - Browse repository at this point
Copy the full SHA 20a6f76View commit details -
config-from-file should check that we have a premium token with `:adv…
…anced-config` (metabase#26463) (metabase#26936) * Move the config-from-file code into the advanced-config directory since that's the feature we want to flag on * Always apply the :settings section first in the config file * config-from-file should check that we have a premium token with the :advanced-config feature * Sort namespace * Settings does not have to come first anymore * Remove empty `binding` forms * Test fix? 🔧 * Test fix? 🔧 * Fix failing tests, for real this time * Revert "Fix failing tests, for real this time" This reverts commit 0a57055. * Don't make the tests parallel since that breaks other stuff Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com> Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 84950bb - Browse repository at this point
Copy the full SHA 84950bbView commit details
Commits on Dec 3, 2022
-
last minute translations for x.45 (metabase#26941) (metabase#26942)
Co-authored-by: Maz Ameli <maz@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 4e41d76 - Browse repository at this point
Copy the full SHA 4e41d76View commit details
Commits on Dec 5, 2022
-
list Athena as official (metabase#26958) (metabase#26964)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1d0ef46 - Browse repository at this point
Copy the full SHA 1d0ef46View commit details -
fix snowflake tests (metabase#26965) (metabase#26968)
Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0c94fb4 - Browse repository at this point
Copy the full SHA 0c94fb4View commit details -
Serdes v2: Fix flaky e2e test (metabase#26934) (metabase#26970)
It could generate Dimensions which depend on their own parent Fields, which causes the Fields to have circular deps and fail to load. This prevents Fields from allowing dependencies on themselves. Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 4f7f946 - Browse repository at this point
Copy the full SHA 4f7f946View commit details -
docs - update datetimediff (metabase#26978) (metabase#26980)
Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for ae7df50 - Browse repository at this point
Copy the full SHA ae7df50View commit details
Commits on Dec 6, 2022
-
Fix datetime literal format in datetime function docs (metabase#26973) (
metabase#26985) * Fix formatting for datetime function docs * Undo datetimeAdd and datetimeSubtract Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 550981d - Browse repository at this point
Copy the full SHA 550981dView commit details -
Fix incorrect datetime-diff results for bigquery on leap years (metab…
…ase#26815) (metabase#26986) * Add failing tests * Fix bigquery * Formatting Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7bca229 - Browse repository at this point
Copy the full SHA 7bca229View commit details -
add data.xml to deps.edn (metabase#26993) (metabase#26998)
Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0bfab66 - Browse repository at this point
Copy the full SHA 0bfab66View commit details -
docs - add limitations, formatting (metabase#26963) (metabase#27004)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b7d3815 - Browse repository at this point
Copy the full SHA b7d3815View commit details -
Fix inconsistence temporal extract for timestamptz columns for h2 (me…
…tabase#26824) (metabase#26987) Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for edb4529 - Browse repository at this point
Copy the full SHA edb4529View commit details -
Serdes v2: Correctly (de)serialize references to segments and native …
…snippets (metabase#26881) (metabase#27006) Co-authored-by: Braden Shepherdson <braden@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 804213a - Browse repository at this point
Copy the full SHA 804213aView commit details -
Remove legacy form framework references in docs (metabase#26995) (met…
…abase#27013) Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bd84fe0 - Browse repository at this point
Copy the full SHA bd84fe0View commit details -
Revert "Remove support for Heroku deployment (metabase#25124) (metaba…
…se#26298)" (metabase#27010) This reverts commit b7bb6ae. * Update docs/installation-and-operation/running-metabase-on-heroku.md Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 74f7257 - Browse repository at this point
Copy the full SHA 74f7257View commit details -
[Docs] Fix external broken link (metabase#27018) (metabase#27019)
* [Docs] Fix external broken link * Link to the Cypress intro page without anchors * Exclude Cypress links from checks all together * Add back `.html` extension to the link Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e51b831 - Browse repository at this point
Copy the full SHA e51b831View commit details -
Change hasBreakout check (metabase#26821) (metabase#27024)
* Change hasBreakout check * Adding computedSettings prop to ChartSettings Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for dc9e3bb - Browse repository at this point
Copy the full SHA dc9e3bbView commit details
Commits on Dec 7, 2022
-
🍒 Backport (pre) release script (metabase#27021)
* Retrofit the release workflow to be useful for doing a pre-release (metabase#26597) * Retrofit the release workflow to be useful for doing a pre-release * Distinguish between `metabase` main repo and the custom ones * Truncate commit id to specific hash length We need to make sure all images are tagged with exactly the same hash length in order to avoid having multiple images for the same commit. * Enforce full commit SHA-1 hash is used for an input `actions/checkout@v3` will fail if full SHA-1 hash is not provided. We want to use this implicit mechanism as an enforcing function for uniform manual inputs. * Never run script from the main repo - This greatly simplifies things. - The script is meant to be run from forks of Metabase for testing purposes and/or for custom builds. * Safeguard against missing `CUSTOM_RELEASE_REPO` Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com> * [CI] Fix pre-release config typo (metabase#26647) * Fix pre-release config typo * Fix conditional containing environment variable * [CI] Fix another typo in the pre-release workflow (metabase#26662) * Package (Docker) image automatically on a tagged release (OSS and EE) (metabase#26725) Co-authored-by: Ariya Hidayat <ariya@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 88ee24a - Browse repository at this point
Copy the full SHA 88ee24aView commit details -
Use fields instead of literals for datetime-diff tests (metabase#26917)…
… (metabase#27039) * Replace literals for datetime-diff-time-zones-test * Actually use fields * Fix typo * Rename dataset * Add type/DateTimeWithTZ column, since redshift doesn't like type/DateTimeWithZoneOffset Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 76643f0 - Browse repository at this point
Copy the full SHA 76643f0View commit details -
datetime-diff function for snowflake (metabase#26746) (metabase#27041)
* Add snowflake datetime-diff implementation * Get timestamps without timezones or offsets working * Convert to timestamp_tz, not timestamp * Format rows in tests * Fix snowflake set-parameter * Add failing tests * Fix bigquery * Formatting * Replace literals for datetime-diff-time-zones-test * Revert "Fix snowflake set-parameter" This reverts commit c24348a. * Actually use fields * Fix typo * Rename dataset * Add type/DateTimeWithTZ column, since redshift doesn't like type/DateTimeWithZoneOffset * Fix snowflake for time zones * Undo changes to extract and date-trunc * Explicitly set UTC timezone * Fix mismatched types * Remove redundant bindings * Remove redundant comment * Add failing tests * Remove duplicate dataset
Configuration menu - View commit details
-
Copy full SHA for 073aa9b - Browse repository at this point
Copy the full SHA 073aa9bView commit details -
docs - athena notes (metabase#27026) (metabase#27046)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a66a12b - Browse repository at this point
Copy the full SHA a66a12bView commit details -
Athena Driver: change auth method description and helper text (metaba…
…se#27016) (metabase#27047) * review athena manifest * review case and add helper text * add better helper text to AWS Credentials Provider Chain * fix capitalization * add helper text to password too * Update modules/drivers/athena/resources/metabase-plugin.yaml Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> Co-authored-by: Luiz Arakaki <luiz.arakaki@metabase.com> Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 019d31c - Browse repository at this point
Copy the full SHA 019d31cView commit details -
docs - update public links (metabase#27022) (metabase#27057)
Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for bcd8012 - Browse repository at this point
Copy the full SHA bcd8012View commit details
Commits on Dec 8, 2022
-
Fix flaky
remap-human-readable-string-column-test
(metabase#27050) (m……etabase#27060) * Fix flaky `remap-human-readable-string-column-test` Quite annoying test that would flake quite a bit in CI. the problem is that the mechanism for `mt/with-column-remappings` wasn't aware of the case when there were pre-existing mappings. It just blindly added a new mapping. But when the middleware fetching the remappings, it found the preexisting ones. For the venue.name field in this test, that was ("20th Century Cafe","25°","33 Taps","800 Degrees Neapolitan Pizzeria", ...). We were passing in fake names like "apple", "banana", "kiwi" and it found no remappings for those in the db. So the fix is to check for pre-existing ones, and if found, use `tu/with-temp-vals-in-db` to temporarily set them to the desired values, otherwise use some new ones with `tt/with-temp*` as it was doing previously. * log errors for CI * Only use type :full field values when remapping we store cached chained filter values in here (with type :linked-filter, there are also type :sandbox in there) but the :full are the ones that are used for remapping. In the tests, if the chain link tests have already run, there can be 6 field values for the field here (`(mt/id :venues :name)`) and we want to make sure we update the full one, not the chain filter ones ```clojure [{:hash_key "576275248", :has_more_values false, :last_used_at #t "2022-12-07T21:08:35.592931Z", :type :linked-filter, :updated_at #t "2022-12-07T21:10:22.972907Z", :human_readable_values ("Appletini" "Bananasplit" "Kiwi-flavored Thing"), ;; the test updatedthe existing :linked-filter one :id 560, :values ("apple" "banana" "kiwi"), :field_id 15, :created_at #t "2022-12-07T21:08:35.592931Z"} {:hash_key "-897793959", :has_more_values false, :last_used_at #t "2022-12-07T21:08:35.695344Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:35.695344Z", :human_readable_values [], :id 564, :values ("Kinaree Thai Bistro" "Krua Siri"), :field_id 15, :created_at #t "2022-12-07T21:08:35.695344Z"} {:hash_key "388078290", :has_more_values false, :last_used_at #t "2022-12-07T21:08:35.742561Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:35.742561Z", :human_readable_values [], :id 566, :values ("Tacos Villa Corona" "Tito's Tacos"), :field_id 15, :created_at #t "2022-12-07T21:08:35.742561Z"} {:hash_key "-299897589", :has_more_values false, :last_used_at #t "2022-12-07T21:08:35.777517Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:35.777517Z", :human_readable_values [], :id 567, :values ("Festa" "Fred 62"), :field_id 15, :created_at #t "2022-12-07T21:08:35.777517Z"} {:hash_key "-391654650", :has_more_values false, :last_used_at #t "2022-12-07T21:08:36.681046Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:36.681046Z", :human_readable_values [], :id 569, :values ("Baby Blues BBQ" "Beachwood BBQ & Brewing" "Bludso's BBQ"), :field_id 15, :created_at #t "2022-12-07T21:08:36.681046Z"} {:hash_key "1784886858", :has_more_values false, :last_used_at #t "2022-12-07T21:08:36.860010Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:36.860010Z", :human_readable_values [], :id 572, :values ("Baby Blues BBQ" "Beachwood BBQ & Brewing" "Bludso's BBQ"), :field_id 15, :created_at #t "2022-12-07T21:08:36.860010Z"} {:hash_key nil, :has_more_values false, :last_used_at #t "2022-12-07T21:04:04.299251Z", :type :full, ;; but should have updated this one :updated_at #t "2022-12-07T21:04:04.299251Z", :human_readable_values [], :id 4, :values ("20th Century Cafe" "25°" "33 Taps" "800 Degrees Neapolitan Pizzeria" "BCD Tofu House"), :field_id 15, :created_at #t "2022-12-07T20:57:21.896298Z"}] ``` * remove CI logging Co-authored-by: dpsutton <dan@dpsutton.com>
Configuration menu - View commit details
-
Copy full SHA for 49a0d1a - Browse repository at this point
Copy the full SHA 49a0d1aView commit details -
Fix numeric parameter values in jwt (metabase#26969) (metabase#27061)
* Fix numeric parameter values in jwt Don't call `seq` on numbers. If its a string, assert it isn't blank, otherwise check that it is non-null. * bind (:value request-param) Co-authored-by: dpsutton <dan@dpsutton.com>
Configuration menu - View commit details
-
Copy full SHA for 9913e28 - Browse repository at this point
Copy the full SHA 9913e28View commit details -
Manual backport for datetime-diff function for vertica metabase#26816 (…
…metabase#27066) * vertica datetime-diff implementation * Don't need type info * Refactor implementation * Fix seconds * Cast to timestamp before comparison
Configuration menu - View commit details
-
Copy full SHA for 1f3b6b6 - Browse repository at this point
Copy the full SHA 1f3b6b6View commit details -
docs - update custom destinations (metabase#27017) (metabase#27049)
Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 30fc339 - Browse repository at this point
Copy the full SHA 30fc339View commit details -
fix add series modal (metabase#27059)
Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com> Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 45eb2b8 - Browse repository at this point
Copy the full SHA 45eb2b8View commit details -
CI for release: verify that the downloaded Uberjar is a valid JAR file (
metabase#27051) (metabase#27079) Co-authored-by: Ariya Hidayat <ariya@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 39345ce - Browse repository at this point
Copy the full SHA 39345ceView commit details -
Unskip repro for metabase#25031 (metabase#27081) (metabase#27086)
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for cd9bf86 - Browse repository at this point
Copy the full SHA cd9bf86View commit details -
Remove unused import (metabase#27027) (metabase#27077)
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ea94941 - Browse repository at this point
Copy the full SHA ea94941View commit details
Commits on Dec 9, 2022
-
Disable Athena driver IAM role-based auth in Cloud (metabase#27048) (m…
…etabase#27100) Fixes metabase#27014 Our cloud hosting requires using hard coded IAM auth for Athena. So make sure that if the access_key is left blank, we only fall back to the credential chain if we are not in a hosted environment. Co-authored-by: Case Nelson <case@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 4c6bfba - Browse repository at this point
Copy the full SHA 4c6bfbaView commit details -
datetime-diff function for redshift (metabase#26758) (metabase#27067)
* Add redshift implementation * Add failing tests * Fix bigquery * Formatting * fix? set-param for redshift * Replace literals for datetime-diff-time-zones-test * Actually use fields * Fix typo * Rename dataset * Add type/DateTimeWithTZ column, since redshift doesn't like type/DateTimeWithZoneOffset * Cast to timestamp for week diff * Revert "fix? set-param for redshift" This reverts commit 235f3ac. * Fix leap years * Remove redundant date-trunc * Formatting * Fix mismatched types * Fix extract * Add comment for why redshift needs an implementation Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for df8b912 - Browse repository at this point
Copy the full SHA df8b912View commit details -
Add is_superuser (metabase#27093) (metabase#27109)
* Update config-file.md * Update docs/configuring-metabase/config-file.md Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Update config-file.md Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> Co-authored-by: Luis Paolini <paoliniluis@gmail.com> Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6c7e2d1 - Browse repository at this point
Copy the full SHA 6c7e2d1View commit details -
docs - update can't view or edit troubleshooting (metabase#27091) (me…
…tabase#27120) Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for ce006a9 - Browse repository at this point
Copy the full SHA ce006a9View commit details -
docs - update permissions troubleshooting (metabase#27092) (metabase#…
…27121) Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 1cd2ac4 - Browse repository at this point
Copy the full SHA 1cd2ac4View commit details
Commits on Dec 10, 2022
-
Migrate MySQL latest driver test to GitHub Actions (metabase#27071) (m…
…etabase#27135) * Migrate MySQL latest driver test to GitHub Actions * Increase the timeout for MySQL latest driver test * Make env vars available to the host machine * Increase the timeout again * Bump timeout to 1h for all driver tests
Configuration menu - View commit details
-
Copy full SHA for ef48e0f - Browse repository at this point
Copy the full SHA ef48e0fView commit details
Commits on Dec 12, 2022
-
🍒 Backport Additional drivers to GitHub Actions (metabase#27168)
* Do not run driver tests when PR is in a draft mode (metabase#27078) * Do not run driver tests when PR is in a draft mode * Use the conditional directly on the job level * Migrate Vertica driver test to GitHub Actions (metabase#27148) * Migrate vertica driver test to GitHub Actions * Bump runner for vertica * Do not use matrix as it messes the output * Add vertica port to the image config * Go back to the official GitHub runner * Migrate Athena, GA and Redshift drivers tests to GitHub Actions (metabase#27151) * Migrate Google Analytics driver test to GitHub Actions * Migrate Redshift driver test to GitHub Actions * Migrate Athena driver test to GitHub Actions * Migrate Snowflake driver test to GitHub Actions (metabase#27103) * Migrate Snowflake driver test to GitHub Actions * Do not run test when PR is in a draft mode * Dial down timeout to 60 minutes
Configuration menu - View commit details
-
Copy full SHA for de2361a - Browse repository at this point
Copy the full SHA de2361aView commit details -
CI for release: use up-to-date actions/download-artifact@v3 (metabase…
…#27153) (metabase#27155) This gets rid of the following GitHub Action warning message: ``` check-uberjar (17) Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/download-artifact@v2 ``` Co-authored-by: Ariya Hidayat <ariya@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for de59ea6 - Browse repository at this point
Copy the full SHA de59ea6View commit details -
Release script: remove the container build & push (metabase#26726) (m…
…etabase#27152) This step is taken care automatically (see `.github/workflow/release.yml`) Co-authored-by: Ariya Hidayat <ariya@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 214ca7c - Browse repository at this point
Copy the full SHA 214ca7cView commit details -
[Docs] Add app colors examples (metabase#26806) (metabase#27189)
* Add app colors example * Update docs/configuring-metabase/environment-variables.md Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * formatting Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by: jeff bruemmer <jeff.bruemmer@gmail.com> Co-authored-by: Luis Paolini <paoliniluis@gmail.com> Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by: jeff bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0f5ff39 - Browse repository at this point
Copy the full SHA 0f5ff39View commit details -
Update token check URL, using the current one as the fallback (metaba…
…se#27090) (metabase#27167) * update token check URL, using the current one as the fallback * update comment * fix tests * update docstring * update doc string again Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ae5701b - Browse repository at this point
Copy the full SHA ae5701bView commit details -
[Docs] Approved domains (metabase#27108) (metabase#27190)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a061531 - Browse repository at this point
Copy the full SHA a061531View commit details
Commits on Dec 13, 2022
-
🍒 Backport BQ, classpath and Presto JDBC driver tests to GitHub Actio…
…ns (metabase#27195) * Migrate BigQuery and classpath driver tests to GitHub actions (metabase#27162) * Migrate BigQuery SDK driver test to GitHub Actions * Migrate Google related classpath drivers test to GitHub Actions * Multi-line strings are not working? * Provide BQ envs * Migrate Presto JDBC driver test to GitHub Actions (metabase#27164) * Remove Presto 186 config We've already migrated it to GitHub actions. * Migrate Presto JDBC driver test to GitHub Actions * Wait for port to be ready * Try `presto-jdbc` driver * Wait for port before creating certificates
Configuration menu - View commit details
-
Copy full SHA for bb7820e - Browse repository at this point
Copy the full SHA bb7820eView commit details -
Migrate Mongo 4.0 and 5.0 driver tests to GitHub Actions (metabase#27147
) (metabase#27203) * Migrate Mongo 5 ssl driver test to GitHub Actions * Migrate Mongo 4 ssl driver test to GitHub Actions * Make Mongo certificates available * Try `docker exec` for Mongo 4.0 * Remove `TTY` from the `exec` * Try overriding the entrypoint * Include `mongod` in entrypoint * Quote entrypoint command * Quote only the command * Omit `--dbpath` * Try running the docker container manually * Detach containers * Reduce the timeout
Configuration menu - View commit details
-
Copy full SHA for 9c67403 - Browse repository at this point
Copy the full SHA 9c67403View commit details -
Remove the Java 11 workflow from CircleCI (metabase#27095) (metabase#…
…27208) Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a9803fa - Browse repository at this point
Copy the full SHA a9803faView commit details
Commits on Dec 14, 2022
-
🍒 Backport drivers and backend workflow changes (metabase#27227)
* Add `clojure -M:ee:drivers:check` to CI (metabase#27011) * Try `dorny/test-reporter` (metabase#27194) * [CI] Add `concurrency` to the `drivers` workflow (metabase#27223) * Increase backend tests timeout for GitHub Actions (metabase#26374) Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 31d0e58 - Browse repository at this point
Copy the full SHA 31d0e58View commit details -
Suppress console log when using
with-log-messages-for-level
(metaba……se#26468) (metabase#27219) * disable additivity when using "with-log-level" * only set when parent is root * wording * remove a test that is no longer needed * fix indents * one missing indent fix Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d53a34d - Browse repository at this point
Copy the full SHA d53a34dView commit details -
Relieve db pressure on api/health check (metabase#27192) (metabase#27230
) * Relieve db pressure on api/health check metabase#26266 Servers under heavy load can be slow to respond to the api/health check. This can lead to k8s killing healthy instances happily humming along serving requests. One idea floated was to use QoSFilters https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/servlets/QoSFilter.html to prioritize those requests in front of others. But I suspect this might not be our bottleneck. Our health endpoint was updated to see if it could acquire an endpoint when we were dealing with connection pool issues. We were reporting the instance was healthy once it has finished the init process, but would report healthy if 60/15 app-db connections were used and no actual queries could complete. The remedy was adding `(sql-jdbc.conn/can-connect-with-spec? {:datasource (mdb.connection/data-source)})` to the endpoint. But now to get information about the health of the system we have to wait in the queue to get a datasource. The hope is that this change which monitors for recent db checkins (query success) and checkouts (query begun) can be a proxy for db activity without having to wait for a connection and hit the db ourselves. Some simple and crude benchmarking: - use `siege` to hit `api/database/<app-db>/sync_schema` - in a separate tab, use `siege` to hit `api/health` Three trials with unconditional db access and conditional db access (look for recent activity set by the new `ConnectionCustomizer`). One siege client is synching the app-db's schema with 80 clients each sending 60 requests. the other has 1 client sending 60 requests to api/health. Run | Elapsed Time | max tx | tx rate before change | 7.16s | 0.79s | 8.38 tx/s before change | 23.91s | 1.44s | 2.51 tx/s before change | 13.00s | 0.50s | 4.62 tx/s ---------------------------------------------------- after change | 4.46s | 0.27s | 13.45 tx/s after change | 5.81s | 0.61s | 10.33 tx/s after change | 4.54s | 0.44s | 13.22 tx/s Full(er) results below: ``` Unconditional db access ======================= siege -c80 -r 40 "http://localhost:3000/api/database/2/sync_schema POST" -H "Cookie: $SESSION" siege -c 1 -r 60 "http://localhost:3000/api/health" Elapsed time: 7.16 secs Response time: 0.12 secs Transaction rate: 8.38 trans/sec Longest transaction: 0.79 Shortest transaction: 0.01 Elapsed time: 23.91 secs Response time: 0.40 secs Transaction rate: 2.51 trans/sec Longest transaction: 1.44 Shortest transaction: 0.02 Elapsed time: 13.00 secs Response time: 0.22 secs Transaction rate: 4.62 trans/sec Longest transaction: 0.50 Shortest transaction: 0.06 Conditional db access ============================================================== Elapsed time: 4.46 secs Response time: 0.07 secs Transaction rate: 13.45 trans/sec Longest transaction: 0.27 Shortest transaction: 0.01 Elapsed time: 5.81 secs Response time: 0.10 secs Transaction rate: 10.33 trans/sec Longest transaction: 0.61 Shortest transaction: 0.00 Elapsed time: 4.54 secs Response time: 0.08 secs Transaction rate: 13.22 trans/sec Longest transaction: 0.44 Shortest transaction: 0.01 ``` * Remove reflection in `.put` call (not the reflections trategy) also remove the call to `classloader/the-classloader` as it did nothing * Comment and settle on a single method * tests * select from db twice had a failure in CI. give it time to do its thing with another db call * block to wait for timestamp update? * unflake the tests tasks and events from outside the thread can hit the db. the ConnectionCustomizer is also run from c3p0 controlled threads so we can't easily isolate everything to our thread Was running ```clojure (comment (dotimes [n 5] (dotimes [_ 100] (recent-activity-test) (CheckinTracker-test)) (println (* (inc n) 100))) ) ``` to run the tests 500 times and would keep getting flakes at a rate ~1/100 to 1/500. Just frustration for the future. * typehint * Switch it up a bit Tests were flaking in h2 and I don't know why. I'm switching to just updating recent activity on most methods. Co-authored-by: dpsutton <dan@dpsutton.com>
Configuration menu - View commit details
-
Copy full SHA for c2451f2 - Browse repository at this point
Copy the full SHA c2451f2View commit details -
Fix datetime-diff helper text (metabase#27224) (metabase#27226)
Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 862e2d7 - Browse repository at this point
Copy the full SHA 862e2d7View commit details -
Improve collection breadcrumbs in embedding (metabase#26977) (metabas…
…e#27243) * Hide side bar toggle when appropriate * Show collection breadcrumbs by default * Address review: Simplifying the code. * Address review: Cleanup boolean names * Fix Cypress test failure after behavior change * Rename some boolean flag to avoid confusion * Add embedding tests Co-authored-by: Mahatthana (Kelvin) Nomsawadi <mahatthana.n@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 08700e8 - Browse repository at this point
Copy the full SHA 08700e8View commit details -
docs - make version history easier to find (metabase#27247) (metabase…
…#27251) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 60e4858 - Browse repository at this point
Copy the full SHA 60e4858View commit details
Commits on Dec 15, 2022
-
docs - update general settings, localization, and timezones (metabase…
…#27193) (metabase#27255) Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 746ad9f - Browse repository at this point
Copy the full SHA 746ad9fView commit details -
Add dedicated docs pages for some expressions (metabase#27163) (metab…
…ase#27261) Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 571a26c - Browse repository at this point
Copy the full SHA 571a26cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdf18f5 - Browse repository at this point
Copy the full SHA fdf18f5View commit details -
🍒 Backport removing last CircleCI fragments (metabase#27266)
* [CI] Migrate `cloverage` linter to GitHub Actions (metabase#27233) * Migrate Oracle driver test to GitHub Actions (metabase#27149) * Migrate Oracle driver test to GitHub Actions * Provide Oracle server details * Add "Hello, World!" CircleCI config
Configuration menu - View commit details
-
Copy full SHA for 80eaa5c - Browse repository at this point
Copy the full SHA 80eaa5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77f1dd2 - Browse repository at this point
Copy the full SHA 77f1dd2View commit details
Commits on Dec 16, 2022
-
docs - ip addresses to whitelist for token check (metabase#27284) (me…
…tabase#27289) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 46f2839 - Browse repository at this point
Copy the full SHA 46f2839View commit details -
docs - fix link (metabase#27294) (metabase#27298)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 725177a - Browse repository at this point
Copy the full SHA 725177aView commit details
Commits on Dec 20, 2022
-
🤖 backported "Open absolute urls not relatively to a metabase instanc…
…e" (metabase#27283) * open absolute urls not relatively to a metabase instance (metabase#27097) * fix unstable check that the navbar exists Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d2f3382 - Browse repository at this point
Copy the full SHA d2f3382View commit details -
🍒 Backport reproductions for 2022-12-19 (metabase#27336)
* Repro metabase#27257: Number filter with 0 (zero) as default value shows as empty in the widget (metabase#27324) * Reproductions metabase#27020 and metabase#27105: static-viz failing for certain date formatting options (metabase#27330) * Repro metabase#27279: Changing sorting does not apply for X-axis anymore (metabase#27333)
Configuration menu - View commit details
-
Copy full SHA for eb15499 - Browse repository at this point
Copy the full SHA eb15499View commit details -
only query for db-metadata once per sync operation + scan each table … (
metabase#27211) * only query for db-metadata once per sync operation + scan each table for its PKs (metabase#26810) * memoize snowflake describe-database w/ 5 min ttl * pass in db-metadata where it is used, - rather than querying for it in random functions * update callsite of sync-tables-and-database! * let sync-metabase-metadata! look up db-metadata - only when needed * pass catalog (db), and schema to .getPrimaryKeys * let describe-table* add in the nil table-name * cleanup * use :snowflake instead of driver for inheritance * concurrent-sync-test should call describe-database once * cleaning up * call add-table-pks with 3 args * call add-table-pks with 3 args * try escaping entity names to appease Oracle Driver - Oracle wants the table-name to be escaped - escape is usually a no-op * pass driver to escape entity * pull get-table-pks into a multimethod, - handle the discrepancy directly in Oracle driver * remove inline def * fix colliding consistent-namespace linting - metabase.driver.sql-jdbc.common and metabase.driver.sql-jdbc.sync.common were mapped to sql-jdbc.common - metabase.driver.sql-jdbc.sync.common is now mapped to sql-jdbc.sync.common * fix reflection warnings * apply fix for getting oracle pks * nix an unused arg * Update modules/drivers/oracle/src/metabase/driver/oracle.clj Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com> Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com> Co-authored-by: Luiz Arakaki <luiz.arakaki@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for a1bea1f - Browse repository at this point
Copy the full SHA a1bea1fView commit details
Commits on Dec 21, 2022
-
Error when user attribute is null for sandboxing (metabase#27351) (me…
…tabase#27358) * error on null user attributes * fix test Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e6616a2 - Browse repository at this point
Copy the full SHA e6616a2View commit details
Commits on Dec 22, 2022
-
Fix Zero Filters not loading URL Parameters (metabase#27342) (metabas…
…e#27372) * use null coalescing operator to allow numeric zero values * add tests * update storybook types Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9da0389 - Browse repository at this point
Copy the full SHA 9da0389View commit details -
Fixes to static-viz datetime formatter, in particular, issues metabas…
…e#27020 and metabase#27105 (metabase#27339) (metabase#27378) * Handle abbreviation and date-separator in a fn, where defaults are passed in in any place where nil COULD exist Moving abbreviation and date-separator string changes into a post-processing fn allows each unit case to handle the date-style default formatting, and eliminates the problem of date-style being `nil` in the let statement. It was this scenario where `abbreviate` was `true`, but `date-style` was `nil`. In many cases, if `date-style` is nil, then so is `abbreviate` and `date-separator`, in fact, the default from the frontend sends nil for all of these keys. In such a case, none of the branches run and nil is safely passed through. It is then handled appropriately with `(or ...)` expressions in each entry for the case statement. But, it is indeed possible to have a nil `date-style` with non-nil `abbreviate` or `date-separator` keys. Now, the post-process-date-style function is only ever called AFTER the default date-style is set in whatever case branch is needed. * Turn frontend day format 'dddd' into backend format 'EEEE' The frontend sends a datetime format string to the backend and some elements are not equivalent to the expectations the java datetime formatter has. * Unskip e2e reproductions * Add a test for all 'written date' combos * These tests fail b/c I fixed the 'default' from Abbreviated to non-abbreviated * Add test 'matrix' for numerically formatted dates, and each separator * Finally, add tests to confirm that custom-formatting is applied
Configuration menu - View commit details
-
Copy full SHA for afaaa66 - Browse repository at this point
Copy the full SHA afaaa66View commit details -
Fix custom columns lose their definition in embeddings (metabase#27119)…
… (metabase#27382) * Fix input widget with parameter using incorrect type When a FieldValuesWidget as `parameter` prop, it indicates that it is tied to a dashboard parameter, so we should use parameter instead of field type when rendering the component. * Add a test * Address review * Remove wrong JSdoc types * Fix failed E2E test due to wrong mock parameter type Co-authored-by: Mahatthana (Kelvin) Nomsawadi <mahatthana.n@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2437cd9 - Browse repository at this point
Copy the full SHA 2437cd9View commit details
Commits on Dec 23, 2022
-
🍒 Backport repros created on 2022-12-22 (metabase#27397)
* Repro metabase#25374: Comma-separated dashboard filter values not passed down to the question (metabase#27381) * Repro metabase#25927: Column filters not working on questions with custom columns (metabase#27388) * Repro metabase#27123: Exclude filter always ends up showing "Days of the week" (metabase#27389) * Repro metabase#27380: Doing "Zoom in" from dashboard drops fields from joined tables (metabase#27390)
Configuration menu - View commit details
-
Copy full SHA for 124dff9 - Browse repository at this point
Copy the full SHA 124dff9View commit details -
docs - revise embedding docs (metabase#27375) (metabase#27401)
* explanation and connective tissue * heading promotion * formatting * note on full-app embedding * hyphen Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1f30526 - Browse repository at this point
Copy the full SHA 1f30526View commit details -
docs - small updates (metabase#27412) (metabase#27414)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5843594 - Browse repository at this point
Copy the full SHA 5843594View commit details
Commits on Dec 24, 2022
-
🍒 Backport reproductions from 2022-12-23 (metabase#27411)
* Repro metabase#24839: Can't aggregate if source is the aggregated question (metabase#27396) * Repro metabase#26861: "Exclude" field filter breaks native query (metabase#27400) * Repro metabase#25994: Between specific dates filter fails after aggregation (metabase#27404)
Configuration menu - View commit details
-
Copy full SHA for 466c31a - Browse repository at this point
Copy the full SHA 466c31aView commit details -
[CI] Upgrade
deploysentinel
to the latestv0.7.0
(metabase#27409) (……metabase#27416) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 5814d7a - Browse repository at this point
Copy the full SHA 5814d7aView commit details -
[CI] Upgrade
percy/cli
to the latest version (metabase#27407) (meta……base#27418) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 31e3f66 - Browse repository at this point
Copy the full SHA 31e3f66View commit details
Commits on Dec 27, 2022
-
🍒 Backport repros 2022-12-27 (metabase#27433)
* Repro metabase#27356: Moving between dashboards with/without filter triggers an error (metabase#27428) * Repro metabase#25378: Relative date filter on breakout after aggregation (metabase#27429)
Configuration menu - View commit details
-
Copy full SHA for ea3d90a - Browse repository at this point
Copy the full SHA ea3d90aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 147b15b - Browse repository at this point
Copy the full SHA 147b15bView commit details
Commits on Dec 28, 2022
-
Revert conditional
concurrency
attempt (metabase#27451)The diff should match metabase@3fe1727
Configuration menu - View commit details
-
Copy full SHA for 0e49d95 - Browse repository at this point
Copy the full SHA 0e49d95View commit details
Commits on Dec 29, 2022
-
Fix BigQuery parsing of
bigdecimal
results (metabase#27248) (metaba……se#27445) * Fix BigQuery parsing of `bigdecimal` results * Avoid big changes to `ns` form * Update tests Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a1d2de0 - Browse repository at this point
Copy the full SHA a1d2de0View commit details -
🍒 Backport reproductions from 2022-12-28 and 2022-12-29 (metabase#27461)
* Repro metabase#27427: Static-viz fails for unused returned column (metabase#27441) * Repro metabase#19373: Pivot table returns wrong (distinct) row totals (metabase#27457) * Repro metabase#18770: Post-aggregation filter disrupts drill-through (metabase#27459) * Repro metabase#25250: Pivot Table doesn't show stand-alone values on collapsed sub-level grouping (metabase#27460)
Configuration menu - View commit details
-
Copy full SHA for 2b0e818 - Browse repository at this point
Copy the full SHA 2b0e818View commit details
Commits on Jan 3, 2023
-
Revert "Manual backport for datetime-diff function for vertica metaba…
…se#26816 (metabase#27066)" (metabase#27222) This reverts commit 1f3b6b6.
Configuration menu - View commit details
-
Copy full SHA for 2074e25 - Browse repository at this point
Copy the full SHA 2074e25View commit details
Commits on Jan 4, 2023
-
docs - add hydra to list of community drivers (metabase#27488) (metab…
…ase#27501) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for da2ceb9 - Browse repository at this point
Copy the full SHA da2ceb9View commit details
Commits on Jan 5, 2023
-
Revert "datetime-diff function for redshift (metabase#26758) (metabas…
…e#27067)" (metabase#27221) This reverts commit df8b912.
Configuration menu - View commit details
-
Copy full SHA for edbc48c - Browse repository at this point
Copy the full SHA edbc48cView commit details -
Disallow axis ranges with the same min/max, which causes divide by ze…
…ro error (metabase#27518) (metabase#27535) * Disallow axis ranges with the same min/max, which causes divide by zero error The group-axes private fn is used to try group series axes together if the ranges of the series are 'close enough', which is calculated by determining the percentage overlap the ranges share. As the comparison is made, the first series in the list will always be compared with itself, and should have 1.0 (100%) overlap, as the ranges are going to be identical. The divide by zero issue arises when this first series, and potentially any other series, has a 'range' where the min and max are the same. This happens if the series has the same value in every row. With this change, these ranges are considered invalid, and we avoid the divide by zero. * Unskip e2e repro Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9bdaa39 - Browse repository at this point
Copy the full SHA 9bdaa39View commit details
Commits on Jan 6, 2023
-
allow for 3rd party logger configs (metabase#27536)
``` docker run \ -p 3000:3000 \ -v $PWD/my_log4j2.xml:/tmp/my_log4j2.xml \ -e JAVA_OPTS=-Dlog4j.configurationFile=/tmp/my_log4j2.xml \ metabase/metabase:v0.45.1 ``` From metabase#27497 Note that this specifies `log4j.configurationFile` and not "log4j2.configurationFile" that we set in our bootstrap.clj. I'm not sure if this is supposed to work or not but we'll give it a shot. the Automatic Configuration section of https://logging.apache.org/log4j/2.x/manual/configuration.html specifies that: 1. Log4j will inspect the "log4j2.configurationFile" system property and, if set, will attempt to load the configuration using the ConfigurationFactory that matches the file extension. Note that this is not restricted to a location on the local file system and may contain a URL. I'm not sure if that other property will work due to some other mechanism or log4j2 has an undocumented back-compat mechanism.
Configuration menu - View commit details
-
Copy full SHA for 8ad468f - Browse repository at this point
Copy the full SHA 8ad468fView commit details
Commits on Jan 9, 2023
-
🤖 backported "Ensuring _raw prop is present on transformed series in …
…line/area/bar …" (metabase#27371) * ensuring _raw prop is present on transformed series in line/area/bar charts (metabase#27357) * backporting type dependencies Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 071ff2d - Browse repository at this point
Copy the full SHA 071ff2dView commit details -
Fix e2e Repro which works in 46 with new H2 driver, not 45 (old H2) (m…
…etabase#27593) This e2e test failed in the 45 release branch because 46 (in progress on mater at time of writing) has an upgraded H2 driver, which was not backported. This meant that the e2e test's expection of a graph.dimension of `EXTRACT(YEAR FROM CURRENT_TIMESTAMP)` would cause the static-viz render to fail because the actual dimension would be `YEAR(CURRENT_TIMESTAMP())`. The fix to the underlying problem is still valid, and this reproduction, with the correct dimension, tests the fix and behaves correctly.
Configuration menu - View commit details
-
Copy full SHA for 79239f7 - Browse repository at this point
Copy the full SHA 79239f7View commit details
Commits on Jan 10, 2023
-
Remove panning logic from map boundary calculation (metabase#27392) (m…
…etabase#27603) * remove panning logic from map boundary calculation * add map viz percy tests * wait for map load in visual tests Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 63d4ea4 - Browse repository at this point
Copy the full SHA 63d4ea4View commit details -
Add processing step to the date format string so that we get Day of M…
…onth (metabase#27557) (metabase#27600) Since the frontend sends a date-style string with various differences from how Java's Date Formatter expects things, we need to post-process some bits. The 'D' -> 'd' string replacement was missed in the post processing fn, and so in some cases it was missed altogether, causing this bug. Existing tests in `metabase.pulse.render.datetime-test` and `metabase.pulse.render.table-test` should already catch this issue. Prior to the change they would fail, but they now pass after adding this PR's changes. Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 567d283 - Browse repository at this point
Copy the full SHA 567d283View commit details -
Fix cannot select fields for double aggregations (metabase#27559) (me…
…tabase#27567) * Fix double aggregation not working on some fields. This fix adds make sure the table field source is `fields` as this is done in the previous version before we changed it in PR#25267 which introduces the bug in issue#27462 * Add a reproduction * Address review: Improve test readability Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
Configuration menu - View commit details
-
Copy full SHA for dbd1a77 - Browse repository at this point
Copy the full SHA dbd1a77View commit details -
Use Oxford comma for formatting parameter values in text cards with m…
…ore than 2 items (metabase#27585) (metabase#27592) * oxford comma for parameter values with more than 2 items * refactor logic to use a better translated string and fix tests Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d964993 - Browse repository at this point
Copy the full SHA d964993View commit details
Commits on Jan 11, 2023
-
Remove
Renovate
integration (metabase#27621) (metabase#27631)Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for db72c38 - Browse repository at this point
Copy the full SHA db72c38View commit details -
remove sql server page and redirect (metabase#27630) (metabase#27633)
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ecb63b3 - Browse repository at this point
Copy the full SHA ecb63b3View commit details
Commits on Jan 12, 2023
-
🤖 backported "Parse comma-separated list of numbers as URL filter par…
…ams" (metabase#27571) * Parse comma-separated list of numbers as URL filter params (metabase#27436) * Trigger CI [ci nocache] Co-authored-by: Gustavo Saiani <gus@metabase.com> Co-authored-by: Gustavo Saiani <gustavo@poe.ma>
Configuration menu - View commit details
-
Copy full SHA for 1ab2ffb - Browse repository at this point
Copy the full SHA 1ab2ffbView commit details -
27356 switch dashboards filters (metabase#27425) (metabase#27570)
* temp * Adding cypress test * removing test * unskipping test Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 4b41465 - Browse repository at this point
Copy the full SHA 4b41465View commit details
Commits on Jan 13, 2023
-
restore aliases before annotating (metabase#27637) (metabase#27663)
* restore aliases before annotating * cleanup * fix tests * Don't add escaped->original if aliases have not changed No need to walk and replace the aliases if they are identical. And in that case, no need to keep a mapping of identical to identical. Not super important but saves some time and complexity, and keeps other tests passing since the presence of [:info :alias/escaped->original] in the query caused them to trivially fail. * oracle has a smaller limit and _expected_ mangled previous testing behavior was "what happened" and not what should happen. we fixed the bug but the "expect garbage" behavior was still present * Relax :alias/escaped->original schema oracle tests use keywords for the alias ```clojure {:alias/escaped->original {:test-data-venues--via-a763718f "test_data_venues__via__venue_id", :test-data-users--via--user-id "test_data_users__via__user_id"}}} ``` No idea why that is keyworded * relax `:alias/escaped->original` schema see previous commit
Configuration menu - View commit details
-
Copy full SHA for c9312cb - Browse repository at this point
Copy the full SHA c9312cbView commit details -
Fixed regex for latitude name type matching (metabase#27614) (metabas…
…e#27676) * Fixed regex for latitude name type matching * Grouping regexes by lon/lat Co-authored-by: Mark Bastian <markbastian@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5c00021 - Browse repository at this point
Copy the full SHA 5c00021View commit details
Commits on Jan 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5ee406a - Browse repository at this point
Copy the full SHA 5ee406aView commit details -
Fix navigating from dashboard to card with string filters (metabase#2…
…7687) (metabase#27706) Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 4908a97 - Browse repository at this point
Copy the full SHA 4908a97View commit details -
Notify api key not set hints (metabase#27515) (metabase#27542)
* nit alignment * point to var so changes are picked up need to refresh this ns after changing the middleware since these add a bit more helpful doc strings. But capture previous function value so more annoying at repl * Ensure MB_API_KEY is set for notify endpoint Previously when the MB_API_KEY was unset: ``` ❯ http POST "localhost:3000/api/notify/db/1?scan=schema" HTTP/1.1 403 Forbidden <other headers removed> Forbidden ``` And now: ``` ❯ http POST "localhost:3000/api/notify/db/1?scan=schema" HTTP/1.1 403 Forbidden <other headers removed> MB_API_KEY is not set. See https://www.metabase.com/docs/latest/configuring-metabase/environment-variables#mb_api_key for details ``` An annoying thing in the tests. We set `"-Dmb.api.key=test-api-key"` in the `:test` alias for CI, but not in regular dev mode. So annoyingly we either have tests that would fail in the repl in regular dev, or use `mt/with-temporary-setting-values [api-key "test-api-key"]` when writing tests that only matter for local stuff. c'est la vie * Translate error message Using site locale because this in an `+apikey` context, not an `+auth` context. The importance of that is that there is no logged in user so no way to get a user locale, and it just falls back to the server locale anyways. So lets just use that. * Fix temp settings when they are env-based An annoying bit here. `api-key` setting in the notify test is set in the env in the `:test` alias. ```clojure notify-test=> (mt/with-temporary-setting-values [api-key nil] (mw.auth/api-key)) "test-api-key" ;; where did the nil go? ``` But there are two bugs in `mt/with-temporary-setting-values`: 1. It gets the current env value and then temporarily sets it to the current value. Note that `do-with-temp-env-var-value` is called with `env-var-value` which is the current value in the environment. All of this work for nothing ``` - (if-let [env-var-value (and (not raw-setting?) (#'setting/env-var-value setting-k))] - (do-with-temp-env-var-value setting env-var-value thunk) + (if (and (not raw-setting?) (#'setting/env-var-value setting-k)) + (do-with-temp-env-var-value setting-k value thunk) ``` So cannot possibly do what we want. 2. The second bug is that the pathway through `mt/with-temporary-setting-values` did not convert `:api-key` to `:mb-api-key`. So even if it put our new value in above, it would put `:api-key nil` in the env, but when we look for it it would look for `:mb-api-key` and we would not find it. Thus the use of `setting-env-map-name`. Then clean up the few other places that did it kinda right, but not necessarily. Seems the "correct" way to do this is get the setting name, munge it, prepend with mb. The other call sites were using variants of `(keyword (str "mb-" (name setting-name)))` which is close but could miss the munging. * Safely set env/env keys There are two ways that we put things into the env/env so they appear as environmentally set variables. - explicitly with `mt/with-temp-env-var-value`. This simulates a user setting these values and they are specified in the env way: mb-email-smtp-port, "MB_DISABLE_SCHEDULER", etc. At the call site you are aware that they are env related so get the mb prefix - incidentally with `mt/with-temporary-setting-values`. Settings are always referred to by their "nice" internal name like `api-key`, etc. But if a setting is found to be an env variable, we override it in env/env. But we have to make sure the key is set properly with an mb- prefix. Owing to this, we have to conditionally add the mb- prefix if not already present. * cleanup the constants a bit * Fix some site-url tests The tests themselves are testing useful stuff: site-url doesn't return a broken value if it fails the verification when set as an env variable. But the tests themselves were a bit nonsensical in their setup: ``` @@ -62,21 +62,19 @@ (deftest site-url-settings-normalize (testing "We should normalize `site-url` when set via env var we should still normalize it (metabase#9764)" (mt/with-temp-env-var-value [mb-site-url "localhost:3000/"] - (mt/with-temporary-setting-values [site-url nil] - (is (= "localhost:3000/" - (setting/get-value-of-type :string :site-url))) - (is (= "http://localhost:3000" - (public-settings/site-url))))))) + (is (= "localhost:3000/" + (setting/get-value-of-type :string :site-url))) + (is (= "http://localhost:3000" + (public-settings/site-url)))))) ``` Why would it set an env-variable version [mb-site-url "localhost:3000/"] then try to blank it out with `(mt/with-temporary-setting-values [site-url nil])`. Fixing the bug in how we set env var values made this nonsensical stuff break. Now we just have to do the obvious thing: set the env var to a bad value, assert that (setting/get-value-of-type :string :site-url) is that value, but assert that the _setting_ is a well-formatted value or nil if we can't solve it (the "asd_12w31%$;" case). Setting the env value then setting a temporary value to nil didn't make much sense. And the fix made that set the env var to nil. * fixup last tests * Don't modify things from `with-temp-env-var-value` this allows us to set non-mb-prefixed env vars. not sure if necessary but let's roll with it. * fix last of the tests
Configuration menu - View commit details
-
Copy full SHA for 95cd24b - Browse repository at this point
Copy the full SHA 95cd24bView commit details
Commits on Jan 17, 2023
-
docs - update "can't see tables" troubleshooting (metabase#27712) (me…
…tabase#27715) Add note about MongoDB. Co-authored-by: Natalie <nat@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 750bb46 - Browse repository at this point
Copy the full SHA 750bb46View commit details -
Restore active item colors (metabase#27480) (metabase#27569)
Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 4456b64 - Browse repository at this point
Copy the full SHA 4456b64View commit details -
Only update dashboard cards if their own filter changes (metabase#27490…
…) (metabase#27517) Co-authored-by: Gustavo Saiani <gus@metabase.com>
Configuration menu - View commit details
-
Copy full SHA for 819ce29 - Browse repository at this point
Copy the full SHA 819ce29View commit details
Commits on Jan 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1a59de7 - Browse repository at this point
Copy the full SHA 1a59de7View commit details
Commits on Feb 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 522fe3d - Browse repository at this point
Copy the full SHA 522fe3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cea398 - Browse repository at this point
Copy the full SHA 1cea398View commit details