Skip to content

Upstream PR 2930 Bulk Inline Array

OpenAI Codex edited this page Nov 1, 2026 · 2 revisions

Upstream PR #2930 — Consume INLINE_ARRAY vertex data in bulk

Upstream work · Actionable research · Research and retired work

Current disposition — November 1, 2026

Reviewed: November 1, 2026. Fork source: b7140848 (full SHA b71408480a3a979a9c584663e1d1f400904c8bb7). Latest stable checked: v0.8.136-0-g458730bf5373, September 30, source 458730bf5373f1f0d027450fef7443e3af7a3ae1. GitHub state, branch recommendation, source presence and release availability are separate facts. See current status and release versus main.

Current field November 1, 2026 observation
GitHub source Upstream #2930
GitHub state / draft Open / No
Current head e53fd6f4857d87155b38debc30dc672218c4a680
Originally reviewed head e53fd6f4857d87155b38debc30dc672218c4a680
Last metadata update (UTC) 2026-10-18T20:59:12Z
Head versus original review Same recorded head; metadata/state updates do not indicate a new proposal-code head.
Current action Open proposal; refresh integration and focused tests before handoff.
Fork/release availability This upstream proposal’s GitHub state does not establish full fork/release inclusion. The historical overlap below is scoped to its recorded fork baseline; use the current feature register for delivered fork behavior.

The current head matches the recorded September review head. Later updated_at metadata does not establish changed proposal code. The original fork overlap remains a dated source comparison, not a fresh integration or native qualification result.

This refresh checked GitHub identity/state and the specific source boundaries named above. It did not rerun native games, XISO timings or integration qualification. Historical performance claims remain attached to their original heads.

Historical review — September 21, 2026

The review below is preserved as written, including its original state, head, fork baseline and proposed handoff. Its present-tense statements apply to that dated review; the current disposition above governs today’s action.

← Upstream Work

Field Value
Upstream PR xemu-project/xemu#2930
State at 2026-09-21 audit Open
Reviewed upstream head e53fd6f4857d87155b38debc30dc672218c4a680
Last upstream update seen 2026-09-06
Reviewed upstream base f9b14039e5bb56ae2d8f028e31e7cc19f13f7e12
Fork baseline 82d04d84bdb3de956f20c3537e1da2cece0e8da2
Relationship Bulk path present downstream with stronger packet validation
Related fork work Mainkill1/xemu#10, Mainkill1/xemu#123
Contribution priority Highest
Upstream contact status No comment posted by this audit.

Summary

Upstream removes per-word dispatch for non-incrementing INLINE_ARRAY runs. The fork already has broader bulk handling plus atomic whole-packet validation.

Upstream scope

The reviewed diff bounds copied chunks to remaining capacity. Without a complete preflight, an oversized packet can partially mutate draw state before later processing discovers a full buffer.

Corresponding fork work

Fork #10 rejects oversized inline packets atomically. Fork #123 moves validation before bulk/scalar/traced path selection so disabling bulk handling or enabling trace mode cannot bypass the capacity contract.

Difference that must remain explicit

The fork’s complete dispatch implementation need not be adopted to gain the correctness rule. The transferable unit is whole-packet validation before any mutation.

Transferable regression and review cases

  • Accepted non-incrementing INLINE_ARRAY packets use the bulk path.
  • Incrementing methods retain one-word semantics.
  • Oversized packets are rejected before modifying inline buffers, pending draw state, or method state.
  • Rejection behavior is identical for bulk enabled, scalar fallback, and traced execution.
  • Boundary sizes at exact capacity and capacity plus one word are covered.

Suggested upstream handoff

Recommend keeping upstream batching while adding the fork’s atomic preflight invariant and cross-mode regression cases.

Claims this page does not support

  • It does not prove the upstream branch merges cleanly with current upstream.
  • It does not prove a native correctness or performance result unless a linked exact-head run says so.
  • It does not transfer favorable performance percentages between hardware, renderers, games, or source heads.
  • It does not authorize posting a comment or review upstream.

Before sending anything upstream

  • Refresh the PR state, head SHA, description, changed files, and newest review comments.
  • Recheck the corresponding fork implementation on current main.
  • Run or cite the narrow regression on an exact source state.
  • Verify every public link and remove private paths, captures, game data, credentials, and internal logs.
  • Phrase source concerns as source concerns and reproductions as reproductions.
  • State the uncovered behavior and evidence limit.
  • Add the posted URL and upstream response to this page.

Tracking log

Date Upstream head Action Result
2026-09-21 e53fd6f4857d Fork/upstream source comparison recorded Handoff prepared; nothing posted

References

Clone this wiki locally