Skip to content

Upstream PR 3004 Smaller Buffer Retry

OpenAI Codex edited this page Nov 1, 2026 · 2 revisions

Upstream PR #3004 — Retry a smaller Vulkan buffer after allocation failure

Upstream work · Actionable research · Research and retired work

Current disposition — November 1, 2026

Reviewed: November 1, 2026. Fork source: b7140848 (full SHA b71408480a3a979a9c584663e1d1f400904c8bb7). Latest stable checked: v0.8.136-0-g458730bf5373, September 30, source 458730bf5373f1f0d027450fef7443e3af7a3ae1. GitHub state, branch recommendation, source presence and release availability are separate facts. See current status and release versus main.

Current field November 1, 2026 observation
GitHub source Upstream #3004
GitHub state / draft Open / No
Current head d9dc31924b5524d8f67d88c83fb714ecf16e677e
Originally reviewed head d9dc31924b5524d8f67d88c83fb714ecf16e677e
Last metadata update (UTC) 2026-10-18T20:59:11Z
Head versus original review Same recorded head; metadata/state updates do not indicate a new proposal-code head.
Current action Open proposal; refresh integration and focused tests before handoff.
Fork/release availability This upstream proposal’s GitHub state does not establish full fork/release inclusion. The historical overlap below is scoped to its recorded fork baseline; use the current feature register for delivered fork behavior.

The current head matches the recorded September review head. Later updated_at metadata does not establish changed proposal code. The original fork overlap remains a dated source comparison, not a fresh integration or native qualification result.

This refresh checked GitHub identity/state and the specific source boundaries named above. It did not rerun native games, XISO timings or integration qualification. Historical performance claims remain attached to their original heads.

Historical review — September 21, 2026

The review below is preserved as written, including its original state, head, fork baseline and proposed handoff. Its present-tense statements apply to that dated review; the current disposition above governs today’s action.

← Upstream Work

Field Value
Upstream PR xemu-project/xemu#3004
State at 2026-09-21 audit Open
Reviewed upstream head d9dc31924b5524d8f67d88c83fb714ecf16e677e
Last upstream update seen 2026-09-06
Reviewed upstream base f9b14039e5bb56ae2d8f028e31e7cc19f13f7e12
Fork baseline 82d04d84bdb3de956f20c3537e1da2cece0e8da2
Relationship Complementary allocation fallback
Related fork work Related transient-buffer growth/failure-handling work
Contribution priority Medium
Upstream contact status No comment posted by this audit.

Summary

The PR retries a smaller allocation when the preferred Vulkan buffer cannot be allocated.

Upstream scope

A successful fallback size must become the authoritative capacity everywhere, rather than retaining requested-size assumptions.

Corresponding fork work

Downstream preparation paths emphasize explicit allocation failure and bounded fallback rather than assertion or silent partial setup.

Difference that must remain explicit

Retrying allocation alone is insufficient if descriptors, staging buffers, copy bounds, or reservation counters retain the larger size.

Transferable regression and review cases

  • Force first allocation failure and second success at a smaller size.
  • Propagate actual capacity to staging/device pairing, descriptors, copies, and allocators.
  • All retries fail: initialization returns a controlled error without partial live objects.
  • Renderer recreation does not reuse stale capacity.

Suggested upstream handoff

Offer allocation-failure cleanup patterns and require actual-size propagation checks.

Claims this page does not support

  • It does not prove the upstream branch merges cleanly with current upstream.
  • It does not prove a native correctness or performance result unless a linked exact-head run says so.
  • It does not transfer favorable performance percentages between hardware, renderers, games, or source heads.
  • It does not authorize posting a comment or review upstream.

Before sending anything upstream

  • Refresh the PR state, head SHA, description, changed files, and newest review comments.
  • Recheck the corresponding fork implementation on current main.
  • Run or cite the narrow regression on an exact source state.
  • Verify every public link and remove private paths, captures, game data, credentials, and internal logs.
  • Phrase source concerns as source concerns and reproductions as reproductions.
  • State the uncovered behavior and evidence limit.
  • Add the posted URL and upstream response to this page.

Tracking log

Date Upstream head Action Result
2026-09-21 d9dc31924b55 Fork/upstream source comparison recorded Handoff prepared; nothing posted

References

Clone this wiki locally