Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add dropdown version selection to docsite #55655

Open
wants to merge 3 commits into
base: devel
from

Conversation

3 participants
@samccann
Copy link
Contributor

commented Apr 23, 2019

SUMMARY

Updating PR #53317 to implement some of the suggested fixes.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs.ansible.com

ADDITIONAL INFORMATION

@samccann samccann added this to Needs Triage - todo backlog - Docsite work -anything can go here in Network Documentation via automation Apr 23, 2019

@samccann samccann referenced this pull request Apr 23, 2019

Open

Docs meeting agenda #389

@samccann samccann moved this from Needs Triage - todo backlog - Docsite work -anything can go here to Waiting review/merge in Network Documentation Apr 23, 2019

@samccann samccann changed the title Add dropdown version selection to docsite [WIP] Add dropdown version selection to docsite Apr 23, 2019

@samccann samccann added the WIP label Apr 23, 2019

@samccann samccann force-pushed the samccann:version_pr branch from 84bbb21 to 646acc4 Apr 23, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

@samccann samccann force-pushed the samccann:version_pr branch 3 times, most recently from 0618cb6 to d23b9b4 May 6, 2019

@samccann

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Goal is to get a fix in place for a better 404 page (#51439) before merging this fix, as this version switcher will introduce more 404 page hits as users flip back to a version where the content doesn't exist.

@samccann samccann force-pushed the samccann:version_pr branch 2 times, most recently from bd270e8 to 68a5ffe May 7, 2019

@samccann

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

Some initial review comments from the DaWGs (doc working group meeting):

  • determine why test site shows devel when the url/version is 2.7 - could be how it was published to test
  • remove versions.html as that's an older approach no longer used in this PR
  • ensure that devel has the appropriate versions (2.7, 2.8, devel) and that each backport brings in the appropriat versions, back to 2.6
  • do not merge until a better 404 page is available - see #51439

@maxwell-k maxwell-k referenced this pull request May 14, 2019

Open

Better 404 page for docs.ansible.com/ansible #51439

0 of 3 tasks complete

@samccann samccann force-pushed the samccann:version_pr branch from 6a76a0c to 4848d8a May 21, 2019

docs: Add way to select version for documentation
(created from akasurde pr)

move ansible customization to separate file

@samccann samccann force-pushed the samccann:version_pr branch from 4848d8a to 5c58e23 May 21, 2019

@ansibot ansibot removed the needs_rebase label May 21, 2019

samccann added some commits May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.