Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination for admin api get orgs and fix only list public orgs bug #7742

Merged
merged 2 commits into from Aug 4, 2019

Conversation

@lunny
Copy link
Member

commented Aug 4, 2019

Will also fix #7719

@lunny lunny added this to the 1.10.0 milestone Aug 4, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 4, 2019

Codecov Report

Merging #7742 into master will decrease coverage by 0.01%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7742      +/-   ##
==========================================
- Coverage   41.29%   41.28%   -0.02%     
==========================================
  Files         472      472              
  Lines       63845    63854       +9     
==========================================
- Hits        26365    26362       -3     
- Misses      34044    34055      +11     
- Partials     3436     3437       +1
Impacted Files Coverage Δ
routers/api/v1/admin/org.go 46.66% <0%> (-6.5%) ⬇️
models/user.go 50.68% <100%> (-0.09%) ⬇️
modules/avatar/avatar.go 48% <0%> (-6%) ⬇️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2a39c...33a0cbd. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Aug 4, 2019

@lafriks

lafriks approved these changes Aug 4, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Aug 4, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 4, 2019

@techknowlogick techknowlogick merged commit 5b902e2 into go-gitea:master Aug 4, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/admin_api_orgs branch Aug 5, 2019

lunny added a commit to lunny/gitea that referenced this pull request Aug 5, 2019

techknowlogick added a commit that referenced this pull request Aug 5, 2019

@lunny lunny added the kind/breaking label Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.