Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Commit Status and Message From Overflowing On Branch Page #7800

Merged

Conversation

@gary-kim
Copy link
Member

commented Aug 8, 2019

It is possible for the commit ci status
on the branches page for a repository to
become an ellipsis due to overflowing.

This commit will fix that issue by
using flex.


It was possible that the commit message would
overflow hiding the expand commits button
and commit status. This change ensures that
the correct elements overflow without hiding
anything else.

This change also reverts using flex in the
commits list because it was causing issues
in Blink based browsers.


EDIT: There is also an issue with the expand commit message button overflowing as can be seen in both screenshots that this PR does not fix. I separated that into a different PR because it may require a JS change as well. I'll make the PR after this gets merged. Change has been made in this PR with just template changes.

EDIT2: Give me a bit. It seems like Blink based browsers have their own unique issues. Issues with Blink have been fixed.

Before

Screenshot from 2019-08-09 18-57-23

After

Screenshot from 2019-08-09 18-59-02

Prevent Commit Status From Overflowing On Branch Page
It is possible for the commit ci status
on the branches page for a repository to
become an ellipsis due to overflowing.

This commit will fix that issue by
using flex.

Signed-off-by: Gary Kim <gary@garykim.dev>

@lafriks lafriks added the kind/ui label Aug 8, 2019

@lafriks lafriks added this to the 1.10.0 milestone Aug 8, 2019

@lunny lunny added the backport/v1.9 label Aug 9, 2019

Fix multiple overflowing issues in commits table
It was possible that the commit message would
overflow hiding the expand commits button
and commit status. This change ensures that
the correct elements overflow without hiding
anything else.

This change also reverts using flex in the
commits list because it was causing issues
in Blink based browsers.

Signed-off-by: Gary Kim <gary@garykim.dev>

@gary-kim gary-kim force-pushed the gary-kim:fix/noid/commits-view-status-overflow branch from 5ed4e7b to bcda068 Aug 9, 2019

@lafriks
lafriks approved these changes Aug 9, 2019

@GiteaBot GiteaBot added the lgtm/need 1 label Aug 9, 2019

@gary-kim gary-kim changed the title Prevent Commit Status From Overflowing On Branch Page Prevent Commit Status and Message From Overflowing On Branch Page Aug 9, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 9, 2019

Codecov Report

Merging #7800 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7800      +/-   ##
==========================================
+ Coverage    41.4%   41.41%   +0.01%     
==========================================
  Files         474      474              
  Lines       63860    63860              
==========================================
+ Hits        26439    26448       +9     
+ Misses      33978    33969       -9     
  Partials     3443     3443
Impacted Files Coverage Δ
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
routers/repo/view.go 43.25% <0%> (+1.01%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6f452...fb5d58c. Read the comment docs.

@sapk
sapk approved these changes Aug 9, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 9, 2019

@lunny lunny merged commit 2ed21e7 into go-gitea:master Aug 9, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
gary-kim added a commit to gary-kim/gitea that referenced this pull request Aug 9, 2019
lafriks added a commit that referenced this pull request Aug 9, 2019
Prevent Commit Status and Message From Overflowing On Branch Page (#7800
) (#7808)

Signed-off-by: Gary Kim <gary@garykim.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.