Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move status table to cron package #7370

Merged
merged 7 commits into from Jul 16, 2019

Conversation

5 participants
@lunny
Copy link
Member

commented Jul 7, 2019

As title.

@lunny lunny added the kind/refactor label Jul 7, 2019

@lunny lunny added this to the 1.10.0 milestone Jul 7, 2019

@GiteaBot GiteaBot added the lgtm/need 2 label Jul 7, 2019

@lunny lunny force-pushed the lunny:lunny/move_cron branch from 8704a94 to 1fa10db Jul 7, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 7, 2019

Codecov Report

Merging #7370 into master will decrease coverage by <.01%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7370      +/-   ##
=========================================
- Coverage    41.2%   41.2%   -0.01%     
=========================================
  Files         469     469              
  Lines       63556   63533      -23     
=========================================
- Hits        26190   26178      -12     
+ Misses      33947   33937      -10     
+ Partials     3419    3418       -1
Impacted Files Coverage Δ
models/user.go 50.5% <ø> (+0.04%) ⬆️
models/branches.go 50.16% <ø> (+0.16%) ⬆️
models/repo.go 48.78% <ø> (+0.18%) ⬆️
models/repo_mirror.go 23.32% <ø> (+0.4%) ⬆️
modules/cron/cron.go 49.33% <68.42%> (+0.8%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/gpg_key.go 55.83% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760c473...6bacba5. Read the comment docs.

@lunny lunny force-pushed the lunny:lunny/move_cron branch 2 times, most recently from 40201e7 to 8942274 Jul 7, 2019

@lunny

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

@lunny

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

based on #7394

@lunny lunny force-pushed the lunny:lunny/move_cron branch from 8942274 to 339f11d Jul 9, 2019

lunny added some commits Jul 7, 2019

@lunny lunny force-pushed the lunny:lunny/move_cron branch from 339f11d to e90e734 Jul 9, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jul 15, 2019

@richmahn
Copy link
Contributor

left a comment

LGTM

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jul 15, 2019

@techknowlogick techknowlogick merged commit d2958d9 into go-gitea:master Jul 16, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/move_cron branch Jul 16, 2019

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.