Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column name ambiguity in GetUserIssueStats() #8347

Merged
merged 22 commits into from Oct 3, 2019

Conversation

@guillep2k
Copy link
Member

commented Oct 2, 2019

In theory, fixes #8231 (can't reproduce)

Added a test for TestGetUserIssueStats(), but currently unit tests only run for SQLite, where this issue doesn't seem to trigger.

@codecov-io

This comment has been minimized.

Copy link

commented Oct 2, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@0d93430). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8347   +/-   ##
=========================================
  Coverage          ?   41.77%           
=========================================
  Files             ?      496           
  Lines             ?    65585           
  Branches          ?        0           
=========================================
  Hits              ?    27399           
  Misses            ?    34671           
  Partials          ?     3515
Impacted Files Coverage Δ
models/issue.go 50.94% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d93430...6d22f54. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Oct 2, 2019
@lunny
lunny approved these changes Oct 2, 2019
@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Oct 2, 2019
@lunny lunny added the kind/bug label Oct 2, 2019
@lunny lunny added this to the 1.10.0 milestone Oct 2, 2019
lunny and others added 3 commits Oct 2, 2019
@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Oct 2, 2019
@lunny

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

make L-G-T-M work

@lunny lunny merged commit 740a0c4 into go-gitea:master Oct 3, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@guillep2k guillep2k deleted the guillep2k:fix-8231 branch Oct 3, 2019
@lunny lunny added the backport/v1.9 label Oct 5, 2019
@lunny

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Please send back port to v1.9

@jaqra

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

@lunny that feature (#8201) added in is 1.10. cant backport

@lunny

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

@jaqra Oh. right #7750 should not be related.

@lunny lunny removed the backport/v1.9 label Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.