Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve branches list performance and fix protected branch icon when no-login #7695

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@lunny
Copy link
Member

commented Aug 1, 2019

will fix #7576, The bug is when invoke Repository.IsProtectedBranch(branchName, ctx.User) and user is nil, it will always return true.

@lunny lunny added the kind/bug label Aug 1, 2019

@lunny lunny added this to the 1.10.0 milestone Aug 1, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 1, 2019

Codecov Report

Merging #7695 into master will decrease coverage by 0.01%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7695      +/-   ##
==========================================
- Coverage   41.25%   41.23%   -0.02%     
==========================================
  Files         471      471              
  Lines       63754    63759       +5     
==========================================
- Hits        26299    26291       -8     
- Misses      34022    34034      +12     
- Partials     3433     3434       +1
Impacted Files Coverage Δ
routers/repo/branch.go 55.6% <20%> (-0.9%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
routers/repo/view.go 42.23% <0%> (-1.02%) ⬇️
models/branches.go 49.15% <0%> (-1.02%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b7a4f...b8950c3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 label Aug 1, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Aug 1, 2019

@Bwko
Bwko approved these changes Aug 1, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 1, 2019

@techknowlogick techknowlogick merged commit 02999c9 into go-gitea:master Aug 1, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/branches_improve branch Aug 1, 2019

@lunny lunny added the backport/v1.9 label Aug 1, 2019

lunny added a commit to lunny/gitea that referenced this pull request Aug 1, 2019
techknowlogick added a commit that referenced this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
You can’t perform that action at this time.