Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong sender when send slack webhook #7918

Merged
merged 2 commits into from Aug 20, 2019

Conversation

@lunny
Copy link
Member

commented Aug 20, 2019

Fix #7265

@lunny lunny added this to the 1.10.0 milestone Aug 20, 2019

@sapk
sapk approved these changes Aug 20, 2019
@sapk

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

CI fail seems unrelated but maybe you can restart it.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 20, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@8c10d91). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7918   +/-   ##
=========================================
  Coverage          ?   41.46%           
=========================================
  Files             ?      478           
  Lines             ?    63943           
  Branches          ?        0           
=========================================
  Hits              ?    26512           
  Misses            ?    33981           
  Partials          ?     3450
Impacted Files Coverage Δ
models/release.go 52.94% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c10d91...c3a44e2. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Aug 20, 2019

@sapk sapk merged commit 9b9d162 into go-gitea:master Aug 20, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@sapk

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

First PR merged by me 🎉
Please send backport.

@lunny lunny deleted the lunny:lunny/fix_slack_username branch Aug 20, 2019

lunny added a commit to lunny/gitea that referenced this pull request Aug 20, 2019

@lunny lunny added the backport/done label Aug 20, 2019

techknowlogick added a commit that referenced this pull request Aug 20, 2019
aswild added a commit to aswild/gitea that referenced this pull request Aug 25, 2019
Merge tag 'v1.9.2' into wild/v1.9
* BUGFIXES
  * Fix wrong sender when send slack webhook (go-gitea#7918) (go-gitea#7924)
  * Upload support text/plain; charset=utf8 (go-gitea#7899)
  * Lfs/lock: round locked_at timestamp to second (go-gitea#7872) (go-gitea#7875)
  * Fix non existent milestone with 500 error (go-gitea#7867) (go-gitea#7873)
* SECURITY
  * Fix No PGP signature on 1.9.1 tag (go-gitea#7874)
  * Release built with go 1.12.9 to fix security fixes in golang std lib, ref: https://groups.google.com/forum/#!msg/golang-announce/oeMaeUnkvVE/a49yvTLqAAAJ
* ENHANCEMENT
  * Fix pull creation with empty changes (go-gitea#7920) (go-gitea#7926)
* BUILD
  * Drone/docker: prepare multi-arch release + provide arm64 image (go-gitea#7571) (go-gitea#7884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.