Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singular form for files that has only one line #8416

Merged

Conversation

@lafriks
Copy link
Member

commented Oct 7, 2019

Fixes line count display for files with single line

@lafriks lafriks added this to the 1.10.0 milestone Oct 7, 2019
@GiteaBot GiteaBot added the lgtm/need 1 label Oct 7, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Oct 7, 2019

Codecov Report

Merging #8416 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8416      +/-   ##
==========================================
- Coverage    41.8%   41.79%   -0.01%     
==========================================
  Files         497      497              
  Lines       65611    65611              
==========================================
- Hits        27429    27424       -5     
- Misses      34666    34673       +7     
+ Partials     3516     3514       -2
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
routers/repo/view.go 42.31% <0%> (-1.01%) ⬇️
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662a40e...c5cb91c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Oct 7, 2019
@techknowlogick techknowlogick merged commit 28d5347 into go-gitea:master Oct 7, 2019
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lafriks lafriks deleted the lafriks-fork:fix/line_count_singular branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.