Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix dropTableColumns sqlite implementation #7710
@@ Coverage Diff @@ ## master #7710 +/- ## ========================================== + Coverage 41.27% 41.31% +0.03% ========================================== Files 473 473 Lines 63885 63828 -57 ========================================== + Hits 26371 26372 +1 + Misses 34076 34019 -57 + Partials 3438 3437 -1
Writing a test for this apart from adding a migration that would trigger it is not possible.
We cannot run this as a unit test because we need the various dbs, so we have to run it as an integration test.
Now integration tests are run separately from the unit tests. However, neither models.x nor migrations.dropTableColumns are exported to the integrations tests and cannot be simply testshim exported as the integrations test don't run in the same testing context and therefore these shims are not available.