Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2 with remote Gitea #8149

Merged
merged 5 commits into from Sep 13, 2019

Conversation

@techknowlogick
Copy link
Member

commented Sep 11, 2019

Fix #8093

@techknowlogick techknowlogick added this to the 1.10.0 milestone Sep 11, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

I'm using go1.13 so my vendor file is different. This is blocked by #8088

@codecov-io

This comment has been minimized.

Copy link

commented Sep 12, 2019

Codecov Report

Merging #8149 into master will decrease coverage by <.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8149      +/-   ##
==========================================
- Coverage   41.85%   41.84%   -0.01%     
==========================================
  Files         482      482              
  Lines       64592    64613      +21     
==========================================
+ Hits        27032    27039       +7     
- Misses      34090    34106      +16     
+ Partials     3470     3468       -2
Impacted Files Coverage Δ
models/oauth2.go 34.04% <ø> (ø) ⬆️
modules/auth/oauth2/oauth2.go 23.56% <28.57%> (+0.77%) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/sync/unique_queue.go 89.28% <0%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff0787...d67bb7d. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Sep 12, 2019

@lunny
lunny approved these changes Sep 13, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Sep 13, 2019

@techknowlogick techknowlogick merged commit 2837563 into go-gitea:master Sep 13, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@techknowlogick techknowlogick deleted the techknowlogick:gitea-oauth branch Sep 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.