-
Notifications
You must be signed in to change notification settings - Fork 0
Review 4072
#4072 · AKnassa · aged-PR cleanup Step 3, batch 3, 2026-08-23
Verdict: changes requested
Six of seven components render an empty docsite playground; no repo-wide guard keeps playground defaults honest.
Playground defaults for 7 components plus their item sub-docs, and a scanner test checking every default against documented props and resolving every __element name.
no API change (docs + one test)
no new theme targets
API no · Visual no (docsite playground previews only) · Theme no
Refreshed the branch myself: merged origin/main (three conflicts, all mechanical — took main's DropdownMenu and DropdownMenuItem playgrounds, kept main's reflowed CheckboxListItem description plus this branch's playground block) and dropped the duplicate Slider.width the merge created. Pushed c5a16509f96. Then ran the scanner: 5 pass, 1 fails on DropdownMenu.children.
request changes. [BLOCKS] the new rule goes red on today's main. #4954 (2026-08-13) retyped DropdownMenu.children from (item) => ReactNode to plain ReactNode and made it mutually exclusive with items, so a playground can seed one or the other and main's seeds items. R14b: a rule whose only hit is a false positive is worse than nothing. NOT the author's debt (R13) — at their own head children was a render function and the rule correctly skipped it, so their 6/6 test plan was honest.
Two hunks are now redundant: DropdownMenu's playground and Slider's English width both landed separately. The zh/dense width entries this branch adds are still new.
See the review on #4072. Attribution: [Reviewed by Robohands].
(posted directly by the loop under the aged-PR brief; nothing edited)