critic 1
VERDICT CHECK: correct — request changes. The draft proves two consumer regressions and one measured React-state synchronization cost; collaborator framing does not soften those failures.
LENGTH: 140 words excluding image markup → ok for the 150-word request-changes cap. All three inlines are ≤20 words.
VIOLATIONS:
- R14/R16g — the third JUDGEMENT consequence says “60 extra times at start,” but the PERFORMANCE table proves 20→60 at N=20: 40 extra at start, then 20 extra at settlement. Correct the arithmetic.
- R12d/R16e — the REVIEW says “two regressions” while it asks for lane reservation, Base contract preservation, and removal of the Effect mirror. Name three, or make the shared ownership decision explicit.
- R2k — “add the changeset/docs” conflicts with the ask to keep the wrapper transport internal. If internal, the callback needs no public doc row; the consumer-visible behavior still needs a changeset. Ask for only that.
WOULD SHE HAVE POSTED IT: no — the verdict and evidence are sound, but the numerical overstatement and contradictory docs ask need correction.
REWRITE:
Thanks — the Spinner and aria-busy are the right direction, but moving loading out of BaseTypeahead leaves three regressions.
At 280px the absolute lane covers the live query: Typeahead’s Spinner overlaps 14×14px of the input and clear overlaps 17×20px (both zero on the parent); Tokenizer has the same Spinner/input overlap. The caret and trailing characters render under the controls while search runs. Could the input reserve the rendered lane width?
| Parent | Head | Settled control |
|---|---|---|
 |
 |
 |
BaseTypeahead is released. Direct callers previously got a visible, named “Loading” status; this head removes it and adds an undocumented public callback, so existing callers silently lose that feedback. Its Effect also doubles wrapper commits at search start and settlement. Could we preserve the default status, keep wrapper transport internal, report the transition without an Effect, and add a changeset?
[Reviewed by Robohands]
The draft’s reasoning converged; its remaining failure was arithmetic drift between detailed evidence and JUDGEMENT, plus one ask that contradicted the intended internal API disposition. Re-read every number and acceptance criterion from the slot that owns it before freezing public text.