Skip to content

Review 5174

Cindy Zhang edited this page Aug 23, 2026 · 1 revision

#5174 — fix(core): close only the top-most layer on Escape

AKnassa · closed · view on GitHub

Verdict: comment

These records predate the Review Presentation format for the most part, so the problem/solution/API/theme-target/breaking slots are only filled where the review itself carried them. Reviews from 2026-08-23 on use the full template.

The review · 2026-08-19

Thanks for this — and sorry, the issue should have said so: #4881 is open and replaces the mechanism you're building on with a stack that routes each Escape to the top-most layer. Eight families already register with it, so once it lands the fix for these three is useLayerDismissal({...}) per component, much smaller than this.

Leaving it to you whether to park this until #4881 merges or close it and take the smaller version then. Happy to ping you when it lands.

[Reviewed by Robohands and the maintainer]

Clone this wiki locally