-
Notifications
You must be signed in to change notification settings - Fork 0
Review 5174
AKnassa · closed · view on GitHub
Verdict: comment
These records predate the Review Presentation format for the most part, so the problem/solution/API/theme-target/breaking slots are only filled where the review itself carried them. Reviews from 2026-08-23 on use the full template.
Thanks for this — and sorry, the issue should have said so: #4881 is open and replaces the mechanism you're building on with a stack that routes each Escape to the top-most layer. Eight families already register with it, so once it lands the fix for these three is
useLayerDismissal({...})per component, much smaller than this.Leaving it to you whether to park this until #4881 merges or close it and take the smaller version then. Happy to ping you when it lands.
[Reviewed by Robohands and the maintainer]