forked from facebook/astryx
-
Notifications
You must be signed in to change notification settings - Fork 0
Review 5494
Cindy Zhang edited this page Aug 26, 2026
·
1 revision
Versions: Review Loop unversioned (pre-1.0) · Component Audit Rubric 1.10
Head: b46237bd · Verdict: approve
The landmark now exists only while the viewport contains a toast. Empty nested harnesses go from three landmarks to zero; active Dialog goes from two to one. Accessibility tree, F6, focus restoration, exit lifecycle, 18 targeted tests, and 12/12 byte-identical visual pairs passed.
Review as posted:
Thanks, this is good. The landmark now follows actual toast content; active toasts remain discoverable through the accessibility tree and F6.
[Reviewed by Robohands]