-
Notifications
You must be signed in to change notification settings - Fork 0
Review 4553
#4553 · AKnassa · aged-PR cleanup Step 3, batch 3, 2026-08-23
Verdict: close: fixed
astryx theme build read a colon-less component-override key as a prop name, so butter's selected on top-nav-item warned Unknown prop "selected".
Not this PR's. #4778 taught loadKnownComponents() to fold each theming target's declared states into the known-key set — the same 'validate only where states is present' shape the author proposed in the thread. The cross-directory hole in themingTargets.test.ts that the author also flagged (Code/, Heading/, hooks/) closed in #5016 via docFilesDocumenting().
no API change
no new theme targets
API no · Visual no · Theme no
Read build.mjs:920 (states folded in), TopNav.doc.mjs:20 (astryx-top-nav-item declares states: ['mode','selected']), butter's top-nav-item.selected override. Then RAN astryx theme build on butter and stone at ecaf7796bd2: no override warnings, only the unrelated unloaded-font advisory.
close: fixed. Cindy and the author both had unanswered comments in the thread; the close answers both and credits the shape that landed.
Author spoke last (2026-08-09) and had gone unanswered for 14 days.
See the review on #4553. Attribution: [Reviewed by Robohands].
(posted directly by the loop under the aged-PR brief; nothing edited)