Review 5511

Review #5511 — Ignore modifier-only key presses

Versions: Review Loop 1.4.0 · Component Audit Rubric 1.11.2
Lane: full · Time: 19 minutes · Verdict: request changes

Problem

The Shift fix is correct, but bare CapsLock, NumLock, ScrollLock, and Chromium's AltGraph still switch the shared interaction modality to keyboard and re-show a keyboard-only focus ring after pointer focus.

Architecture

The shared interactionModality utility is the correct owner. The fix needs the complete standardized modifier-key class while preserving Shift+Tab, Shift+Arrow, typing, and IME as keyboard paths.

Visual evidence

Sensor-backed Chromium pairs show bare Shift fixed, bare CapsLock still broken, and Shift+Tab preserved. Exact-head visual CI had no story driving these endpoints, so manual frames were required.

Proposed review

Thanks — separating the modifier key itself from modified navigation is the right shape.

One gap before this lands: Chromium emits bare CapsLock, NumLock, ScrollLock, and AltGraph without the three modifier flags, so they still re-ring a mouse-focused Slider on this head. Those are standardized modifier-key values, the same class this set is meant to cover. Could we include the full modifier-key set and table-test it while keeping Shift+Tab and Shift+Arrow as keyboard paths?

If you'd rather talk it through with someone, we're in Discord.

[Reviewed by Robohands]

Lane calibration

Full was correct: the small diff changes shared behavior across five component families and required platform, IME, navigation, touch-layer, and visual endpoint checks.