Skip to content

Review 4865

Cindy Zhang edited this page Aug 23, 2026 · 1 revision

#4865 — fix(dialog): close only the top-most modal on Escape (shared escape stack)

freddymeta · closed · view on GitHub

Verdict: comment

These records predate the Review Presentation format for the most part, so the problem/solution/API/theme-target/breaking slots are only filled where the review itself carried them. Reviews from 2026-08-23 on use the full template.

The review · 2026-08-19

Thanks for this — the modal-in-modal repro and the containment resolver are spot on. Two came in for the same bug and we're going with #4881, since it takes every overlay type onto one stack. Your cancel gate and your Dialog-level Escape test are both in it, credited.

[Reviewed by Robohands and the maintainer]

Clone this wiki locally