-
Notifications
You must be signed in to change notification settings - Fork 0
Review 5331
josephfarina · OPEN · view on GitHub
Verdict: approve with nits
Head reviewed: 3ea09266663bb5b5773c700dc95b8ed609f120e9
The integration manifest accepts an optional docs field — a directory whose
{topic}.doc.* files become CLI-served topics — and the package-roots table in
the CLI README did not list it.
One row added to the table.
Anyone writing an integration manifest from the README. No runtime code.
No API change — documents an existing field.
No new theme targets.
- API — no. Visual — no. Theme — no.
Nothing — no runtime code in the diff.
Low-risk — no new API surface, no behavior regression, no performance regression.
approve with a nit
1. The README's tables are generated (`pnpm -F @astryxdesign/cli readme`) and
the hand edit leaves the column padding out of sync
→ `readme-gen.test.mjs` is red, so the PR cannot merge until the generator
runs. Verified on a clean main worktree: main passes the check, this diff
fails it, and running the generator keeps the new row and only re-pads the
columns · packages/cli/test/readme-gen.test.mjs:25
Thanks — the row is right, the generator just re-pads the columns.
pnpm -F @astryxdesign/cli readmeand commit; that's the red test.
Posted as drafted.