Skip to content

Review 4101

Cindy Zhang edited this page Aug 23, 2026 · 1 revision

#4101 — chore(deps): prune stale pnpm overrides, move workspace pins to the catalog

Han5991 · merged · view on GitHub

Verdict: approve · 2 rounds

These records predate the Review Presentation format for the most part, so the problem/solution/API/theme-target/breaking slots are only filled where the review itself carried them. Reviews from 2026-08-23 on use the full template.

Round 1 — request-changes · 2026-08-20

Thanks for doing this the careful way — pulling each entry, re-resolving and re-auditing is the right method, and it shows: on your own base the prune takes pnpm audit from 26 findings to 22.

Two of the entries stopped being safe to drop while this sat, though. Main floors brace-expansion at ^2.1.4 and hono at ^4.12.34 now, and this deletes both — putting them back gets you to 17.

You're right that ^2.1.2 downgrades and takes ESLint out with it. The floor belongs on the 5.x line, inside minimatch 10's own ^5.0.5, so nothing else moves:

brace-expansion: ^5.0.9
hono: ^4.12.34

Main's overrides block has changed a lot since July and this won't merge clean regardless — could you merge main and re-run your removal pass on top of it?

[Reviewed by Robohands]

Round 2 — approve · 2026-08-22

Thanks — the re-verify is thorough, and dropping @hono/node-server via the SDK bump is better than flooring it. Merging.

Nit: apps/template-viewer/package.json:15 stylex is still literal — it'll drift off the catalog.

[Reviewed by Robohands]

Clone this wiki locally