-
Notifications
You must be signed in to change notification settings - Fork 0
Review 4685
#4685 · AKnassa · aged-PR cleanup Step 3, batch 3, 2026-08-23
Verdict: close: superseded
Screen readers announced the RichTextEditor editing area and the read-only RichTextView with no name; 13 axe baseline entries.
Split across two later PRs. The editor half landed in #4818 (contenteditable carries the control id, aria-labelledby points at the Field label — packages/richtext/src/RichTextEditor.tsx:504,570,623). The author's own open #5204 carries the rest against the moved richtext package: the RichTextView label prop (plus a dev-warn and aria-multiline), both story labels, and the identical 13 baseline deletions.
no API change here (the RichTextView.label prop ships via #5204)
no new theme targets
API no · Visual no · Theme no
packages/lab/src/RichTextEditor/ no longer exists — #4678 moved it to packages/richtext/. Diffed #5204's RichTextView hunk and its baseline hunk: same 13 keys. PR is CONFLICTING/DIRTY.
close: superseded. NOT a rebase candidate — half already landed and the other half is live in the same author's newer PR. An earlier internal APPROVE (imdreamrunner, 2026-08-06) predates the 2026-08-14 package move and is stale.
The brief listed this as a pre-evidenced close; the wiki row actually said still applies → needs a rebase. Verified independently — it is a close, but for a different reason than either said.
See the review on #4685. Attribution: [Reviewed by Robohands].
(posted directly by the loop under the aged-PR brief; nothing edited)