-
Notifications
You must be signed in to change notification settings - Fork 0
Review 4316
#4316 · HelloOjasMutreja · aged-PR cleanup Step 3, batch 3, 2026-08-23
Verdict: approve — awaiting merge
20 props existed in src and were undocumented across MultiSelector, Tokenizer, PowerSearch, Typeahead, Layout, DropdownMenu, HoverCard, Tooltip, Link, Lightbox.
Documents them, retypes Layout.contentWidth to SizeValue, adds a contract test.
no API change (docs only)
no new theme targets
API no · Visual no · Theme no
Every one of the 20 checked against its source declaration; unions and defaults all correct (LayerPlacement = above|below|start|end with placement = 'below'; TextSize/TextWeight/BuiltinTextColor/TextDisplay enumerations exact; Lightbox defaults 0/false; TokenizerOverflowBehavior exact). One real regression: the SizeValue swap also deleted 'Numbers are treated as pixels, strings are used as-is' — the house convention keeps that sentence in the description (Button.doc.mjs:118, Card.doc.mjs:35).
approve. Fixed the one regression myself rather than spending a contributor round trip on a sentence — pushed f9fe0724 restoring it to their branch (maintainer edits were enabled), then approved at that head.
PR body claims to add Layout padding/defaultHasDividers; main already documents both. Harmless staleness in the description.
See the review on #4316. Attribution: [Reviewed by Robohands].
(posted directly by the loop under the aged-PR brief; nothing edited)