Skip to content

Review 5265

Jump to bottom
Cindy Zhang edited this page Aug 24, 2026 · 1 revision

#5265 — docs(core): correct the v0.4.5 StatusDot changelog entry

bhamodi (contributor, fork) · OPEN · view on GitHub

Verdict: approve (merge)

Head reviewed: b17a4dc8b96f38b73ba24ad73575ecce23844849

Problem

The shipped v0.4.5 notes describe a StatusDot that does not exist: built-in per-variant glyphs, statusdot:<variant> registry keys, and an astryx-statusdot-glyph class. Sharper: they claim status "no longer relies on colour alone (WCAG 2.1 SC 1.4.1)" when v0.4.5 deliberately keeps the dot colour-only and makes accessibility the builder's job — so someone trusting the changelog ships an inaccessible status believing the library handled it.

Solution

Rewrite the bullet to what #4373 actually merged: the icon escape hatch, the per-variant --color-on-* inks, and the design-review decision that the dot stays a plain coloured signal.

Impact

Anyone reading packages/core/CHANGELOG.md for v0.4.5 and the doc-site changelog rendered from it. Nothing at runtime. The npm tarball keeps the old text (immutable), and so does the GitHub Release body.

API

No API change.

Theme targets

No new theme targets. It withdraws a documented one (astryx-statusdot-glyph) that never shipped — verified: git grep at v0.4.5 returns nothing, so no theme can be resolving it.

Breaking

  • API — no, markdown only. Visual — no. Theme — no.

Performance & resources

Nothing — one markdown line.

Risk class

Low-risk — no API surface, no behavior change, no perf change.

Judgement

approve — merge. Verified archaeologically at the tag: commit 0f4d45f88dc's message matches the corrected text almost sentence for sentence, and v0.4.5:StatusDot.tsx has icon?: ReactNode with no glyph rendering and no registry lookup.

1. [not blocking] "Each variant now pairs its plate with a dedicated ink" is true
   of four variants, not five
   → a theme author goes looking for `--color-on-neutral` and finds none; neutral
     takes `--color-background-surface`                · CHANGELOG.md:23

2. [not blocking, NOT theirs] the GitHub Release body for v0.4.5 carries the same
   stale paragraph
   → a reader on the release page still gets the glyph story. A contributor
     cannot edit a release; ours, same one-paragraph swap

The review, as posted

Thanks for chasing this down — the stale changeset body is exactly what happened, and the corrected text matches what #4373 shipped. Merging; one optional nit inline.

  • packages/core/CHANGELOG.md:23 — Neutral's ink is --color-background-surface, not a --color-on-* — "each variant" overstates it.

What changed before posting

Posted as drafted.

Clone this wiki locally