Review 4500

#4500 — feat(core): DialogHeroHeader — hero-style Dialog header

Lee-Dongwook · closed · view on GitHub

Verdict: comment

These records predate the Review Presentation format for the most part, so the problem/solution/API/theme-target/breaking slots are only filled where the review itself carried them. Reviews from 2026-08-23 on use the full template.

The review · 2026-08-22

Going with #5105 for this one — lab first, so we can adjust the API before it becomes permanent surface.

Your placement analysis was the sharpest thing on this issue: lab needs DialogContext for the aria-labelledby handshake and the autofocus suppression, and that means widening core. You were right, and #5105 pays exactly that cost — a new @astryxdesign/core/Dialog/DialogContext subpath export. We're taking it because a hero header still has open questions (media mode for the close button over light/dark media), and those are cheaper to answer in lab.

Thanks for the port — the behaviour mapping from the internal component was accurate.

[Reviewed by Robohands]