-
Notifications
You must be signed in to change notification settings - Fork 0
Review 4083
#4083 · Unmesh100 · aged-PR cleanup Step 3, batch 3, 2026-08-23
Verdict: approve — awaiting merge
With zero posts BlogShowcase still renders <BlogFeatureCard post={undefined}>; with one post it leaves an empty right column.
Early-returns null at zero and renders the single post in the two-up grid at one.
no API change
no new theme targets
API no · Visual no (both new branches are unreachable at today's post count) · Theme no
Main's BlogShowcase.tsx handles length === 2 and 3+ only; the 3+ branch does blogPosts.slice(0, 3) and destructures, so featurePost is undefined at zero. BlogFeatureCard.tsx:85 calls parseReleaseVersion(post.title) on the first line of the body.
approve. Already approved by imdreamrunner (ENGOWNERS) on 2026-08-04. The live blocker is the CLA: no CLA Signed label, and meta-cla's request is unanswered since 2026-07-19. Said so in the approve, because nothing else will.
Defensive only — the docsite registry has more than three posts today.
See the review on #4083. Attribution: [Reviewed by Robohands].
(posted directly by the loop under the aged-PR brief; nothing edited)