-
Notifications
You must be signed in to change notification settings - Fork 0
Review 4319
#4319 · HelloOjasMutreja · aged-PR cleanup Step 3, batch 3, 2026-08-23
Verdict: changes requested
Drift between src and docs for Citation and Markdown, per #4163.
Adds title/url/icon to Citation's documented props, components to Markdown's, plus a contract test.
no API change (docs only)
no new theme targets
API no · Visual no · Theme no
CitationProps is {ref, source, number, variant} (Citation.tsx:61-66); title/url/icon are fields of CitationSource, and icon is ReactNode, not string. Markdown's components?: Partial<MarkdownComponents> is real (Markdown.tsx:183) and MarkdownComponents is exported from the core barrel. Checked the zh omission and did NOT raise it — component-loader treats translations as an overlay with per-prop English fallback (componentDocOverlay.test.mjs).
request changes. [BLOCKS] three documented props that do not exist, pinned by a new test → a builder writes <Citation title=… url=… /> and nothing renders. Also answered the author's 22-day-old question: pr-a11y succeeded on 4fba5d4 (run 30893800834, job completed 2026-08-04T20:50:25Z), so there is nothing to baseline.
Author spoke last on 2026-08-01 asking a direct question; unanswered until now.
See the review on #4319. Attribution: [Reviewed by Robohands].
(posted directly by the loop under the aged-PR brief; nothing edited)