Skip to content

Roadmap Meeting Special Topic Nov 6 2015

Don Moses edited this page Nov 6, 2015 · 11 revisions
  • Chair: Mark Jordan

  • Notetaker: Donald Moses

  • Attending: Melissa Anez, Mark Jordan (Chair), Will Panting, Rosie Le Faive, Jenn E., Gabriela M, Nick Ruest, Carell

  • Apologies: Cabel Dervin

Topic: Internal Merges

The proposal is: Anything that is merged, can only be merged by committers, and that committers at the same organization or institution cannot merge their colleagues code. They can review the code, they can provide feedback, but they can't merge code that is coming out of the same organization or institution.

  • Concern with conflict of interest.
  • Community review should be clear and transparent review

Committer composition

  • 18 Committers. 9 from dgi, 2 from UPEI, all others from different institutions

Will

  • concerned about the proposal itself.
    • will create a second class of committers ... they will have less rights.
  • An abnormal approach. Proposal is non-standard.
  • The code is openly posted and is open to feedback. DGI is part of the community.
  • Concerned that there will be less rights.
  • Wants to provide more information to the community.
  • Documentation is for the committers ... should written for all contributions and not targeted at Organizations.
  • practical concerns include:
    • timelines - can be solved with discussion and follow through
    • merging code that doesn't meet the standards should be addressed with the committer/coder
  • The tools already facilitate the practice.

Nick

  • Contributions from community are stopped ... no conversation.
  • Pull requests are merged without discussion.
  • Concerned with the impact on the community.

Melissa

  • While this does have a disproportionate effect on dgi in the short term, we need to look at this as a general policy - and look ahead to other potential committers.
  • DGI has put out some great work and have share well (eg. recent templates)

Gabriela

  • was a DSpace community member for a while
  • Doesn't remember having to put the check in place.
  • Is for a transparent process.

Rosie

  • shouldn't be able to push their own code ...

Carell

  • wondering about probation/term period to trial to see if process/communication improves.

⚠️ This wiki is an archive for past meeting notes. For current minutes as well as onboarding materials, click here.

Clone this wiki locally