Skip to content

Issue 356 Assets People All Companies

Ed Mozley edited this page Nov 15, 2026 · 1 revision

🏒 #356 Assets -> People showed only the last company picked under All companies

GitHub #356, reported by pappas81 Β· Assets Β· since multi-company Assets, fixed in 5.4.0 (#2953)

What you saw

Under All companies, Tickets -> Users listed 7 people and Assets -> People listed 4. Opening one of the missing three from People still worked, but they were not in the Assets list.

What was wrong

Two functions decide which companies a list shows:

Function Under All companies
activeTenantFilter() Always one company - the last one picked
activeTenantReadFilter() Every company you can reach

Tickets -> Users moved to the second in 2.6.0, when a customer reported the same symptom there. Assets -> People never did, so it showed the last company picked - in pappas81's case, the company holding four of the seven people. Opening a person still worked because that checks every company you can reach.

Was it more than one place? Yes - the same filter was on every Assets read: the People list, the list of who holds equipment, a person's panel (their manager, reports and equipment), the asset list, the asset lookup and the dashboard widgets.

The fix - and the part deliberately not changed

People, holders and a person's panel now use activeTenantReadFilter(), as Tickets -> Users does.

The asset list, its lookup and its dashboard stay on one company on purpose. An existing asset's type, status and location dropdowns come from the selected company, so a list of every company's assets would make it easy to give one company's laptop another company's location. That was decided in 2.6.0 and still holds; how it can be lifted is on Assets and All companies - design, and the history of the decision is on All companies - how the design evolved.

What changed for the asset list: under All companies it now says which company it shows - "Showing Oakwood only. The asset list shows one company at a time ..." - instead of leaving it to be guessed. The Tickets help, which still said users and tasks did not widen, is corrected in all 9 languages.

πŸ“ Files

File Change
includes/services/assets.php people(), usersHoldingAssets(), assetsForUser() use activeTenantReadFilter()
api/assets/get_people.php The Source filter's counts, the same
asset-management/index.php The one-company note above the asset list under All companies
includes/tenancy.php Which lists are opted in, and a TRAP: comment for the next list
lang/*/asset-management.php, lang/*/tickets.php The note, and the corrected help, in 9 languages
tests/assets-all-companies.php New - 10 checks

How it was verified

tests/assets-all-companies.php adds a throwaway second company with a person and an asset in each, and removes them all afterwards. Under All companies, People, holders and a person's panel list both companies; working in one company, each lists only its own; and the asset list still lists only the selected company. Control: with the old filter, the People, holders and panel checks fail. The Assets page was loaded under All companies (note shown) and in one company (no note).

What this means for you

Update to 5.4.0. Under All companies, Assets -> People shows everyone you can reach. To work with another company's assets, pick that company at the top of the page.

Related: Assets Β· All companies view

FreeITSM

Getting Started

Modules

Multi-tenancy (planned)

Responses to feedback

Blue sky thinking

Bugs resolved

Pull requests

Links

Clone this wiki locally