[PM-3041] Add the possibility to require master password with biometrics on app reset#2621
Closed
abarghoud wants to merge 3691 commits intobitwarden:mainfrom
Closed
[PM-3041] Add the possibility to require master password with biometrics on app reset#2621abarghoud wants to merge 3691 commits intobitwarden:mainfrom
abarghoud wants to merge 3691 commits intobitwarden:mainfrom
Conversation
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
* [SG-166] Update fonts to have necessary icons * [SG-166] Add new custom view to hold a button with a font icon and a label. * [SG-166] Two Step login flow - Mobile (bitwarden#2153) * [SG-166] Add UI elements to Home and Login pages. Change VMs to function with new UI. Add new string resources. * [SG-166] Pass email parameter from Home to Login page. * [SG-166] Pass email to password hint page. * [SG-166] Remove remembered email from account switching. * [SG-166] Add GetKnownDevice endpoint to ApiService * [SG-166] Fix GetKnownDevice string uri * [SG-166] Add Renderer for IconLabel control. Add RemoveFontPadding bool property. * [SG-166] include IconLabelRenderer in Android csproj file * [SG-166] Add new control. Add styles for the control. * [SG-166] Add verification to start login if email is remembered * [SG-166] Pass default email to hint page * [SG-166] Login with device button only shows if it is a known device. * [SG-166] Change Remember Email to Remember me. Change Check to Switch control. * [SG-166] Add command to button for SSO Login * Revert "[SG-166] Update fonts to have necessary icons" This reverts commit 472b541. * [SG-166] Remove IconLabel Android renderer. Add RemoveFontPadding effect. * [SG-166] Update font with new device and suitcase icon * [SG-166] Fix RemoveFontPadding effect * [SG-166] Remove unused property in IconLabel * [SG-166] Fix formatting on IconLabelButton.xaml * [SG-166] Update padding effect to IconLabel * [SG-166] Add control variable to run code once on create * [SG-166] Add email validation before continue * [SG-166] Refactor icons * [SG-166] Update iOS Extension font * [SG-166] Remove HomePage login btn step * [SG-166] Make clickable area smaller * [SG-166] Fix hint filled by default * [SG-166] Fix IconButton font issue * [SG-166] Fix iOS extension * [SG-166] Move style to Base instead of platforms * [SG-166] Fix layout for IconLabelButton * [SG-166] Switched EventHandler for Command * [SG-166] Removed event handler * [SG-166] Fix LoginPage layout options * [SG-166] Fix extensions Login null email * [SG-166] Move remembered email logic to viewmodel * [SG-166] Protect method and show dialog in case of error * [SG-166] Rename of GetKnownDevice api method * [SG-166] rename text resource key name * [SG-166] Add close button to iOS extension * [SG-166] Switch event handlers for commands * [SG-166] Change commands UI thread invocation. * [SG-166] Remove Login with device button from the UI * [SG-166] Fixed appOptions and close button on iOS Extensions
* [SG-773] Change method call to message send * [SG-773] Introduce lock to avoid concurrent executions of login requests * [SG-773][SG-775] add comment * [SSG-773][SG-775] Refactor passwordlessLoginRequest string to constant
…#2156) * SG-786 - Added validation to check if the 400 error is invalid grant * SG 786 - Improved code quality
…pt (bitwarden#2161) * Implemented CAKE build script * cake script now deals with all of iOS's .plists * cake now updates iOS bundleid's / Android packagename in codefiles * iOS Bundle ID / Name should be correctly handled now + refactor * tabs -> spaces * Additional code files are now handled by cake * Additional iOS codefile changes required * Android's Autofill Label is now changed * Removed dash from packagenames / bundleIDs * Fixed CFBundleURLName set * Added google-services.json to cake preprocessing * Add CAKE to build workflow - Android * Add debug * Updated cake's GitVersion.Tool * AndroidManifest manual parsing needs to happen first * Added Android Constants to build.cake * [SG-747] Add Android QA build to mobile build pipeline (bitwarden#2144) * Add checkout depth * Build and upload QA artifacts * Remove missing .aab * Update build.yml * Update paths * Update var names * Build and upload QA artifacts * Add in matrix to path. * Lets not fail all the jobs if something pukes * Add in some flow logic for QA * We need strings in pwsh * Remove extra quotes * Testing, remove uneeded runs * Test folder items * [SG-747] Added more debug info to find problem * [SG-747] copy signed apk to correct file name for each app variant * [SG-747] try to fix if statement * [SG-747] separate decrypt google services into another step with condition. * [SG-747] fixed typo and line break * [SG-747] added debug to check output path * [SG-747] fix package name * [SG-747] Fixed condition of step execution * [SG-747] test if cases * [SG-747] Code clean up * [SG-747] Added FDroid and iOS steps. * [SG-747] Removed test step * [SG-747] Step name changes * Update condition to be more inclusive Co-authored-by: Álison Fernandes <vvolkgang@users.noreply.github.com> * [SG-747] Expand if condition to allow more build types other than QA * [SG-747] removed execution condition Co-authored-by: mimartin12 <77340197+mimartin12@users.noreply.github.com> * Apply suggestions from code review Linter suggestions Co-authored-by: mimartin12 <77340197+mimartin12@users.noreply.github.com> Co-authored-by: Micaiah Martin <mmartin@bitwarden.com> Co-authored-by: mimartin12 <77340197+mimartin12@users.noreply.github.com> Co-authored-by: Álison Fernandes <vvolkgang@users.noreply.github.com> Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com> * Base bundle ID refactor and cleaned up TODOs - Added base vars for the bundle IDs - Removed a TODO and explained the remaining ones - Commented a unused var, keeping it in the code as this might be useful later Co-authored-by: Micaiah Martin <mmartin@bitwarden.com> Co-authored-by: Federico Andrés Maccaroni <fedemkr@gmail.com> Co-authored-by: Todd Martin <tmartin@bitwarden.com> Co-authored-by: André Bispo <abispo@bitwarden.com> Co-authored-by: mimartin12 <77340197+mimartin12@users.noreply.github.com> Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
… is open does not display the request (bitwarden#2166) * [SG-800] Remove await from ActionSheet If the user never answers the pop up, the lock is never released. * [SG-800] Add try catch
* [SG-174] Add new login request services to Api * [SG-174] Fix typo * [SG-174] Enable login with device button. * [SG-174] Add new login request page and viewmodel * [SG-174] Add new text resources * [SG-174] Add new RSA Decrypt method with string param * [SG-174] Change create login request method * [SG-174] Add new method to auth service to login passwordless * [SG-174] Refactor login helper method to work with passwordless * [SG-174] Fix service registration * [SG-174] Update token request to support passwordless * [SG-174] Update Api service with passwordless methods * [SG-174] Fix App csproj references * [SG-174] Remove unnecessary argument * [SG-174] dotnet format * [SG-174] Fixed iOS Extensions * [SG-174] Change Command to ICommand * [SG-174] Change Gesture Recognizer to Command * [SG-174] Fix close action * [SG-174] Code format * [SG-174] Fix android frame shadow bug * [SG-174] PR fixes
bitwarden#2179) * Only show 'remove account' option if user is in Accounts list * Condense existing email logic * Add line break * Condense to local variable * Cleanup spacing
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
) * Merge branch 'master' into feature/SG-174-login-with-device * [SG-813] Fix merge * [SG-813] rename HomePage parameter name * [SG-813] Added NavParams for home page on account switching. * [SG-813] Remove account showing when adding new account. * [SG-813] Add account switch pop up if email already exists * [SG-813] Add default account avatar to HomePage * [SG-813] Code format * [SG-813] Remove unused import * [SG-813] Renamed checkNavigateLogin to shouldCheckRememberEmail * [SG-813] Move prompt account switch to account manager service * [SG-813] Remove Account button appears if email is the same as the ActiveUser * [SG-813] Fix code duplicate * [SG-813] Fix for android RemoveAccount button * [SG-813] Code format
…ordless request (bitwarden#2190) * [SG-778] Add properties to response model * [SG-778] Add validation for request already answered * [SG-778] Remove unnecessary properties * [SG-778] Remove unnecessary assignments
…rden#2196) * [SG-831] Pull to refresh forces refresh. * [SG-831] Expose sync login request method to be used independently * [SG-831] Change sync order
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
* AC-762 Added localization files to watch project * AC-762 Added crowdin config for watchOS localizable files
…ies to fix cases where the screen stays blank and doesn't update (bitwarden#2604)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
* PM-2320 Added new view for block autofill URIs on Android * PM-2320 Fix formatting * PM-2320 Improved validations on block autofill uris * PM-2320 Improved autofill block uris placeholder colors on different themes
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
* PM-1575 Added new models for Fido2Key * PM-1575 Added discoverable passkeys and WIP non-discoverable ones * PM-1575 Fix format * PM-1575 Added non-discoverable passkeys to login UI * PM-1575 Added copy application icon to Fido2Key UI * PM-1575 Updated bwi font with the updated passkey icon * PM-1575 For now just display Available for two-step login on non-discoverable passkey inside of a cipher login * PM-1575 Fix non-discoverable passkey visibility * PM-1575 remove Passkeys as a filter in the vault list * PM-1575 Display error toast if there is a duplicate passkey when moving a cipher to an org * Revert "PM-1575 Display error toast if there is a duplicate passkey when moving a cipher to an org" This reverts commit 78e6353. * [PM-2378] Display error toast on duplicate Passkey when moving cipher to an organization (bitwarden#2594) * PM-2378 Display error toast if there is a duplicate passkey when moving a cipher to an org * PM-3097 Fix issue when moving cipher with passkey to an org where the uniqueness should be taken into consideration on different passkeys types and also the Username (bitwarden#2632) * PM-3096 Fix non-discoverable passkey to be taken into account when encrypting a cipher which was causing the passkey to be removed when moving to an org (bitwarden#2637)
…ing on the background. (bitwarden#2647)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
* Clarify argon2 ios warning * Update Argon2 insufficient memory warning message
…tion (bitwarden#2606) * Add sync on send create/update/delete notification * Update send notifications to only sync sends * Fix incorrect notification type in PushNotificationListenerService Co-authored-by: aj-rosado <109146700+aj-rosado@users.noreply.github.com> * Invert if to improve readability * Simplify shouldUpdate logic in SyncUpsertSendAsync * Further simplify SyncService code * Fix if condition in SyncService Co-authored-by: aj-rosado <109146700+aj-rosado@users.noreply.github.com> * Fixed whitespace formatting --------- Co-authored-by: aj-rosado <109146700+aj-rosado@users.noreply.github.com> Co-authored-by: Andre Rosado <arosado@bitwarden.com>
* PM-1768 Add CODEOWNERS file with some initial setup of folders that don't need to be moved and can have their owners assigned already. * Update CODEOWNERS Removed entire projects owners cause I didn't consider auth inside of the extensions.
* Set team-leads-eng as owners for translations This is needed to Crowdin sync PRs can be merged. * Add team-tools as owner of the email-forwarders * Fix unescaped whitespace * Remove team-leads-eng from owning English resources
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com> Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
…ons (bitwarden#2698) * PM-3508 Fix Release iPhoneSimulator configuration for iOS / Extensions * PM-3508 Fix --deep space on watch app references
|
Hi, would something be done with this PR? |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
This PR addresses issue #2032, which is the possibility of setting if the app should ask for a master password with biometrics authentication on restart.
Code changes
Pinprefix from the translation keyPinprefix from the translation keyScreenshots
Before you submit
dotnet format --verify-no-changes) (required)