Updating Features/tuples with latest from Future #11346

csi.exe should emit exception to stderr, not stdout

…ory_Change Temporarily disable test CurrentWorkingDirectory_Change

This code has been moved to http://dotnet/roslyn-project-system

There are 2 changes here 1. Move some of the helpers from test_util to tools_util since the helpers are not depended on the helper binary and can work without any dependencies 2. Introduce TriggerAutomation.bat, which triggers the automation process. The reason we need a bat file to trigger this and not a csx or a new csx is because running the csx requires the helper binary. Hence we need to run the csx files from the binaries folder but we cannot have binaries in place if we dont fetch them in the first place. This is a cyclic problem that has to be broken with the help of one initial Trigger Batch file

…tory_Change Reenable CurrentWorkingDirectory_Change

Remove ProjectSystem code

Fix automation to fetch

Make completion service public

…-future20160504-150015 Conflicts: src/Compilers/Core/Portable/PublicAPI.Unshipped.txt src/Dependencies/VisualStudio/project.json src/Features/CSharp/Portable/CSharpFeatures.csproj src/Features/Core/Portable/Features.csproj src/Workspaces/Core/Portable/PublicAPI.Unshipped.txt

Add options to enable/disable nuget search.

…h the switch.

…g a default case.

…20160504-150015 Merge master into future

1. Split out the tests into ones with built-in IDE analyzers and ones with only third party analyzers 2. Tests depends on closed side changes (add/update VS tao actions)

Use threadlocal storage for pooling our matrices.

Update the diagnostics rolling perf tests

Fix NRE and provide better verbosity

Merge future into generators

Use nameof() instead of string literals in ArgumentExceptions

…-future20160505-150019 Conflicts: Makefile src/VisualStudio/CSharp/Impl/CSharpVSResources.resx src/VisualStudio/CSharp/Impl/Options/AutomationObject.cs src/VisualStudio/Core/Test/ServicesVisualStudioTest.vbproj src/VisualStudio/VisualBasic/Impl/BasicVSResources.resx src/Workspaces/Core/Portable/Workspaces.csproj

…/4801

…remarks

…20160505-150019 Merge master into future

…net#11075) Most of this PR is invisible. What I did was pull down the current toolset packages from azure and replaced the files in the dotnet-cli folder with new ones downloaded from https://github.com/dotnet/cli

…rary.

Source Generators: Entered tracking issues on Source Generators and removed "PROTOTYPE" remarks

Move Signature Help to features layer

Merge tuples to future

Calling TestUtilities.InitUtilities from within the library, instead of a csx file, will result in the path of the file where the library was initially built to be passed to InitUtilities which is not the expected behavior. Fixing it in all occurence Also removing some unnecessary and unused helpers

…-future20160506-150017 Conflicts: src/Debugging/Roslyn.Reflection.Metadata.Decoding/SignatureDecoder.cs src/Features/CSharp/Portable/CSharpFeaturesResources.resx

Since this file wasn't being included in the VSIX, it was having no effect. We're better off using CodeBase attributes anyways which apply earlier in the assembly resolution process.

This is correctly bundled along with the language services VSIX, which is the place it should ship with. We already take a VSIX dependency upon that VSIX.

This is a DLL that doesn't ship and isn't used for anything other than pkgdef generation.

…20160506-150017 Merge master into future

…of-testsetup Change contents of the TestSetup project

While installing the VSIXes using the install_vsixes.csx, uninstall the previous VSIXes before installing the new ones.

Call TestUtilities.InitUtilities appropriately

uninstall previous vsixes

Since "original" is by itself contextual on the presence of "replace", only "replace" actually needs to be keyed off a flag.

Populate switch tweaks

Check for Directory.Exists before deleting

…h's, while's, do-while's, and using's.

Update CoreFX dependencies to rc3-24102-00

Hide replace/original functionality behind a feature flag.

merge from recent Future into generators

Some CR feedback tidyup.

…pdate-into-master-open

This allows us to properly deploy it into VS rather than rely on AssemblyResolve hackery.

…-future20160507-150018

…-master-open Merge microupdate into master open

…20160507-150018 Merge master into future

Moved ISolutionCrawlerService down to workspace layer and made misc to use common default diagnostic analyzer service

…runtime-to-test-setup Include Microsoft.Diagnostics.Runtime in the test setup VSIX

They can call the public entry point instead.

This simplifies the test, and doesn't test the edge case where we have text buffers not backed by documents

@jaredpar

As a part of this change, I'm converting OptionSet from being a sealed, non-publically creatable type to an abstract type. I have chatted with @jaredpar and @davkean and we have all concluded this is a safe operation to make, assuming that anybody who was constructing the type is being recompiled. Since the only creator is within Roslyn itself, this is safe. I did have to update our PublicAPI.Shipped.txt baseline, because our public API checker includes modifiers in the list and is unaware that this particular modification is safe. Two APIs are added; Solution.Options exists that will eventually give a snapshotted OptionSet to ensure the same snapshot guarantees you get from the rest of the Solution API, and Document.Options exists to get the options that apply to a specific Document. I considered adding Project.Options, but discovered in practice nobody had a meaningful use for it. I had expected it could be used when generating new documents, but since style options can be specified on a file/folder basis, this wouldn't be safe to use in that case. This API isn't implemented in a meaningful way yet, but allows for features to consume the new system once it exists.

There are 2 reasons. 1. We are running into errors trying to unzip test solutions in the temp folder which is rooted deep inside the binaries folder 2. When trying to run the tests again, we need to delete the temp directories of each directory separately because we could pick up csx files from the test files. We could solve the 2nd issue by cleaning up after the run. But the 1st issue still stands

Since we dont run the iterations as a scenario, we dont need to number the scenarios

One TempDirectory For all tests

Fixed typo in field name

…nt-and-project-specific-options Add API for consuming solution and document-specific options

Added traits attributes to the generators tests

we used to create all solution crawler analyzers lazily. which means all analyzers only register themselves once the very first solution crawler pass has run. this caused ctrl+. for LB right after solution open sometimes not work since solution crawler didn't run its first pass yet so there is no analyzers registered to system. now, we create solution crawler analyzers for active files non-lazily. those analyzers should be ready right away once solution is up.

create active file analyzers non-lazily.

dotnet#11151) Previouly we assumed that the type parameters in a method would not be of the same TypeSymbol when generating a method and put them in a dictionary. This causes exceptions when attempting to add to the dictionary and the TypeSymbol is already added as a key. Now we use a list of instead of a dictionary. Fixes dotnet#10004

Adds an analyzer/codefix for adding missing braces Fixes dotnet#10942

Switch to straight metadata reading to build our metadata indices for add-using and add-reference.

Add null checks before raising events. Fixes [217660](https://devdiv.visualstudio.com/DevDiv/_workitems?_a=edit&id=217660&triage=true)

Fix edge cases typing Enter before /**/ comments.

1. Support allocation-free enumeration of the dictionary. 2. Pool internal data so that less garbage is churned when creating and releasing dictionaries.

…-future20160511-150020 Conflicts: src/Compilers/Core/Portable/PublicAPI.Unshipped.txt src/EditorFeatures/CSharpTest/Diagnostics/GenerateMethod/GenerateMethodTests.cs src/Features/Core/Portable/Diagnostics/DefaultDiagnosticAnalyzerService.cs src/Features/Core/Portable/Diagnostics/DiagnosticAnalyzerService_IncrementalAnalyzer.cs src/Workspaces/Core/Portable/Workspaces.csproj

dotnet#11225) * Ensure that we suppress compilation diagnostics reported in generated code when the analyzer is configured to analyze generated code, but not report diagnostics on generated code. Fixes dotnet#11217 * Address PR feedback to improve performance of AnalyzerDriver.IsInGeneratedCode * Address PR feedback and modify test

Fix dotnet#9719: Add Module kind to CLS Compliance checker

…y.Create (dotnet#11238) Fixes dotnet#11092

…20160511-150020 Merge master into future

…ers (was just ctor initializers)

"replace" is roughly allowed in the same contexts as "async", so the "replace" ecommender is basically a copy of "async" recommender. Fixes: dotnet#11191

CR feedback.

Fix JSON serialization

Make keyword recommender know about "replace"

…otnet#11222)

…Test Utilities and adding the start of 'CSharpAutomaticBraceCompletion'

Generalize dynamic static-only restriction to include field initializers

Fix dotnet#9945: Check if dynamic property is set-only when dotting off it

…tation Fixed complex trivia tab indentation

Merge recent future into generators

…-future20160512-150016

… feature.

Improve OrderPreservingMultiDictionary.

… tend to fail with `RPC_E_CALL_REJECTED`.

…20160512-150016 Merge master into future

Avoid loading the Elfie dll until the user actualy enables the search feature.

Extending the supported functionality of the VisualStudio IntegrationTest Utilities and adding the start of 'CSharpAutomaticBraceCompletion'

Merging Features/generators into Future.

Add missed code hooking up the option for /**/ comments

1. Reference a bunch of stuff from Nuget packages instead of VS. 2. Move to Update 2 versions of packages. 3. Now that we are using the packages, we're referencing Microsoft.VisualStudio.Shell.14.dll instead of .15 again. This means that types that moved to Shell.Immutable.15 are not type forwarders. Luckily we didn't need anything from Shell.Immutable.15 in the project where it was a problem.

More cleanup to do between RoslynCompletionSet and FilteredRoslynCompletionSet.

Support VS "15" specific features

…#11246) This supports running an analyzer that warns when a user implements these interfaces. A prerequisite to fix dotnet/roslyn-analyzers#863. - Copied the remark from `ISymbol` derivations on all public interfaces that derive from `IOperation` - Added remark and `[InternalImplementationOnly]` on `IOperation` - Removed `[InternalImplementationOnly]` from `ISourceAssemblySymbol` because it was only there, unneeded

…-future20160513-150016 Conflicts: Roslyn.sln build/Targets/VSL.Imports.targets src/Compilers/Core/MSBuildTaskTests/MSBuildTaskTests.csproj src/Dependencies/VisualStudio/project.json src/EditorFeatures/Core/Implementation/IntelliSense/Completion/Temporary/IIntellisenseFilter.cs src/VisualStudio/Core/Def/Implementation/TableDataSource/Suppression/SuppressionStateColumnFilterDefinition.cs src/Workspaces/CoreTest/ServicesTest.csproj

…20160513-150016 Merge master into future

Also, don't install it as part of build on Dev14.

Don't bundle binaries in VisualStudioSetup.Next

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating Features/tuples with latest from Future #11346

Updating Features/tuples with latest from Future #11346

Commits on May 3, 2016

Commits on May 4, 2016

Commits on May 5, 2016

Commits on May 6, 2016

Commits on May 7, 2016

Commits on May 8, 2016

Commits on May 9, 2016

Commits on May 10, 2016

Commits on May 11, 2016

Commits on May 12, 2016

Commits on May 13, 2016

Commits on May 16, 2016