-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 4.1-dev from 4.0-dev #31409
Merged
Merged
Update 4.1-dev from 4.0-dev #31409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [4.0] Missing js file in joomla#30813 * missing new line
…-sql-with-fixed-menu-item-ids [4.0] Don't use the "id" column as criterion in WHERE clauses for updating menu items in update SQL scripts
* Update lib_joomla.ini * fix thanks @infograf768
Remove duplicated warning messages Solves joomla#29309
* [4.0] joomla update show password PR for joomla#29765 ### Steps to reproduce the issue Joomla 4 System -> Joomla (Update box) Choose any file (joomla#29763 bug allows any file) Click upload and install ### Expected result Password hide/reveal icon is clickable like all other password boxes in Joomla 4 * icon width
…la#30857) * Fall back to system template * Load parent language file only when needed * Correct template file
…oomla#30847) PR for joomla#29958 The values in the XML are different to those in the variables.scss when they should be the same As no reply from @coolcat-creations or @angieradtke to confirm which is the correct version I took the choice to make the xml match the scss
* [4.0] xtd-editor button for module The icon used was the same as the one for articles. This PR changes it to be the cube that is used in the module manager. * cube
On very long pages (eg install from web) as you scroll down the page the sidebar menu disappears off screen. This PR makes the sidebar sticky so that it never scrolls out of the screen just as the subhead toolbar is sticky. pr for joomla#30019
* [4.0] Media Manager close preview * suggestion from @Fedik
The media manager uses a background of checked squares in the thumbnail view which is useful when you have a transparent image such as the joomla_black.png However in the preview it uses a solid white background which hides most of this image. This pr replaces the white background with the checked squares
[4.0b4] Class 'Joomla\CMS\Installation\Helper\ArrayHelper' not found see issue joomla#30900
PR for joomla#30180 No need to load a 200kb image when its only being displayed on a button
Enable language debug Open an article On the save button dropdown you will see `??**Save to Menu**??` Apply the PR Now the button is correctly displayed as `**Save to Menu**`
* Changed all JHelp file name strings * Fixed Admin_Modules:_Frontend_Link in joomla.ini * Changed JHelp module admin strings to new file names * Made api joomla.ini JHELP same as joomla.ini Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
misprint 'Filer' > 'Filter'
* taking off NUM column * adding back itemscope * string used in form * Getting rid of fieldset * removing title as required
refactoring layout for a11y+
don't display the heading additionally in the body
[4.0] Frontend List articles in a category: adding Clear filter, refactoring layout for a11y+
…ts_list [4.0] Frontend: Normalise List contacts
* [4.0] Select article etc styling * propogate field - thanks @infograf768
* prepare for login webauth * make frontend match backend * make frontend match backend * changed button to primary * added support for svg * use htmlhelper & sanity check * check for valid filetype * check for valid filetype * remove path check * creates svg icon helper * changed to global usage * forgot $relative * Update libraries/src/HTML/Helpers/Icons.php Co-authored-by: Quy <quy@fluxbb.org> * Update plugins/system/webauthn/src/PluginTraits/AdditionalLoginButtons.php Co-authored-by: Quy <quy@fluxbb.org> * Update libraries/src/HTML/Helpers/Icons.php Co-authored-by: Quy <quy@fluxbb.org> * remove use file * remove use file * remove transform styling * Update libraries/src/HTML/Helpers/Icons.php Co-authored-by: Quy <quy@fluxbb.org> * relative was reversed * removed empty line * working on exceptions * error checking done. * remove unused string * cleanup * better extension test per sharky * remove strpos per sharky * pathcheck * Update libraries/src/HTML/Helpers/Icons.php Co-authored-by: Quy <quy@fluxbb.org> * Update libraries/src/HTML/Helpers/Icons.php Co-authored-by: SharkyKZ <sharkykz@gmail.com> * Update libraries/src/HTML/Helpers/Icons.php Co-authored-by: SharkyKZ <sharkykz@gmail.com> * added missing use Joomla\Filesystem\Path; * add global namespace * Update libraries/src/HTML/Helpers/Icons.php Co-authored-by: Brian Teeman <brian@teeman.net> * various corrections from Brian Teeman * phpcs fix * color styling per sharky * Update templates/cassiopeia/scss/blocks/_icons.scss Co-authored-by: Quy <quy@fluxbb.org> * spacer fix * phpcs * fill fix * rtl * rtl * change svg transparency to solid * move some css out of language direction * add margin to atum * changed scss * changed to var(--xxx) Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: SharkyKZ <sharkykz@gmail.com> Co-authored-by: Brian Teeman <brian@teeman.net>
* [4.x] Tinmyce image decorative This PR enables the native tinymce feature to mark an image as decorative. This continues the work started in joomla#31318 and joomla#31323
This PR adds support for the two pagination options
This fixes the missing strings reported in joomla#30965.
… different header per client. (joomla#31128) Co-authored-by: Quy <quy@fluxbb.org>
) As required in joomla#30467 the filter.condition is changed to filter.published.
Co-authored-by: Quy <quy@fluxbb.org>
…la#31391) Correct display and title of Component Dashboard display of a Dashboard icon
Simple PR to add hotkey support. Once enabled the plugin can be opened either with a mouse or now with the hotkey **CTRL + ALT + A**. Co-authored-by: Quy <quy@fluxbb.org>
Continues the work of joomla#31318 and joomla#31323 by correcting the behaviour of the alt text and changing the strings to match the work done in joomla#31318
Added scope row. Taking off useless `headers="categorylist_header_WHATEVER"` Display `Written by` and `Hits` in badge only when table headings are set to No in the list layout parameters.
…chers (joomla#31381) Vote and ratings fields are list and not switchers. Switchers there are not only displayed wrong but they do not allow to select Use Global settings. This PR also prevents the fields from being displayed when the vote plugin is disabled.
Ensure that a disabled dropdown select really looks disabled
…omla#30467) In com_content and related modules, filter.condition is used for filtering published, unpublished, archived, trashed data. This might cause problems when 3rd party extension set filters for articles. This PR sets back the name to filter.published in J3. It does not change the behaviour in any way.
bembelimen
requested review from
HLeithner,
rdeutz,
wilsonge and
zero-24
as code owners
November 15, 2020 18:36
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.