Issues.00474

00474: planet2 bmp mapping adds light past the terminator

« 00473 | Issues | 00475 »

Summary: planet2 bmp mapping adds light past the terminator

Created: 2013–02–01 11:22

Status: Released

Category: Request

From: frankie

Version: 2.2

Released_In: 2.3

Description:

When using a bump map layer on a planet, the normal of the surface is what determines the lighting. Given some of the steep walls of craters on the moon, this can cause some lighted spots on areas past the terminator that should be dark due to self-shadowing.

This is a request to change the lighting calculation so that the spheroid normal of the planet is first used to figure out which side of the terminator you are on, and then apply the bump mapping calculation.

---

Comments

brad Feb 01 2013 at 3:45pm: This has been fixed.

---

« 00473 | Issues | 00475 »

Associated Commits

| commit | 296252f00256de7972f23b1684a10a4ad6815c01 [link] | || | Author: | Brad Bell | | Date: | Fri Feb 1 15:40:44 2013 -0600 | | Message: | [@Issue 00474: fixed problem with lighting on planets past the terminator @] |

Affected Files:

plugin_Darwin/dsp_planet2.so    | Bin 457588 -> 457588 bytes
 plugin_Linux_FC3/dsp_planet2.so | Bin 530980 -> 485944 bytes
 plugin_Win32/dsp_planet2.dll    | Bin 1307001 -> 1307001 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)

| commit | adfa2f1be170b65e25c56b48f9bdbe721c5b975b [link] | || | Author: | Brad Bell | | Date: | Tue Feb 19 17:31:10 2013 -0600 | | Message: | [@EDGE Issue:00474 fixed shading on planets so that bump/elevation does not get lit from the sun much past the terminator @] |

Affected Files:

src/plugins/planet2_funcs2_fs.c              | 6 +++±-
 src/plugins/planet2_funcs2_mac_fs.c          | 6 +++±-
 src/plugins/planet2_funcs_fs.c               | 7 ++++±-
 src/plugins/planet2_funcs_mac_fs.c           | 7 ++++±-
 src/plugins/planet_shaders/planet2_funcs.fs  | 7 ++++±-
 src/plugins/planet_shaders/planet2_funcs2.fs | 6 +++±-
 6 files changed, 27 insertions(+), 12 deletions(-)

| commit | 854f9f57fa013408b83fbd1df0c71c16c9268793 [link] | || | Author: | Brad Bell | | Date: | Fri Feb 1 16:13:29 2013 -0600 | | Message: | [@EDGE Issue 00474: fixed shading issues that occur at the terminator when using elevation or bump data @] |

Affected Files:

src/plugins/planet2_funcs2_fs.c              | 5 +++±
 src/plugins/planet2_funcs2_mac_fs.c          | 5 +++±
 src/plugins/planet2_funcs_fs.c               | 5 +++±
 src/plugins/planet2_funcs_mac_fs.c           | 5 +++±
 src/plugins/planet_shaders/planet2_funcs.fs  | 5 +++±
 src/plugins/planet_shaders/planet2_funcs2.fs | 5 +++±
 6 files changed, 24 insertions(+), 6 deletions(-)