Wrong ctrl+click underline with multiple definitions #160958
Assignees
Labels
bug
Issue identified by VS Code Team member as probable bug
editor-symbols
definitions, declarations, references
insiders-released
Patch has been released in VS Code Insiders
verified
Verification succeeded
Milestone
Comments
jrieken
added
bug
|
related #160522 (comment) |
jrieken
added a commit
that referenced
this issue
Nov 3, 2022
VSCodeTriageBot
added
unreleased
KendallDoesCoding
pushed a commit
to KendallDoesCoding/vscode
that referenced
this issue
Nov 5, 2022
* `collapseByDefault` for notebook should also honor new setting fixes microsoft#164542 * Tunnel: Fix host name issue (microsoft#164708) * tunnel: Generate vanity URL (microsoft#164710) * fix microsoft#164458 (microsoft#164711) * Fix microsoft#164606 (microsoft#164714) * Fix microsoft#164617 (microsoft#164717) * Transform ext host log URI on remote side (microsoft#164712) * Transform ext host log URI on remote side * Fix mistype * Allow action labels to be long in comment header (microsoft#164614) * Allow action labels to be long in comment header Part of microsoft#164288 * Better fix * Fix microsoft#163163 (microsoft#164721) * Fix microsoft#162240 (microsoft#164723) * Fix microsoft#162439 (microsoft#164719) * Fix microsoft#162439 * better fix and also add tests * Move log message outside of 'if' block so I have confirmation that smoething happened * Re microsoft#164715. Better error handling of notebook opening (microsoft#164737) * Fix microsoft#164704. comment thread memory leak. (microsoft#164734) * Fix microsoft#164704. comment thread memory leak. * Dispose first. * spell check * Use `border-radius: 2px` (microsoft#164747) Fixes microsoft#164555: Use `border-radius: 2px` * Do not adjust y offset when the mouse is below the last line (microsoft#164750) Fixes microsoft#164131: Do not adjust y offset when the mouse is below the last line * tunnel --name should rename previous tunnel (microsoft#164753) * tunnel --name should rename old tunnel * fix clippy warning * Fix markdown server not updating documents properly on folder rename (microsoft#164752) Fixes microsoft#164562 * Fix microsoft#164715. Turn cell into editing mode when there is a selection. (microsoft#164758) * Add min-height to work around clipping (microsoft#164759) Fixes microsoft#164602 * Shorten markdown link button titles (microsoft#164764) Fixes microsoft#164556 * Pick up latest markdown LS (microsoft#164763) Includes a few more fixes for link update on rename * Clean up a few markdown setting descriptions (microsoft#164765) Clean up wording and make sure we use `Markdown` uppercase * Rework markdown update link glob (microsoft#164766) * Rework markdown update link glob Fixes microsoft#164587 This changes the `externalFileGlobs` setting to instead be a include array of globs that should trigger link updates. I've split the globs into markdown files and image/video files This also makes it easier for users to add their own new globs to the list * Fix scopes * Store edit session before prompting to select edit session destination (microsoft#164780) * Don't ship yarn.lock file with the markdown extension (microsoft#164794) * Always patch the npm registry in `yarn.lock` files and compute the node modules cache key after having patched them (microsoft#164795) * Fixes microsoft#163931 (microsoft#164802) * fix name of profile tmp-file (microsoft#164805) * make sure `startup.resource.perf` doesn't contain paths (microsoft#164812) * make sure `startup.resource.perf` doesn't contain paths microsoft#164810 * use posix.basename... * Quick check to circumvent regex in many cases (microsoft#164815) * Quick check to circumvent regex in many cases * Fix logic * Fix .ipynb extension name capitalization (microsoft#164817) Towards microsoft/vscode-jupyter#11773 * Bump distro (microsoft#164821) * Use posix path for markdown links (microsoft#164822) Fixes microsoft#164782 * Fix markdown document deleting (microsoft#164829) Fixes microsoft#164562 My previous fix was incorrect as it checked if the document existed by still consulting our `_documentCache`. When we are deleting/renaming an opened md document, it should pretty much always exist in our cache The fix is to instead treat `this.documents` and the file system as the source of truth when determining if the doc should be deleted or not * Disable markdown insert link commands in readonly editors (microsoft#164820) Disable insert link commands in readonly editors * Skip clear if there is nothing in the actionbar list (microsoft#164839) * Engineering - Empty commit (microsoft#164850) Empty commit * Engineering - Add quality in the build name (microsoft#164855) Add quality in the build name * Fix text of IW command palette entries (microsoft#164860) * chore: update electron@19.1.3 (microsoft#164864) * Use simple `IAction` instead of `Action`in quick input (microsoft#164842) For actions that are static, it is better to use `IAction`. This avoids creating an extra disposable, emitter, and event listener (when used with an action bar) This is helpful in the quick input list as we need to render elements rapidly while scrolling * Engineering - adopt l10n for git-base/git/github extesions (microsoft#164566) Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> * 💄 Banner - remove registerThemingParticipant (microsoft#164879) * Commit Action button polish (microsoft#164746) * * force the use of `InstantiationType` * mark all standalone editor services as eager * mark remaining extension host services as eager (microsoft#164883) * force the use of `InstantiationType` * mark all standalone editor services as eager * mark remaining extension host services as eager * perf - ignore new listeners when leakage threshold is exceeded by far (microsoft#164885) * debt - extract outline actions and outline interfaces into separate files (microsoft#164887) * chore: update electron@19.1.3 (microsoft#164882) * chore: update electron@19.1.3 * fix: update api name * 💄 Diff decorators - remove registerThemingParticipant (microsoft#164889) * 💄 use event naming conventions for EmitterOptions (microsoft#164890) * avoid object-spread in perf-critical code, use `Object.assign`-instead (microsoft#164892) * Use `IAction` instead of `Action` for search item action (microsoft#164844) For actions that are static, it is better to use `IAction` instead of `Action`. This avoids creating an extra disposable, emitter, and event listener (when used with an action bar). It also means you don't have to dispose of the action This small optimization is useful here because we create one of these actions for every search item in the list as you scroll * Defer creation of `monaco-icon-description-container` (microsoft#164659) We don't need to create the `monaco-icon-description-container` container until the description is actually needed. In many cases it is never filled in, so we can skip creating this empty node * Swap list/tree icons to reflect current state instead of target state (microsoft#164835) * Swap search result tree/list view icons * Swap SCM list/tree view icons * Sort the keys in order to be more predictable (microsoft#164920) sort the keys in order to be more predictable * Fix timeline not disposing of template properly (microsoft#164838) We should dispose the entire template, not just the `iconLabel` * Remove exports of unused types (microsoft#164943) For microsoft#164939 * Don't export `SelectKernelReturnArgs` (microsoft#164944) * Fix bugs with close of markdown docs (microsoft#164942) There are two bugs here: - Something in the lsp is converting a value from `undefined` to `null`. To fix this, I've updated us just to check for falsy values instead - The `hasInMemoryDoc` implementation was incorrect. It needs to verify that the value of `this.inMemoryDoc` is not null/undefined * Pick up latest markdown LS (microsoft#164945) Picks up microsoft/vscode-markdown-languageservice#84 * bump unique names generator (microsoft#165015) * 💄 SCM - Remove registerThemingParticipant (microsoft#165038) * SCM - adopt more theme variables * Remove registerThemingParticipant * unexport createDecorator (microsoft#165039) related to microsoft#164938 * Remove inlineCompletionsNew proposal. Fixes microsoft#164856 (microsoft#165044) * SCM - fix action button border (microsoft#165048) Fix regression * Implements microsoft#164686 * Only export symbols that are needed (microsoft#165052) * Fixes microsoft#164934: Only export symbols that are needed * `KeyMod` is referenced by `monaco.d.ts` * Add email attachments are lost on Github (microsoft#165057) Add email attachments are lost Github * Show progress when storing edit session as part of Continue On flow (microsoft#164903) * Show progress when storing edit session as part of Continue On flow * Port release fix * update notebook milestones (microsoft#165064) * Remove exports and unused types (microsoft#164939) (microsoft#165065) * Updates custom menu borders and item styles (microsoft#164165) Updates menu item margin and radius and adds border to default themes * improve title bar settings for web (microsoft#165068) fixes microsoft#164768 * use updated private API name (microsoft#165069) fix microsoft#164899 * Pick up latest TS for VS Code (microsoft#165075) * Remove unused import for notebook background (microsoft#165070) * remove some of listed unused imports * Adopt notebook serializer for test (microsoft#165078) For microsoft#160580 * GitHub Enterprise Auth improvements (microsoft#165082) 1. Namespace secrets based on the value of github-enterprise.uri to support "multiple separate GHES instances" 2. If the setting value disappears, continue using last set value. Fixes microsoft/vscode-pull-request-github#3992 3. Mark github-enterprise.uri as requires trust 3. Refactoring like: * UriHandler is handled in extension.ts and passed down everywhere since we can only have 1 instance of it * misc style (`private` usage, better `disposable` handling) * Adopt notebook serializer for notebook document tests (microsoft#165081) For microsoft#160580 Also remove one test that is no longer relevant * Adopt prefix private with _ in markdown extension (microsoft#165088) * Bump version for Nov. (microsoft#165091) * Improve log message for aborting resuming an edit session (microsoft#165108) * Pick up latest markdown language service (microsoft#165093) * fix microsoft#154064 which was running the wrong taskgroups (microsoft#164983) * add trace logs for search parent debug (microsoft#165095) * add trace logs for search parent debug * Remove a few `export`s (microsoft#165106) Ref microsoft#164941 * Fix microsoft#164630 (microsoft#165096) * The true fix * some code clean up * Revert "Bump version for Nov. (microsoft#165091)" (microsoft#165118) This reverts commit 8b4642a. This seems to be causing our builds to fail: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=191117&view=logs&j=4801dce2-64f3-53d6-b366-d49a1977c639&t=d3816dfe-5f5f-5b74-f77f-0a43291213b6&l=22 * Remove the 🥕 since we have modes in the go to file (microsoft#164437) Fixes microsoft#163957 * Pick up latest TS for building VS Code (microsoft#165104) * Pick up latest TS for building VS Code * Pick up latest node typings * Bump node types * Reduce unused exports (microsoft#164935) * Update to current Devcontainer extension image link (microsoft#163557) * fix inno setup build for non-insider qualities (microsoft#165143) fixes microsoft#165142 * add 🚀 build tag to builds which go through publishing (microsoft#165145) * skip flaky test (microsoft#165150) * skip flaky test related to microsoft#165149 * skip the entire suite * smoketests should not fail by bumping version in package.json (microsoft#165132) related to microsoft#165118 * bump version (microsoft#165133) * Update grammars (microsoft#165100) * fix Alpine builds with npm custom registry (microsoft#165137) fixes microsoft#165135 * api feedback (microsoft#164470) * api feedback - remove critical log level - move log level off to be 0 * handle off log level * fix disabling log level in tests Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> * Highlight label should not create extra span nodes (microsoft#164657) * Highlight label should not create extra empty dom nodes I noticed that the `HighlightedLabel` class creates extra `span` elements for text ranges. These should not be needed. Using text children directly should be faster for creation and also reduce the number of nodes in the document I also related the conditional spread with a longer version that uses a simple call to push. This is worth doing since `HighlightedLabel` is so widely used in the editor * Update tests * Update smoke test selector * Update css * lramos15/xenacious-bedbug (microsoft#165083) * Don't shortcircuit active editor in Resolver * Fix broken test * debt - use CSS variables instead of `registerThemingParticipant` (microsoft#165164) * Fixes task reconnection status does not work for default build task (microsoft#165110) Fixes microsoft#159639 Co-authored-by: Megan Rogge <merogge@microsoft.com> * a11y issues to Megan (microsoft#165166) * More unused exports (microsoft#165167) For microsoft#164939 * Clean up some unused exports (microsoft#165107) For microsoft#164937 * Fix tree data provider being accessed after disposed (microsoft#165087) * Fix tree data provider being accessed after disposed Fixes microsoft/vscode-pull-request-github#4002 * Use setTimeout0 * use ctxt menu event for all actBar context menus (microsoft#165177) fixes microsoft#163247 * Remove a few `export`s (microsoft#165158) * Remove a few `export`s * don't omit indirect exports * Remove unneeded `export` (microsoft#165178) Part of microsoft#164933 * Use `_` for privates in webview code (microsoft#165183) * only renderBody when view is visible/expanded (microsoft#165187) fixes PaneView calls renderBody even when the pane is collapsed microsoft#164662 * prevent `.zshenv` recursion (microsoft#165174) fix microsoft#163843 * Use css vars for lightbulb (microsoft#165186) Fixes microsoft#165169 * Limit shifting (microsoft#165141) * Do not render synchronously when restoring the state, the desired `scrollLeft` is maintained even if the `scrollWidth` is small (microsoft#165193) * use != operator instead of -ne (microsoft#165191) use != operator * Audio Cues: Don't play the same sound in parallel. Fixes microsoft#164921 (microsoft#165194) * re microsoft#164939. reduced unused exports. (microsoft#165196) * re microsoft#164939. reduced unused exports in notebook worker. (microsoft#165198) * Markdown lang preview settings description (microsoft#165109) * Change descriptions to just say “Enable…” Previously these said “Enable or disable…”, which in the context of a tick box doesn’t make sense. * Change “Enable/disable” wording in descriptions * webview: ignore Ctrl+W and Ctrl+N in webview for PWA (microsoft#164981) This fixes closing Release Notes / Markdown Preview with Ctrl+W closing whole PWA. PWAs can intercept the Ctrl+W/Ctrl+N keystrokes, and VSCode does this for editor tabs. However, webviews do not intercept these keystrokes. If a webview such as Release Notes or Markdown Preview has focus: - when the user presses Ctrl+N, another instance of the PWA is opened in a new window. - when the user presses Ctrl+W, the whole PWA window closes. See microsoft#150735 for details. This fixes the issue by ignoring Ctrl+W and Ctrl+N in webviews. Tested on macOS 12.6 / Chrome Dev 109.0.5384.0: - patch environmentService.ts webviewExternalEndpoint to use http://localhost:8080/static/sources/out/vs/workbench/contrib/webview/browser/pre/ - followed the contributing instruction to run code-web - in Chrome, More Tools -> Create Shortcut -> Open as window - closed and re-opened Code OSS PWA window - opened chrome://inspect and inspected the Code OSS window - added an uncaught exception handler - opened file.md and chose "Open preview" - when it hit `Expected '${parentOriginHash}' as hostname or subdomain!` manually ran `start(parentOrigin)` in console and continued - the markdown preview now displayed - pressed Command+W Before: the whole window closes After: only the Markdown preview tab closes * Prompt users to test with extensions disabled (microsoft#165203) * Pick up TS 4.9 rc for bundled VS Code version (microsoft#165205) * don't create and dispose submenus (microsoft#165206) fixes microsoft#161413 * Remove notebook content provider api (microsoft#165195) Fixes microsoft#160580 Fixes microsoft#147248 * Notebook find widget and toolbar css variable. * Cell comments css variables * Typo: folding controller. (microsoft#165211) * Don't clear the pause reason for other threads when processing a stopped event with allThreadsStopped=true (microsoft#165180) Fix microsoft#165032 * Diff overview ruler css variables * Reduce theme participant for notebook diff editor * use ID for quick fix telemetry (microsoft#165197) * Fix KaTeX equation numbering in notebook preview (microsoft#156276) Fixes microsoft#155888 * cleanup ipc integration tests (microsoft#165221) * more test cleanup (microsoft#165233) * Switch to using CSS (microsoft#165185) * Switch to using CSS * Better fallback value * adopt `vscode.l10n` in references view (microsoft#165245) microsoft#164438 * report perf marks whenever delivered (microsoft#165250) * Nit: fix Tip blocks case (microsoft#165223) * Fix some cases of incremental naming disabled (microsoft#165253) * Let opener service validate that only specific commands can be run in command uris (microsoft#165204) * Save all dirty editors before storing edit session (microsoft#165246) * don't set quick pick items every time value changes (microsoft#165113) * Fix autoreveal on file nest (microsoft#165272) * skip resolve (without backup) test (microsoft#165277) * TestInstantiationService in fileDialogService.test.ts (microsoft#165270) Part of microsoft#164297 * Duplicating Menu Actions when switching profiles (microsoft#165274) Fixes microsoft#161910 * Fix microsoft#164690 microsoft#164730 (microsoft#165279) - Maintain default installed extensions manifest always - Adopt to default installed extensions manifest - Add externally installed extension to default extensions manifest * Remove ianhu from team github issue notebooks (microsoft#165281) * remove ianhu from team github issue notebooks * revert accidental line end change Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local> * tweak quick pick pin conditional (microsoft#165285) tweak conditional * Update quick pick placeholders and/or remove titles (microsoft#165267) * Use ?. for property access (microsoft#165295) * Bump targets for test/automation and test/integration (microsoft#165298) Also enables strict mode for test/integration since it only had strict null checks previously * Revert "Fix microsoft#164690 microsoft#164730 (microsoft#165279)" (microsoft#165302) * Reduce usage of invalid property overrides (microsoft#165293) With native property fields, a few of our properties are no longer valid. This either removes them or switches them to use declare instead * Enable strict mode and bump target for test/smoke (microsoft#165296) * Move notebook editor widget theme to css variables (microsoft#165300) * Fixes microsoft#165238 (microsoft#165242) * Fix microsoft#164690 microsoft#164730 (microsoft#165331) * Revert "Revert "Fix microsoft#164690 microsoft#164730 (microsoft#165279)" (microsoft#165302)" This reverts commit d9ed6d1. * store migration completion marker in profile * joh/external marlin (microsoft#165336) * move typeHierarchyPeek onto CSS variables * move symbolIcons onto CSS variables * move markerHoverParticipant onto CSS variables * starting timings (perf machine) shouldn't complain about missing cached data (microsoft#165342) * combine all origin selection ranges when having multiple go-to via mouse result (microsoft#165349) fixes microsoft#160958 * stricter definition for what a trival snippet it (microsoft#165355) fixes microsoft#163808 * Align cache key across OSes (microsoft#165042) * Attempt to fix Rust clippy lint errors (microsoft#165377) * Reduce loaded web modules (microsoft#165369) * Partially reverts 1b83b96 (microsoft#165372) Partially reverts microsoft@1b83b96 * Implement Add "Ignore" buttons microsoft#164425 (microsoft#165387) * Fix renderHeight being undefined (microsoft#165373) * Git - Remove localization from askpass-main (microsoft#165129) Remove localization from askpass as it runs in a separate process * Fix tasks status incorrect microsoft#163393 (microsoft#163952) * Fix arrows in side-by-side diff view * Reduce unused exports, ref microsoft#164939 (microsoft#165389) * last folding range not restored (microsoft#165390) * last folding range not restored * Update src/vs/editor/contrib/folding/browser/foldingRanges.ts Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> * Update src/vs/editor/contrib/folding/browser/foldingRanges.ts Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> * Update src/vs/editor/contrib/folding/browser/foldingRanges.ts Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> * proper check for WCO (microsoft#165384) fixes microsoft#165337 * eslint: add a new rule to enforce `declare _serviceBrand: undefined` (microsoft#165396) * debt: move or remove `NullXYZServices` (microsoft#165397) We have a few NullXYZServices. Those are useful for testing but we should move them to separate files so that we don't end up shipping them with the product * Fixes `Terminal: Focus Terminal Tabs view` command not working (microsoft#164408) * Remove redundant CSS rules (microsoft#165401) Ref microsoft#165169 Ref microsoft#157564 After changing workspace trust and policy settings to use indicators, a bunch of CSS rules became redundant. This PR removes those CSS rules. * Contributed activity's busy icon fails to display after resetting containing TreeView's badge state (microsoft#165255) Fixes microsoft#165181 * Bump target for build scripts (microsoft#165287) * Refactor settingsWidgets (microsoft#165412) * WIP Change Settings editor CSS to variables * Refactor settingsWidgets * remove unused exports (microsoft#165411) task part of microsoft#164933 * Improve file dialog action button (microsoft#165417) * Improve file dialog action button * `Location` -> `Destination` * adopt CSS variables in terminal (microsoft#165419) * Improve command center hover colors (microsoft#165427) Improve command center hover interaction * keybindingLabel: switch theming to css variables (microsoft#165426) * use the actual extension id as the id in the language pack (microsoft#165436) Past behavior caused 404s to be thrown by the unpkg service because core was trying to load: `${extensionId}` -> `vscode.markdown` and not what the build creates in the language packs: `vscode.${extensionFolder}` -> `vscode.markdown-basics` this aligns build time and runtime. * Use CSS variables for settingsTree.ts (microsoft#165437) Ref microsoft#165169 * Add accessibility role type to the checkbox in getting started step * Add typings for webview messages (microsoft#165446) * fix microsoft#165434 (microsoft#165440) * Adopt l10n for markdown extension (microsoft#165448) For microsoft#164438 Also makes our eslint rules understand `vscode.l10n.t(` * Adopt l10n for ts extension (microsoft#165450) For microsoft#164438 Also refines the eslint rule from microsoft#165448 * Git - Add "OK, Don't Ask Again" button to the publish branch prompt (microsoft#165487) Add "OK, Don't Ask Again" button to the publish branch prompt * support updating installed extensions (microsoft#165485) * support updating installed extensions when installed externally (cli, manual) * 💄 * refactor * Git - Optimistic UI plumbing (microsoft#165237) * Reduce unused exports (microsoft#165494) * do not set appication extensions location for default profile (microsoft#165496) * Progressbar: Use css variables for styling (microsoft#165503) Progressbar: Use css variables for styling (for microsoft#165478) * Also make button focusable * Fix typings issues with TestInstantiationService microsoft#164297 (microsoft#165514) * Comment view filtering: incorrect count (Showing x of y) (microsoft#165517) Fixes microsoft#165444 * better error message * Fix microsoft#165410. No css variables defined at root. (microsoft#165519) * Adopt l10n for configuration-editing (microsoft#165521) For microsoft#164438 * Remove overzealous telemetry (microsoft#165524) * Adopt l10n for media-preview (microsoft#165525) For microsoft#164438 * Adopt l10n for simple-browser (microsoft#165529) For microsoft#164438 * Adopt l10n for merge-conflict (microsoft#165531) For microsoft#164438 * Skip debug tree error in telemetry (microsoft#165535) Fix microsoft#164053 * Move some keybinding editor colours to CSS (microsoft#165537) Ref microsoft#165169 * Adopt l10n for extension-editing (microsoft#165523) For microsoft#164438 * Fix microsoft#165480 (microsoft#165486) * Adopt l10n for jake (microsoft#165541) For microsoft#164438 * More logs around SecretStorage (microsoft#165542) * Adopt l10n for gulp (microsoft#165543) For microsoft#164438 * Comment widget doesn't work with inline diffs on deleted lines (microsoft#165547) Fixes microsoft#164729 * Try to sort console history entries in recency order (microsoft#165549) Fix microsoft#148072 * Adopt l10n for grunt and php-language-features (microsoft#165552) * Adopt l10n for grunt For microsoft#164438 * Adopt l10n for php-language-features For microsoft#164438 * Adopt l10n for npm package (microsoft#165527) For microsoft#164438 * Fix UI string (microsoft#165554) * add task section to terminal dropdown (microsoft#165553) * Update role and aria-label for the Hide button in the Welcome View (microsoft#165505) Update role and aria-label for the Hide button * Checkbox is hard to see in dark mode on selected file change node in tree view (microsoft#165556) Fixes microsoft#163881 * don't show title bar context on cmd (microsoft#165557) fixes microsoft#165545 * Remove executePrimary and notebookEditor proposal (microsoft#165532) Fix microsoft#164505 * treat editor tab ctrl+click as right click (microsoft#165558) fixes microsoft#160413 * Use css variables for editor scrollbar (microsoft#165464) Co-authored-by: gcb4 <gcb4@sfu.ca> * check if a task run is in progress before running it (microsoft#165560) * Pick up latest TS for building VS Code (microsoft#165562) * Refactor sash hover border to use CSS var (microsoft#165516) Ref microsoft#165169 * adopt css var in lieu of registerThemingParticipant (microsoft#165561) * panel and auxiliar bar part css refs microsoft#165169 * unused imports * Increase min-height to 100% (microsoft#165566) Fixes microsoft#165518 * Move list of trusted extensions to product.json & enable for Desktop (microsoft#165565) Fixes https://github.com/microsoft/vscode-internalbacklog/issues/3161 It's wild to me that we only allowed this on web originally. This should get rid of quite a few dialogs on Desktop. * Localize emmet using l10n.t (microsoft#165568) Ref microsoft#164438 * run auto tasks if trusted & on (microsoft#165570) * Try passing offset to editors on layout (microsoft#164287) * Try passing offset to editors on layout When a notebook editor is created, it currently has to force a relayout to determine where the overlay webview should be positioned. We do this with a call to `getBoundingClientRect` However the grid view should already have information about where the editor is positioned. If we can use this, then we can skip the expensive call to `getBoundingClientRect` entirely This change attempts to pass the `top` and `left` offsets to the `EditorGroupView` and eventually down into `NotebookEditorWidget` The PR does not work properly however as the offset that the `EditorGroupView` gets is wrong. I've added some todo comments about where this seems to be happening * Remove todo and update layout over * Git - Only use `this.dotGit` when resolving HEAD (microsoft#165497) Fix microsoft#164363 Co-authored-by: Johannes <johannes.rieken@gmail.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com> Co-authored-by: Logan Ramos <lramos15@gmail.com> Co-authored-by: Alex Ross <alros@microsoft.com> Co-authored-by: Rob Lourens <roblourens@gmail.com> Co-authored-by: Peng Lyu <penn.lv@gmail.com> Co-authored-by: Alexandru Dima <alexdima@microsoft.com> Co-authored-by: Matt Bierner <matb@microsoft.com> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> Co-authored-by: Joyce Er <joyce.er@microsoft.com> Co-authored-by: Henning Dieterichs <notify.henning.dieterichs@live.de> Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Co-authored-by: gjsjohnmurray <johnm@georgejames.com> Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> Co-authored-by: David Dossett <ddossett@microsoft.com> Co-authored-by: João Moreno <joao.moreno@microsoft.com> Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com> Co-authored-by: Megan Rogge <merogge@microsoft.com> Co-authored-by: SteVen Batten <6561887+sbatten@users.noreply.github.com> Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com> Co-authored-by: Jason Williams <936006+jasonwilliams@users.noreply.github.com> Co-authored-by: Christof Marti <chrmarti@microsoft.com> Co-authored-by: Takafumi Umemoto <takafumi.umemoto@gmail.com> Co-authored-by: Jean Pierre <jeanp413@hotmail.com> Co-authored-by: Isidor Nikolic <inikolic@microsoft.com> Co-authored-by: Andre Weinand <aweinand@microsoft.com> Co-authored-by: Hugh Lilly <hughlilly@users.noreply.github.com> Co-authored-by: zhuowei <zhuoweizhang@yahoo.com> Co-authored-by: Peng Lyu <penlv@microsoft.com> Co-authored-by: Ping <5123601+pingren@users.noreply.github.com> Co-authored-by: SphinxKnight <SphinxKnight@users.noreply.github.com> Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local> Co-authored-by: Huiwen <huiwen@gitpod.io> Co-authored-by: Mingpan <mingpanguo@gmail.com> Co-authored-by: Bhavya Udayashankar <bhavyau@microsoft.com> Co-authored-by: aamunger <aamunger@microsoft.com> Co-authored-by: pafernandez-oesia <96843912+pafernandez-oesia@users.noreply.github.com> Co-authored-by: Gaurav Bhagchandani <gbolosta@gmail.com> Co-authored-by: gcb4 <gcb4@sfu.ca>
connor4312
added
the
author-verification-requested
|
This bug has been fixed in the latest release of VS Code Insiders! @RedCMD, you can help us out by commenting If things still don't seem right, please ensure you're on version 56d73a4 of Insiders (today's or later - you can use Happy Coding! |
|
/verified |
VSCodeTriageBot
added
verified
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When creating a ctrl+click/hover definition
I can supply
originSelectionRangeto customize the underlined textHowever if two definitions are provided upon a single ctrl+click
Vscode defaults back to the language's
wordPatternfororiginSelectionRangewhich gives a bad ctrl+click underline range
(changing the
wordPatternis not an option as it is not context aware, and it messes with other features)(and preview hovers are not shown. expected?)
Single definition: (correct behaviour)
Multiple definitions: (wrong behaviour)
The text was updated successfully, but these errors were encountered: