Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial tidying before Models in Browse Data #38107

Merged
merged 8 commits into from
Jan 24, 2024
Merged

Initial tidying before Models in Browse Data #38107

merged 8 commits into from
Jan 24, 2024

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented Jan 24, 2024 •
edited
Loading

This PR ports some files, and makes some small improvements, to lay the groundwork for #37707

@rafpaf rafpaf self-assigned this Jan 24, 2024
@rafpaf rafpaf requested a review from iethree January 24, 2024 20:16
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Jan 24, 2024
@rafpaf rafpaf added the no-backport Do not backport this PR to any branch label Jan 24, 2024
@rafpaf rafpaf marked this pull request as ready for review January 24, 2024 20:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

Codenotify: Notifying subscribers in CODENOTIFY files for diff 6fa6db7...e5dc39f.

Notify File(s)
@kdoh frontend/src/metabase/ui/components/icons/Icon/icons/index.ts

@replay-io replay.io
Copy link

replay-io bot commented Jan 24, 2024 •
edited
Loading

StatusIn Progress ↗︎ 30 / 52
Commit9051eca
Results
❌ 1 Failed
  • should handle a failure to `GET` the list of all databases (metabase#20471) 
      AssertionError: Timed out retrying after 4000ms: Unable to find an accessible element with the role "heading" and name "Something's gone wrong"
Here are the accessible roles:
  document:
  Name "":
  <body
    class="bg-white"
  />
  --------------------------------------------------
  banner:
  Name "":
  <div
    class="emotion-h8rnyx eltsee94"
    role="banner"
  />
  --------------------------------------------------
  link:
  Name "Get help connecting":
  <a
    class="eltsee91 emotion-3dj3vm e1esz5s90"
    href="https://metabase.com/help/connect?email=admin%40metabase.test&site_url=http%3A%2F%2Flocalhost%3A4000"
    rel="noopener noreferrer"
    target="_blank"
  />
  Name "Connect your database":
  <a
    class="emotion-93qn1h emeibx70"
    href="/admin/databases/create"
  />
  Name "":
  <a
    class="e1nb3k9i0 emotion-th3m3g emeibx70"
    data-metabase-event="Navbar;Logo"
    href="/admin"
  />
  Name "Settings":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;Settings"
    href="/admin/settings"
  />
  Name "Databases":
  <a
    class="e1xn2pom0 emotion-oead5r emeibx70"
    data-metabase-event="NavBar;Databases"
    href="/admin/databases"
  />
  Name "Table Metadata":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;Table Metadata"
    href="/admin/datamodel"
  />
  Name "People":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;People"
    href="/admin/people"
  />
  Name "Permissions":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;Permissions"
    href="/admin/permissions"
  />
  Name "Tools":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;Tools"
    href="/admin/tools"
  />
  Name "Audit":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;Audit"
    href="/admin/audit"
  />
  Name "Troubleshooting":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;Troubleshooting"
    href="/admin/troubleshooting"
  />
  Name "Exit admin":
  <a
    class="e1nb3k9i3 emotion-1bcnbqx emeibx70"
    data-metabase-event="Navbar;Exit Admin"
    data-testid="exit-admin"
    href="/"
  />
  --------------------------------------------------
  button:
  Name "Connect your database":
  <button
    class="Button eltsee90 Button--small emotion-n3tp0o emiw9oj2"
  />
  --------------------------------------------------
  navigation:
  Name "Navigation bar":
  <nav
    aria-label="Navigation bar"
    class="Nav emotion-1ajweme e1nb3k9i8"
  />
  --------------------------------------------------
  list:
  Name "":
  <ul
    class="emotion-qir0z2 e1nb3k9i7"
  />
  Name "undo-list":
  <ul
    aria-label="undo-list"
    class="emotion-tclgn0 ep79zz28"
    data-testid="undo-list"
  />
  --------------------------------------------------
  listitem:
  Name "":
  <li />
  Name "":
  <li />
  Name "":
  <li />
  Name "":
  <li />
  Name "":
  <li />
  Name "":
  <li />
  Name "":
  <li />
  Name "":
  <li />
  --------------------------------------------------
  main:
  Name "":
  <main
    class="emotion-kfkb8q enx0u2k0"
  />
  --------------------------------------------------
  status:
  Name "":
  <h2
    aria-live="polite"
    class="text-medium"
    role="status"
  />
  Name "":
  <div
    class="empty-state-message emotion-t3z6ax e1n1nmg90"
    color="medium"
    role="status"
  />
  --------------------------------------------------
Ignored nodes: comments, <script />, <style />
<html
  lang="en"
  translate="no"
>
  <head>
    <meta
      charset="utf-8"
    />
    <meta
      content="IE=edge"
      http-equiv="X-UA-Compatible"
    />
    <meta
      content="width=device-width,initial-scale=1,maximum-scale=1,user-scalable=no"
      name="viewport"
    />
    <meta
      content="noindex"
      name="robots"
    />
    <meta
      content="yes"
      name="apple-mobile-web-app-capable"
    />
    <meta
      content="black-translucent"
      name="apple-mobile-web-app-status-bar-style"
    />
    <link
      href="app/assets/img/apple-touch-icon.png"
      rel="apple-touch-icon"
      sizes="180x180"
    />
    <link
      href="app/assets/img/favicon.ico"
      rel="icon"
    />
    <link
      crossorigin="use-credentials"
      href="app/assets/img/site.webmanifest"
      rel="manifest"
    />
    <meta
      content="#2d89ef"
      name="msapplication-TileColor"
    />
    <meta
      content="app/assets/img/browserconfig.xml"
      name="msapplication-config"
    />
    <meta
      content="#ffffff"
      name="theme-color"
    />
    <meta
      content="default"
      name="apple-mobile-web-app-status-bar-style"
    />
    <meta
      content="/"
      name="base-href"
    />
    <meta
      content="/admin/databases"
      name="uri"
    />
    <title>
      Databases · Admin · Metabase
    </title>
    <base
      href="/"
    />
    <link
      href="app/dist/styles.496a179b23d206251307.css"
      rel="stylesheet"
    />
    <link
      href="app/dist/app-main.8c3db53cb80ee9443da7.css"
      rel="stylesheet"
    />
  </head>
  <body
    class="bg-white"
  >
    <div
      id="root"
    >
      <div
        class="spread emotion-1fttcpj enx0u2k2"
      >
        <div
          class="emotion-h8rnyx eltsee94"
          role="banner"
        >
          <div
            class="emotion-yp7p eltsee93"
          >
            Connect to your database to get the most from Metabase.
          </div>
          <div
            class="emotion-1yrq68l eltsee92"
          >
            <a
              class="eltsee91 emotion-3dj3vm e1esz5s90"
              href="https://metabase.com/help/connect?email=admin%40metabase.test&site_url=http%3A%2F%2Flocalhost%3A4000"
              rel="noopener noreferrer"
              target="_blank"
            >
              Get help connecting
            </a>
            <a
              class="emotion-93qn1h emeibx70"
              href="/admin/databases/create"
            >
              <button
                class="Button eltsee90 Button--small emotion-n3tp0o emiw9oj2"
              >
                <div
                  class="emotion-zxs4gr emiw9oj1"
                >
                  <div
                    class=" emotion-1w35l9a emiw9oj0"
                  >
                    Connect your database
                  </div>
                </div>
              </button>
            </a>
          </div>
        </div>
        <div
          class="emotion-19z4y7k enx0u2k1"
        >
          <nav
            aria-label="Navigation bar"
            class="Nav emotion-1ajweme e1nb3k9i8"
          >
            <a
              class="e1nb3k9i0 emotion-th3m3g emeibx70"
              data-metabase-event="Navbar;Logo"
              href="/admin"
            >
              <div
                class="emotion-rot1nj e1nb3k9i2"
              >
                <span
                  class="Icon text-centered text-white text-brand my2"
                  data-testid="main-logo"
                >
                  <svg
                    fill="currentcolor"
                    height="32"
                    viewBox="0 0 66 85"
                    xmlns="http://www.w3.org/2000/svg"
                    xmlns:xlink="http://www.w3.org/1999/xlink"
                  >
                    <path
                      d="M46.8253288,70.4935014 C49.5764899,70.4935014 51.8067467,68.1774705 51.8067467,65.3205017 C51.8067467,62.4635329 49.5764899,60.147502 46.8253288,60.147502 C44.0741676,60.147502 41.8439108,62.4635329 41.8439108,65.3205017 C41.8439108,68.1774705 44.0741676,70.4935014 46.8253288,70.4935014 Z M32.8773585,84.9779005 C35.6285197,84.9779005 37.8587764,82.6618697 37.8587764,79.8049008 C37.8587764,76.947932 35.6285197,74.6319011 32.8773585,74.6319011 C30.1261973,74.6319011 27.8959405,76.947932 27.8959405,79.8049008 C27.8959405,82.6618697 30.1261973,84.9779005 32.8773585,84.9779005 Z M32.8773585,70.4935014 C35.6285197,70.4935014 37.8587764,68.1774705 37.8587764,65.3205017 C37.8587764,62.4635329 35.6285197,60.147502 32.8773585,60.147502 C30.1261973,60.147502 27.8959405,62.4635329 27.8959405,65.3205017 C27.8959405,68.1774705 30.1261973,70.4935014 32.8773585,70.4935014 Z M18.9293882,70.4935014 C21.6805494,70.4935014 23.9108062,68.1774705 23.9108062,65.3205017 C23.9108062,62.4635329 21.6805494,60.147502 18.9293882,60.147502 C16.1782271,60.147502 13.9479703,62.4635329 13.9479703,65.3205017 C13.9479703,68.1774705 16.1782271,70.4935014 18.9293882,70.4935014 Z M46.8253288,56.0091023 C49.5764899,56.0091023 51.8067467,53.6930714 51.8067467,50.8361026 C51.8067467,47.9791337 49.5764899,45.6631029 46.8253288,45.6631029 C44.0741676,45.6631029 41.8439108,47.9791337 41.8439108,50.8361026 C41.8439108,53.6930714 44.0741676,56.0091023 46.8253288,56.0091023 Z M18.9293882,56.0091023 C21.6805494,56.0091023 23.9108062,53.6930714 23.9108062,50.8361026 C23.9108062,47.9791337 21.6805494,45.6631029 18.9293882,45.6631029 C16.1782271,45.6631029 13.9479703,47.9791337 13.9479703,50.8361026 C13.9479703,53.6930714 16.1782271,56.0091023 18.9293882,56.0091023 Z M46.8253288,26.8995984 C49.5764899,26.8995984 51.8067467,24.5835675 51.8067467,21.7265987 C51.8067467,18.8696299 49.5764899,16.553599 46.8253288,16.553599 C44.0741676,16.553599 41.8439108,18.8696299 41.8439108,21.7265987 C41.8439108,24.5835675 44.0741676,26.8995984 46.8253288,26.8995984 Z M32.8773585,41.5247031 C35.6285197,41.5247031 37.8587764,39.2086723 37.8587764,36.3517034 C37.8587764,33.4947346 35.6285197,31.1787037 32.8773585,31.1787037 C30.1261973,31.1787037 27.8959405,33.4947346 27.8959405,36.3517034 C27.8959405,39.2086723 30.1261973,41.5247031 32.8773585,41.5247031 Z M32.8773585,10.3459994 C35.6285197,10.3459994 37.8587764,8.02996853 37.8587764,5.17299969 C37.8587764,2.31603085 35.6285197,0 32.8773585,0 C30.1261973,0 27.8959405,2.31603085 27.8959405,5.17299969 C27.8959405,8.02996853 30.1261973,10.3459994 32.8773585,10.3459994 Z M32.8773585,26.8995984 C35.6285197,26.8995984 37.8587764,24.5835675 37.8587764,21.7265987 C37.8587764,18.8696299 35.6285197,16.553599 32.8773585,16.553599 C30.1261973,16.553599 27.8959405,18.8696299 27.8959405,21.7265987 C27.8959405,24.5835675 30.1261973,26.8995984 32.8773585,26.8995984 Z M18.9293882,26.8995984 C21.6805494,26.8995984 23.9108062,24.5835675 23.9108062,21.7265987 C23.9108062,18.8696299 21.6805494,16.553599 18.9293882,16.553599 C16.1782271,16.553599 13.9479703,18.8696299 13.9479703,21.7265987 C13.947970...
    at Context.eval (http://localhost:4000/__cypress/tests?p=e2e/test/scenarios/admin/databases/database-exceptions.cy.spec.js:42949:10)
      AssertionError: Timed out retrying after 4000ms: Unable to find an accessible element with the role "heading" and name "Something's gone wrong"
Here are the accessible roles:
  document:
  Name "":
  <body
    class="bg-white"
  />
  --------------------------------------------------
  banner:
  Name "":
  <div
    class="emotion-h8rnyx eltsee94"
    role="banner"
  />
  --------------------------------------------------
  link:
  Name "Get help connecting":
  <a
    class="eltsee91 emotion-3dj3vm e1esz5s90"
    href="https://metabase.com/help/connect?email=admin%40metabase.test&site_url=http%3A%2F%2Flocalhost%3A4000"
    rel="noopener noreferrer"
    target="_blank"
  />
  Name "Connect your database":
  <a
    class="emotion-93qn1h emeibx70"
    href="/admin/databases/create"
  />
  Name "":
  <a
    class="e1nb3k9i0 emotion-th3m3g emeibx70"
    data-metabase-event="Navbar;Logo"
    href="/admin"
  />
  Name "Settings":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;Settings"
    href="/admin/settings"
  />
  Name "Databases":
  <a
    class="e1xn2pom0 emotion-oead5r emeibx70"
    data-metabase-event="NavBar;Databases"
    href="/admin/databases"
  />
  Name "Table Metadata":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;Table Metadata"
    href="/admin/datamodel"
  />
  Name "People":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;People"
    href="/admin/people"
  />
  Name "Permissions":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;Permissions"
    href="/admin/permissions"
  />
  Name "Tools":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;Tools"
    href="/admin/tools"
  />
  Name "Audit":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;Audit"
    href="/admin/audit"
  />
  Name "Troubleshooting":
  <a
    class="e1xn2pom0 emotion-hcbzg8 emeibx70"
    data-metabase-event="NavBar;Troubleshooting"
    href="/admin/troubleshooting"
  />
  Name "Exit admin":
  <a
    class="e1nb3k9i3 emotion-1bcnbqx emeibx70"
    data-metabase-event="Navbar;Exit Admin"
    data-testid="exit-admin"
    href="/"
  />
  --------------------------------------------------
  button:
  Name "Connect your database":
  <button
    class="Button eltsee90 Button--small emotion-n3tp0o emiw9oj2"
  />
  --------------------------------------------------
  navigation:
  Name "Navigation bar":
  <nav
    aria-label="Navigation bar"
    class="Nav emotion-1ajweme e1nb3k9i8"
  />
  --------------------------------------------------
  list:
  Name "":
  <ul
    class="emotion-qir0z2 e1nb3k9i7"
  />
  Name "undo-list":
  <ul
    aria-label="undo-list"
    class="emotion-tclgn0 ep79zz28"
    data-testid="undo-list"
  />
  --------------------------------------------------
  listitem:
  Name "":
  <li />
  Name "":
  <li />
  Name "":
  <li />
  Name "":
  <li />
  Name "":
  <li />
  Name "":
  <li />
  Name "":
  <li />
  Name "":
  <li />
  --------------------------------------------------
  main:
  Name "":
  <main
    class="emotion-kfkb8q enx0u2k0"
  />
  --------------------------------------------------
  status:
  Name "":
  <h2
    aria-live="polite"
    class="text-medium"
    role="status"
  />
  Name "":
  <div
    class="empty-state-message emotion-t3z6ax e1n1nmg90"
    color="medium"
    role="status"
  />
  --------------------------------------------------
Ignored nodes: comments, <script />, <style />
<html
  lang="en"
  translate="no"
>
  <head>
    <meta
      charset="utf-8"
    />
    <meta
      content="IE=edge"
      http-equiv="X-UA-Compatible"
    />
    <meta
      content="width=device-width,initial-scale=1,maximum-scale=1,user-scalable=no"
      name="viewport"
    />
    <meta
      content="noindex"
      name="robots"
    />
    <meta
      content="yes"
      name="apple-mobile-web-app-capable"
    />
    <meta
      content="black-translucent"
      name="apple-mobile-web-app-status-bar-style"
    />
    <link
      href="app/assets/img/apple-touch-icon.png"
      rel="apple-touch-icon"
      sizes="180x180"
    />
    <link
      href="app/assets/img/favicon.ico"
      rel="icon"
    />
    <link
      crossorigin="use-credentials"
      href="app/assets/img/site.webmanifest"
      rel="manifest"
    />
    <meta
      content="#2d89ef"
      name="msapplication-TileColor"
    />
    <meta
      content="app/assets/img/browserconfig.xml"
      name="msapplication-config"
    />
    <meta
      content="#ffffff"
      name="theme-color"
    />
    <meta
      content="default"
      name="apple-mobile-web-app-status-bar-style"
    />
    <meta
      content="/"
      name="base-href"
    />
    <meta
      content="/admin/databases"
      name="uri"
    />
    <title>
      Databases · Admin · Metabase
    </title>
    <base
      href="/"
    />
    <link
      href="app/dist/styles.496a179b23d206251307.css"
      rel="stylesheet"
    />
    <link
      href="app/dist/app-main.8c3db53cb80ee9443da7.css"
      rel="stylesheet"
    />
  </head>
  <body
    class="bg-white"
  >
    <div
      id="root"
    >
      <div
        class="spread emotion-1fttcpj enx0u2k2"
      >
        <div
          class="emotion-h8rnyx eltsee94"
          role="banner"
        >
          <div
            class="emotion-yp7p eltsee93"
          >
            Connect to your database to get the most from Metabase.
          </div>
          <div
            class="emotion-1yrq68l eltsee92"
          >
            <a
              class="eltsee91 emotion-3dj3vm e1esz5s90"
              href="https://metabase.com/help/connect?email=admin%40metabase.test&site_url=http%3A%2F%2Flocalhost%3A4000"
              rel="noopener noreferrer"
              target="_blank"
            >
              Get help connecting
            </a>
            <a
              class="emotion-93qn1h emeibx70"
              href="/admin/databases/create"
            >
              <button
                class="Button eltsee90 Button--small emotion-n3tp0o emiw9oj2"
              >
                <div
                  class="emotion-zxs4gr emiw9oj1"
                >
                  <div
                    class=" emotion-1w35l9a emiw9oj0"
                  >
                    Connect your database
                  </div>
                </div>
              </button>
            </a>
          </div>
        </div>
        <div
          class="emotion-19z4y7k enx0u2k1"
        >
          <nav
            aria-label="Navigation bar"
            class="Nav emotion-1ajweme e1nb3k9i8"
          >
            <a
              class="e1nb3k9i0 emotion-th3m3g emeibx70"
              data-metabase-event="Navbar;Logo"
              href="/admin"
            >
              <div
                class="emotion-rot1nj e1nb3k9i2"
              >
                <span
                  class="Icon text-centered text-white text-brand my2"
                  data-testid="main-logo"
                >
                  <svg
                    fill="currentcolor"
                    height="32"
                    viewBox="0 0 66 85"
                    xmlns="http://www.w3.org/2000/svg"
                    xmlns:xlink="http://www.w3.org/1999/xlink"
                  >
                    <path
                      d="M46.8253288,70.4935014 C49.5764899,70.4935014 51.8067467,68.1774705 51.8067467,65.3205017 C51.8067467,62.4635329 49.5764899,60.147502 46.8253288,60.147502 C44.0741676,60.147502 41.8439108,62.4635329 41.8439108,65.3205017 C41.8439108,68.1774705 44.0741676,70.4935014 46.8253288,70.4935014 Z M32.8773585,84.9779005 C35.6285197,84.9779005 37.8587764,82.6618697 37.8587764,79.8049008 C37.8587764,76.947932 35.6285197,74.6319011 32.8773585,74.6319011 C30.1261973,74.6319011 27.8959405,76.947932 27.8959405,79.8049008 C27.8959405,82.6618697 30.1261973,84.9779005 32.8773585,84.9779005 Z M32.8773585,70.4935014 C35.6285197,70.4935014 37.8587764,68.1774705 37.8587764,65.3205017 C37.8587764,62.4635329 35.6285197,60.147502 32.8773585,60.147502 C30.1261973,60.147502 27.8959405,62.4635329 27.8959405,65.3205017 C27.8959405,68.1774705 30.1261973,70.4935014 32.8773585,70.4935014 Z M18.9293882,70.4935014 C21.6805494,70.4935014 23.9108062,68.1774705 23.9108062,65.3205017 C23.9108062,62.4635329 21.6805494,60.147502 18.9293882,60.147502 C16.1782271,60.147502 13.9479703,62.4635329 13.9479703,65.3205017 C13.9479703,68.1774705 16.1782271,70.4935014 18.9293882,70.4935014 Z M46.8253288,56.0091023 C49.5764899,56.0091023 51.8067467,53.6930714 51.8067467,50.8361026 C51.8067467,47.9791337 49.5764899,45.6631029 46.8253288,45.6631029 C44.0741676,45.6631029 41.8439108,47.9791337 41.8439108,50.8361026 C41.8439108,53.6930714 44.0741676,56.0091023 46.8253288,56.0091023 Z M18.9293882,56.0091023 C21.6805494,56.0091023 23.9108062,53.6930714 23.9108062,50.8361026 C23.9108062,47.9791337 21.6805494,45.6631029 18.9293882,45.6631029 C16.1782271,45.6631029 13.9479703,47.9791337 13.9479703,50.8361026 C13.9479703,53.6930714 16.1782271,56.0091023 18.9293882,56.0091023 Z M46.8253288,26.8995984 C49.5764899,26.8995984 51.8067467,24.5835675 51.8067467,21.7265987 C51.8067467,18.8696299 49.5764899,16.553599 46.8253288,16.553599 C44.0741676,16.553599 41.8439108,18.8696299 41.8439108,21.7265987 C41.8439108,24.5835675 44.0741676,26.8995984 46.8253288,26.8995984 Z M32.8773585,41.5247031 C35.6285197,41.5247031 37.8587764,39.2086723 37.8587764,36.3517034 C37.8587764,33.4947346 35.6285197,31.1787037 32.8773585,31.1787037 C30.1261973,31.1787037 27.8959405,33.4947346 27.8959405,36.3517034 C27.8959405,39.2086723 30.1261973,41.5247031 32.8773585,41.5247031 Z M32.8773585,10.3459994 C35.6285197,10.3459994 37.8587764,8.02996853 37.8587764,5.17299969 C37.8587764,2.31603085 35.6285197,0 32.8773585,0 C30.1261973,0 27.8959405,2.31603085 27.8959405,5.17299969 C27.8959405,8.02996853 30.1261973,10.3459994 32.8773585,10.3459994 Z M32.8773585,26.8995984 C35.6285197,26.8995984 37.8587764,24.5835675 37.8587764,21.7265987 C37.8587764,18.8696299 35.6285197,16.553599 32.8773585,16.553599 C30.1261973,16.553599 27.8959405,18.8696299 27.8959405,21.7265987 C27.8959405,24.5835675 30.1261973,26.8995984 32.8773585,26.8995984 Z M18.9293882,26.8995984 C21.6805494,26.8995984 23.9108062,24.5835675 23.9108062,21.7265987 C23.9108062,18.8696299 21.6805494,16.553599 18.9293882,16.553599 C16.1782271,16.553599 13.9479703,18.8696299 13.9479703,21.7265987 C13.947970...
    at Context.eval (http://localhost:4000/__cypress/tests?p=e2e/test/scenarios/admin/databases/database-exceptions.cy.spec.js:42949:10)
⚠️ 2 Flaky
  • should allow non-user to unsubscribe from subscription 
      Timed out retrying after 4000ms: Expected to find content: 'You've unsubscribed non-user@example.com from the "Orders in a dashboard" alert.' but never did.
  • should validate approved email domains for a dashboard subscription in the audit app 
      Timed out retrying after 4050ms: `cy.click()` failed because the page updated while this command was executing. Cypress tried to locate elements based on this query:
> cy.findByText(1)
We initially found matching element(s), but while waiting for them to become actionable, they disappeared from the page. Common situations why this happens:
  - Your JS framework re-rendered asynchronously
  - Your app code reacted to an event firing and removed the element
You can typically solve this by breaking up a chain. For example, rewrite:
> `cy.get('button').click().click()`
to
> `cy.get('button').as('btn').click()`
> `cy.get('@btn').click()`
https://on.cypress.io/element-has-detached-from-dom
✅ 1177 Passed

iethree
iethree approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@iethree iethree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆🏆🏆🏆

pirate-pirate-ship

@rafpaf rafpaf enabled auto-merge (squash) January 24, 2024 21:47
@rafpaf rafpaf disabled auto-merge January 24, 2024 21:48
@rafpaf rafpaf enabled auto-merge (squash) January 24, 2024 22:07
@rafpaf
Copy link
Contributor Author

rafpaf commented Jan 24, 2024 •
edited
Loading

Just making a note for posterity:

image

This PR removes the 'all' icon from one component which results in it no longer displaying the icon for 'unknown', which is a gray circle, currently shown above 'Nothing here' on master

@rafpaf rafpaf merged commit 86cea6c into master Jan 24, 2024
106 checks passed
@rafpaf rafpaf deleted the models-in-browse-data--tidyfirst branch January 24, 2024 23:15
@github-actions GitHub Actions
Copy link

@rafpaf Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@rafpaf rafpaf added this to the 0.49 milestone Jan 25, 2024
@rafpaf rafpaf mentioned this pull request Jan 25, 2024
Closed
sloansparger pushed a commit that referenced this pull request Feb 5, 2024
@rafpaf @sloansparger
Initial tidying before putting models on the Browse Data page (#38107)
c363847 
* Port BrowseHeader to tsx

* Use generic type with useSearchListQuery

* Allow the query to be specified in setupDatabasesEndpoints

* Port EmptyState to tsx

* Correct type in FilterableTree

* Remove unneeded props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iethree iethree iethree approved these changes

Assignees

@rafpaf rafpaf

Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Milestone
0.49
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rafpaf @iethree