-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Loading state while checking dashboard redirect #37089
Conversation
f8316da
to
f64de02
Compare
Codenotify: Notifying subscribers in CODENOTIFY files for diff 2c7eb30...f64de02.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 this feels much nicer
); | ||
|
||
//Ensure that when the loading header is gone, we are no longer on the home page | ||
cy.findByTestId("home-page", { timeout: 0 }).should("not.exist"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! I like this optimization
@npfitz Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
* Show Loading state while checking dashboard redirect * adding e2e test
Closes #35454
Description
Describe the overall approach and the problem being solved.
How to verify
Describe the steps to verify that the changes are working as expected.
Demo
Upload a demo video or before/after screenshots if sensible or remove the section
Checklist