Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Loading state while checking dashboard redirect #37089

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

npfitz
Copy link
Contributor

@npfitz npfitz commented Dec 22, 2023

Closes #35454

Description

Describe the overall approach and the problem being solved.

How to verify

Describe the steps to verify that the changes are working as expected.

  1. New question -> Sample Dataset -> ...
  2. ...

Demo

Upload a demo video or before/after screenshots if sensible or remove the section

Checklist

  • Tests have been added/updated to cover changes in this PR

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Dec 22, 2023
@npfitz npfitz force-pushed the 35454-Greeting-Page-Flashing branch from f8316da to f64de02 Compare January 12, 2024 17:43
@npfitz npfitz added the backport Automatically create PR on current release branch on merge label Jan 12, 2024
@npfitz npfitz marked this pull request as ready for review January 12, 2024 17:59
Copy link

Codenotify: Notifying subscribers in CODENOTIFY files for diff 2c7eb30...f64de02.

Notify File(s)
@ranquild frontend/src/metabase/home/components/HomePage/HomePage.tsx

Copy link

replay-io bot commented Jan 12, 2024

StatusComplete ↗︎
Commitc5f6ae0
Results
⚠️ 2 Flaky
  • should allow non-user to unsubscribe from subscription
      Timed out retrying after 4000ms: Expected to find content: 'You've unsubscribed non-user@example.com from the "Orders in a dashboard" alert.' but never did.
  • when set through the filter widget
      Timed out retrying after 4000ms: Unable to find an element with the text: 114.42. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.
      Ignored nodes: comments, <script />, <style />
      <div
        class="Card rounded flex flex-column hover-parent hover--visibility emotion-1iic5sh ev4uvk22"
        data-testid="dashcard"
      >
        <div
          class="flex-full overflow-hidden emotion-13ku56z e12a6fu73"
          data-testid="visualization-root"
        >
          <div
            class="emotion-1wh8hcg e12a6fu72"
          >
            <div
              class="estm9c10 emotion-7ezmz3 e1uflaeq4"
              data-testid="legend-caption"
            >
              <div
                class="fullscreen-normal-text fullscreen-night-text emotion-1v7ana5 e1uflaeq3"
              >
                <div
                  class="emotion-11a46nc e19wb1qy0"
                  data-testid="legend-caption-title"
                >
                  SQL with ID filter
                </div>
              </div>
              <div
                class="emotion-1bpdelk e1uflaeq0"
              >
                <div
                  class="emotion-homk6g e163ydnr0"
                >
                  <span
                    class="emotion-s5xdrg e12a6fu71"
                  >
                    <div
                      class="saving-dom-image-hidden e6vrdbj0 emotion-e7llpw ehi2edu0"
                    >
                      <svg
                        aria-label="ellipsis icon"
                        class="Icon Icon-ellipsis hover-child hover-child--smooth"
                        data-testid="dashcard-menu"
                        fill="currentcolor"
                        height="16"
                        role="img"
                        viewBox="0 0 16 16"
                        width="16"
                        xmlns="http://www.w3.org/2000/svg"
                      >
                        <path
                          d="M4.5 8A1.25 1.25 0 1 1 2 8a1.25 1.25 0 0 1 2.5 0zm4.75 0a1.25 1.25 0 1 1-2.5 0 1.25 1.25 0 0 1 2.5 0zm3.5 1.25a1.25 1.25 0 1 0 0-2.5 1.25 1.25 0 0 0 0 2.5z"
                        />
                      </svg>
                      <span
                        class="hide"
                      />
                    </div>
                  </span>
                </div>
              </div>
            </div>
          </div>
          <div
            class="flex flex-column flex-full"
            data-card-key="80"
          >
            <div
              class="CardVisualization flex-full flex-basis-none emotion-mwc1qk engs4hs8"
            >
              <div
                class="emotion-xjm3kn engs4hs7"
              >
                <div
                  class="scroll-show scroll-show--hover emotion-1vibyd9 engs4hs6"
                >
                  <table
                    class="fullscreen-normal-text fullscreen-night-text emotion-1qr0wla engs4hs5"
                  >
                    <thead>
                      <tr>
                        <th
                          data-testid="column-header"
                        >
                          <button
                            class="emotion-6rz6bl engs4hs3"
                          >
                            <div
                              class="emotion-11a46nc e19wb1qy0"
                            >
                              ID
                            </div>
                            <svg
                              aria-label="chevronup icon"
                              class="Icon Icon-chevronup emotion-137pcyc engs4hs4"
                              fill="currentcolor"
                              height="8"
                              role="img"
                              viewBox="0 0 16 16"
                              width="8"
                              xmlns="http://www.w3.org/2000/svg"
                            >
                              <path
                                d="M1.47 11.53a.75.75 0 0 0 1.06 0L8 6.06l5.47 5.47a.75.75 0 1 0 1.06-1.06l-6-6a.75.75 0 0 0-1.06 0l-6 6a.75.75 0 0 0 0 1.06z"
                              />
                            </svg>
                          </button>
                        </th>
                        <th
                          data-testid="column-header"
                        >
                          <button
                            class="emotion-6rz6bl engs4hs3"
                          >
                            <div
                              class="emotion-11a46nc e19wb1qy0"
                            >
                              USER_ID
                            </div>
                            <svg
                              aria-label="chevronup icon"
                              class="Icon Icon-chevronup emotion-137pcyc engs4hs4"
                              fill="currentcolor"
                              height="8"
                              role="img"
                              viewBox="0 0 16 16"
                              width="8"
                              xmlns="http://www.w3.org/2000/svg"
                            >
                              <path
                                d="M1.47 11.53a.75.75 0 0 0 1.06 0L8 6.06l5.47 5.47a.75.75 0 1 0 1.06-1.06l-6-6a.75.75 0 0 0-1.06 0l-6 6a.75.75 0 0 0 0 1.06z"
                              />
                            </svg>
                          </button>
                        </th>
                        <th
                          data-testid="column-header"
                        >
                          <button
                            class="emotion-6rz6bl engs4hs3"
                          >
                            <div
                              class="emotion-11a46nc e19wb1qy0"
                            >
                              PRODUCT_ID
                            </div>
                            <svg
                              aria-label="chevronup icon"
                              class="Icon Icon-chevronup emotion-137pcyc engs4hs4"
                              fill="currentcolor"
                              height="8"
                              role="img"
                              viewBox="0 0 16 16"
                              width="8"
                              xmlns="http://www.w3.org/2000/svg"
                            >
                              <path
                                d="M1.47 11.53a.75.75 0 0 0 1.06 0L8 6.06l5.47 5.47a.75.75 0 1 0 1.06-1.06l-6-6a.75.75 0 0 0-1.06 0l-6 6a.75.75 0 0 0 0 1.06z"
                              />
                            </svg>
                          </button>
                        </th>
                        <th
                          data-testid="column-header"
                        >
                          <button
                            class="emotion-6rz6bl engs4hs3"
                          >
                            <div
                              class="emotion-11a46nc e19wb1qy0"
                            >
                              SUBTOTAL
                            </div>
                            <svg
                              aria-label="chevronup icon"
                              class="Icon Icon-chevronup emotion-137pcyc engs4hs4"
                              fill="currentcolor"
                              height="8"
                              role="img"
                              viewBox="0 0 16 16"
                              width="8"
                              xmlns="http://www.w3.org/2000/svg"
                            >
                              <path
                                d="M1.47 11.53a.75.75 0 0 0 1.06 0L8 6.06l5.47 5.47a.75.75 0 1 0 1.06-1.06l-6-6a.75.75 0 0 0-1.06 0l-6 6a.75.75 0 0 0 0 1.06z"
                              />
                            </svg>
                          </button>
                        </th>
                        <th
                          data-testid="column-header"
                        >
                          <button
                            class="emotion-6rz6bl engs4hs3"
                          >
                            <div
                              class="emotio...
2214 Passed

@npfitz npfitz requested a review from a team January 12, 2024 18:31
Copy link
Contributor

@iethree iethree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 this feels much nicer

);

//Ensure that when the loading header is gone, we are no longer on the home page
cy.findByTestId("home-page", { timeout: 0 }).should("not.exist");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I like this optimization

@npfitz npfitz merged commit c5fb372 into master Jan 15, 2024
187 of 188 checks passed
@npfitz npfitz deleted the 35454-Greeting-Page-Flashing branch January 15, 2024 20:34
Copy link

@npfitz Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

github-actions bot pushed a commit that referenced this pull request Jan 15, 2024
* Show Loading state while checking dashboard redirect

* adding e2e test
metabase-bot bot added a commit that referenced this pull request Jan 15, 2024
* Show Loading state while checking dashboard redirect

* adding e2e test

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Greeting page briefly loads before redirecting to custom homepage
2 participants