Skip to content

1910222037440

Pre-release
Pre-release
Compare
Choose a tag to compare
@ampprojectbot ampprojectbot released this 23 Oct 16:47
1910222037440
7a0a66f
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Version: 1910222037440

Baseline: 1910161528000

  • 🏗 Update @percy/percy-puppeteer to v1.x (#25176)
  • SwG Release 0.1.22.78 (#25202)
  • Separate experiments object block from experiment.js code (#25169)
  • Navigation: Fix IE a11y patch & clean up (#25177)
  • 📦 Update dependency gulp-prettier to v2.2.0 (#25175)
  • 📦 Update dependency bluebird to v3.7.1 (#25051)
  • 📦 Update babel monorepo (#24969)
  • 📦 Update dependency terser to v4.3.9 (#25054)
  • 📦 Update dependency eslint-plugin-jsdoc to v15.12.0 (#24984)
  • 📦 Update dependency lolex to v5.1.1 (#25033)
  • 📦 Update dependency gulp-ava to v3 (#25036)
  • 🚮 Delete testIE mode because Custom Elements v1 Polyfill was launched (#25167)
  • 🐛Transition to submit-error on SSR error responses (#25133)
  • amp-accordion: Propagate trust from action->event (#25110)
  • Upgrade node from ^10.0.0 to ^12.0.0 (#25161)
  • amp-sidebar: Propagate trust from action->event (#25095)
  • 📦 Update dependency karma to v4.4.1 (#25142)
  • 🏗 Pre-build JS files and extensions loaded by core runtime during gulp startup (#25155)
  • 🐛 Fix escaping of backticks in json configuration (#25156)
  • ✨ Launch Custom Elements v1 Polyfill (#25141)
  • 📦 Update dependency amphtml-validator to v1.0.26 (#25146)
  • Adds some more people to collaboration OWNERS (#25151)
  • 🏗 Fix gulp prettify when there's nothing to check (#25152)
  • allow firebase for 3p frames (#25092)
  • 🐛✅ -> to fix test flake (#25145)
  • 📦 Update dependency mocha to v6.2.2 (#25138)
  • Validator rollup (#25134)
  • 🏗🚀 Significantly speed up gulp prettify (#25140)
  • Avoid swipe to dismiss errors being logged. (#25139)
  • 🐛 fix getPreviousPageId (#25131)
  • 🏗 Fix watch mode on e2e tests (#25136)
  • Story branching support for sidebar links. (#24968)
  • SwG Release 0.1.22.77 (#25135)
  • Remove requirement from amp-analytics that we're inabox for parentPostMessage. (#24902)
  • 🏗 Add VS Code auto-formatting support for JS and non-JS files (#25117)
  • SwG release 0.1.22.76 (#25088)
  • 🐛Fixes ima-video race condition and percentage played (#24900)
  • ✨ Add Comscore Translated Consent Parameter (#24965)
  • OWNERS set for video files in src (#25120)
  • Improve text-matching algorithm of amp-viewer-integration/findtext.js. (#23853)
  • remove sp path from extension location (#25073)
  • Set @alanorozco and @wassgha as owners of video service (#24908)
  • Fix syntax for spec/email/OWNERS (#25114)
  • 🏗 Fix team names in OWNERS of tools (#25096)
  • Add wg-amp4email as OWNERS for spec/email (#25062)
  • 🏗 Makes Yuan an owner of SwG extension (#25087)
  • ✅ Deflakes SwG E2E Test (#25065)
  • 🐛Fix subdomain handling in idealmedia widgets (#24579)
  • 🏗 Replace globs-to-files with globby (#25097)
  • 🏗 Add a --local_changes mode to gulp prettify (#25093)
  • 📦 Update dependency karma to v4.4.0 (#25090)
  • 🏗 Upgrade the browsers we use on Sauce Labs (#24735)
  • 🏗 Enable gulp prettify on several non-JS files (and auto-fix them) (#25085)
  • Fix typo in AMP Variable Substitutions documentation (#24818)
  • 🏗✨ Check non-JS files for formatting errors using prettier during local and Travis PR checks (#25057)
  • 🏗 Update all markdown files to be owned by wg-outreach (#25075)
  • 🐛Fix progress bar bug with more comprehensive advancement checks (#24947)
  • Validator roll up (#25072)
  • Add Empower to amp-ad networks (#24949)
  • Implement an amp-mega-menu component (#24822)
  • ✨Add "conative" ad network support to amp-ad (#25038)
  • ✨PWA: Expose amp-bind getState and setState (#25011)
  • 📦 Update dependency markdown-link-check to v3.8.0 (#25068)
  • 🐛Restrict checking cached ampDoc reference to AMP elements. (#25000)
  • 🐛Add CSS rule to hide amp-loaders from stories (#24895)
  • ✨ Update INFOnline analytics vendor configuration (#25053)
  • Skip flaky subscriptions e2e test (#25059)
  • Disable amp-animation for shadow for flakiness (#25056)
  • 📦 Update dependency geckodriver to v1.19.0 (#25046)
  • ✨ Implemented binding for amp-audio and amp-video (#24773)
  • SwG Release 0.1.22.75 (#25043)
  • Update amp-analytics owner file (#25044)
  • 🏗 Report and store the bundle size of alternate runtime and extension files (#25042)
  • 🐛Consider *.gmail.com trusted viewer domains (#25027)
  • Amp animation e2e test (#24747)
  • 🏗 Lando: Install dependencies needed for building validator (#24836)
  • 📦 Update dependency chromedriver to v77 (#24568)
  • 🏗 Add danielrozenberg as OWNER of sauce_connect (#24985)
  • Fix typo (#24048)
  • 📦 Update dependency autoprefixer to v9.6.5 (#25030)
  • 📦 Update dependency jsdom to v15.2.0 (#25034)
  • 📦 Update dependency lolex to v5.0.1 (#25009)
  • Hide type="carousel" arrows after swiping to a new slide. (#25010)
  • 📦 Update dependency typescript to v3.6.4 (#24996)
  • Generate HTMLSourceElement from the src attribute. (#25003)
  • 🐛Fix script tag validation issues with amp-experiment usage on amp-story (#24909)
  • Better console message when message.source is null (#24977)
  • amp-bind: Allow String.replace() #24659 (#24963)
  • Add reviewers team to root OWNERS file (#24988)
  • 🏗 Don't use eslint to check OWNERS files (#24993)
  • Remove the branching share page checkbox. (#24980)
  • Remove story multiple advancement config. (#24981)
  • Story branching navigation path fixes. (#24979)
  • [DRAFT] (#23928)
  • 🏗 A few minor OWNERS fixes (#24971)
  • 📖 Make PR template text invisible even when it is inadvertently included in a PR description (#24966)
  • Validator rollup (#24986)
  • swg release 0.1.22.74 (#24941)
  • Remove extra css for amp-ad-exit e2e test (#24732)
  • Revert "📦 Update dependency selenium-webdriver to v4.0.0-alpha.5 (#24405)" (#24976)
  • Update css/ OWNERS. (#24960)
  • Update amp-story.md (#24709)
  • 🐛loader: Disable caching of LoaderService Promise (#24939)
  • Updates amp-story attributes to be formatted as a table. (#24962)
  • 🏗 Remove --eager_build flag from gulp (#24948)
  • Remove Error Reporting From karmaBrowserComplete_ When Zero Tests Found (#24959)
  • Add documentation for amp-ad-custom integration. (#24585)
  • Remove unnecessary .json from bundle-size /store URL (#24958)
  • ✨ Add tracdelight AMP ad integration (#23124)
  • Switch bundle-size store function to the JSON API endpoint (#24955)
  • Extend experiments A and B by 1 month (#24951)
  • 🏗 Add OWNERS files for all build-system/ sub-directories (#24945)
  • Change 'encrypted' attr to 'ciphertext'. (#24937)
  • 🏗 Use config.lintGlobs instead of a hard-coded list of globs (#24946)
  • 🏗 Lint OWNERS files with gulp lint (#24943)
  • AMP4Email: Disallow "latest" extension scripts (#24854)
  • Update Prettier to auto-format all owners files (#24938)
  • Renaming the caches file.
  • Move caches.json to build-system/global-config/
  • 🏗 Convert all OWNERS.yaml files to JSON5 format (#24934)
  • 📦 Update dependency selenium-webdriver to v4.0.0-alpha.5 (#24405)
  • 📦 Update dependency lolex to v5 (#24924)
  • 📦 Update dependency terser to v4.3.8 (#24919)
  • 📦 Update dependency fetch-mock to v7.5.1 (#24918)
  • 📦 Update dependency autoprefixer to v9.6.4 (#24916)
  • 📦 Update dependency eslint-plugin-jsdoc to v15.9.10 (#24899)
  • 📦 Update dependency eslint-config-prettier to v6.4.0 (#24920)
  • 🐛 Update WorkerDOM to 0.21.0 (#24846)
  • Restore visibility methods as restricted in the viewer for viewer-integration fixes (#24913)
  • Remove resize logs and enable activation for resize decisions (#24860)
  • Restore visibility methods as restricted in the viewer for viewer-integration fixes (#24913)
  • 📦 Update dependency terser to v4.3.6 (#24912)
  • AdGlare Ad Server: Added a cache buster to the URL. (#24877)
  • url: Recognize + as %20 when parsing query string (#24626)
  • 🏗♻️ Reorganize files in the amphtml root directory (#24896)
  • 📖clone documentation for sidebar v2 (#24813)
  • ♻️Minor refactor for amp-orientation-observer (#24812)
  • 📦 Update dependency eslint-plugin-jsdoc to v15.9.8 (#24875)
  • 📦 Update react monorepo to v16.10.2 (#24893)
  • ♿Add aria-labels to story system-layer buttons (#24842)
  • Fixes accidental ownership swap (#24886)
  • 📦 Update dependency json5 to v2.1.1 (#24867)
  • 🏗♻️ Reorganize all files in build-system/ (#24890)
  • 📖 Remove confusing emoji codes from PR template (#24892)
  • 🏗🐛 Resolve paths in window-property-name custom eslint rule (#24891)
  • Expand tap target size for page attachment close button (#24887)
  • Revert "Revert "Stop reporting gzipped compressed size in the bundle-size task (#24418)" (#24882)" (#24888)
  • Disallow amp-youtube in amp4ads (#24864)
  • Updates our contributing docs to refer to owners-assignment bot (#24885)
  • 🏗 Regenerate yarn.lock (#24884)
  • ♻️wg-ui-and-a11y to own externally contributed UI related components (#24828)
  • Revert "Stop reporting gzipped compressed size in the bundle-size task (#24418)" (#24882)
  • Fix wildcard owners (#24870)
  • Ramp up experiment for AdSense ad size optimization to 1% of AMP traffic. (#24413)
  • Stop reporting gzipped compressed size in the bundle-size task (#24418)
  • ⚡️Add all WGs as owners for common folders (#24863)
  • 🏗 Reduce gulp dist parallelism on Travis, add some logging (#24662)
  • Make wg-approvers owner of experiments. (#24853)
  • Correct wg-analytics reference in owners file (#24865)
  • add trailing / (slash) to endpoint to return gif for GET pixel request (#23958)
  • ✨ 📖 Vendor config warning message (#24777)
  • 📦 Update dependency karma-chrome-launcher to v3 (#24855)
  • 🐛 Update WorkerDOM to 0.21.0 (#24846)
  • 📦 Update dependency google-closure-library to v20190929 (#24861)
  • Ramp up experiment for using responsive amp-ad in amp-auto-ads to 5%. (#24820)
  • 📦 Update dependency eslint-plugin-jsdoc to v15.9.7 (#24852)
  • Add SeedingAlliance support to amp-ad (#24795)
  • Fix broken link to LocalizedStringId in _locales/ README (#24859)
  • Validator rollup 401@960 (#24857)
  • Fixed parallax example (#24823)
  • Add alert role to sound announcements for screen reader support (#24840)
  • 📦 Update dependency google-closure-compiler to v20190929 (#24847)
  • Document setState/getState in amp-script (#24624)
  • 🐛Update Ooyala player version from Sandbox to Prod (#24738)
  • Fix subdomain handling in lentainform widgets (#24546)
  • ✨ Lentainform. this change is very important (#23942)
  • noContent on destroy player (#24427)
  • Ramp up inconsistent responsive height selection fix experiment to 5%. (#24819)
  • babel-preset-modules should be a devDependency (#24845)
  • Story Ads: propagate visible attr to transformed body. (#24831)
  • ♿Add alert role to toast for screen reader support (#24825)
  • 📦 Update dependency bluebird to v3.7.0 (#24838)
  • 📦 Update dependency pumpify to v2.0.1 (#24837)
  • 📦 Update dependency magic-string to v0.25.4 (#24811)
  • 📦 Update dependency mocha to v6.2.1 (#24792)
  • 📦 Update dependency fetch-mock to v7.4.0 (#24791)
  • 📦 Update dependency eslint to v6.5.1 (#24790)
  • 📦 Update dependency commander to v3.0.2 (#24752)
  • 📦 Update dependency eslint-plugin-jsdoc to v15.9.5 (#24751)
  • 📦 Update babel monorepo to v7.6.2 (#24697)
  • Fix reloadExtension for amp-viewer-integration (#24730)
  • Cleanup stale owners file entries (#24835)
  • Implement ad size optimization for AdSense. (#24375)
  • gulp integration build command consistency (#24830)
  • Enable amp-list[diffable] in other AMP specs. (#24839)

Breakdown by component

ads ✨Add "conative" ad network support to amp-ad (#25038)
amp-3d-gltf Validator rollup (#25134)
amp-3q-player Validator rollup (#25134)
amp-access Validator rollup (#25134)
amp-accordion amp-accordion: Propagate trust from action->event (#25110) Validator rollup (#25134)
amp-ad Validator rollup (#25134) ✨Add "conative" ad network support to amp-ad (#25038)
amp-ad-custom Validator rollup (#25134) Formatting a code-block (#25109) Fixing typo (#25101)
amp-ad-exit Validator rollup (#25134)
amp-analytics ✨ Update INFOnline analytics vendor configuration (#25053) Update amp-analytics owner file (#25044)
amp-anim Validator rollup (#25134)
amp-animation Validator rollup (#25134) Disable amp-animation for shadow for flakiness (#25056)
amp-app-banner Validator rollup (#25134)
amp-audio Validator rollup (#25134)
amp-autocomplete Validator rollup (#25134)
amp-base-carousel Validator rollup (#25134)
amp-bind ✨PWA: Expose amp-bind getState and setState (#25011)
amp-bodymovin-animation Validator rollup (#25134)
amp-brid-player Validator rollup (#25134)
amp-brightcove Validator rollup (#25134)
amp-byside-content Validator rollup (#25134)
amp-call-tracking Validator rollup (#25134)
amp-carousel Validator rollup (#25134)
amp-connatix-player Validator rollup (#25134)
amp-consent Validator rollup (#25134)
amp-dailymotion Validator rollup (#25134)
amp-date-countdown Validator rollup (#25134)
amp-date-display Validator rollup (#25134)
amp-date-picker Validator rollup (#25134)
amp-form 🐛Transition to submit-error on SSR error responses (#25133)
amp-lightbox-gallery Avoid swipe to dismiss errors being logged. (#25139)
amp-mega-menu 🏗✨ Check non-JS files for formatting errors using `prettier` during local and Travis PR checks (#25057)
amp-sidebar amp-sidebar: Propagate trust from action->event (#25095)
amp-story 🐛 fix getPreviousPageId (#25131)
amp-story-auto-ads Fix bad script in amp story auto ads docs (#25018)
amp-subscriptions-google 🏗 Makes Yuan an owner of SwG extension (#25087) ✅ Deflakes SwG E2E Test (#25065) Skip flaky subscriptions e2e test (#25059)
validator Publish amphtml-validator version 1.0.27 (#25204) Removed references to deleted amp.validator.categorizeError. Upgrade amphtml-validator version to 1.0.26 (#25162)

Upgrade node from ^10.0.0 to ^12.0.0 (#25161)
To match node v12 being the active LTS version as of 10/21/19: https://nodejs.org/en/about/releases/
remove preinstall script for node.js (#25153)
@rsimha

In #15602 check_package_manager.js was added to validator/nodejs/packages.json. When publishing the npm module (npm publish --access public) we ran into an issue that this file wasn't included and it couldn't be installed (see below for error). Removing the script allowed us to publish. However I'm unsure if that is the final outcome desired given the PR that introduced it. @rsimha do you know if this file is necessary or only useful for yarn incantations and not npm?

user@honeybadgerdontcare:~/github/amphtml/validator$ npm install amphtml-validator@1.0.24

> amphtml-validator@1.0.24 preinstall /github/amphtml/validator/node_modules/amphtml-validator
> node ../../build-system/common/check-package-manager.js

internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module '/github/amphtml/validator/build-system/common/check-package-manager.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! amphtml-validator@1.0.24 preinstall: `node ../../build-system/common/check-package-manager.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the amphtml-validator@1.0.24 preinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /.npm/_logs/2019-10-18T22_45_40_386Z-debug.log

Validator roll up (#25072)

  • cl/274603953 Revision bump for #24854
  • cl/274639638 Revision bump for #24909
Assets 2