ArmPkg HowToContributeSct

Jordan Justen edited this page Sep 4, 2014 · 1 revision
Clone this wiki locally

How To contribute to SCT

Pre-requirements:

- Having an account on Github
- Being a member of the UEFI Forum. The membership list is available here: http://uefi.org/members
- Requesting access to UEFI-SCT Github project: https://github.com/UEFI/UEFI-SCT
1.Fork the Github repository
center

After forking the repository, it should appear under your own Github account:
center

2. Clone the repository on your host machine:

$ git clone https://github.com/oliviermartin/UEFI-SCT.git

3. Create your branch

$ git checkout -b om/installsct-fix-backup origin/master

After making your first change, you can see the state of your local GIT repository:

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   Application/InstallSct/InstallSct.c

no changes added to commit (use "git add" and/or "git commit -a")
     //
-    // Exist. Need to remove or backup
-    //
-    if (StriCmp (InputBuffer, L"a") == 0) {
-      //
-      // Backup all
-      //
-      Status = BackupDirFile (TmpName);
-      if (EFI_ERROR (Status)) {
-        FreePool (TmpName);
-        return Status;
-      }
-
-      FreePool (TmpName);
-      continue;
-    } else if (StriCmp (InputBuffer, L"l") == 0) {
-      //
-      // Remove all
-      //
-      Status = RemoveDirFile (TmpName);
-      if (EFI_ERROR (Status)) {
-        FreePool (TmpName);
-        return Status;
-      }
-
-      FreePool (TmpName);
-      continue;
-    }
-
-    //
     // User must input a selection
     //
     while (TRUE) {

Once happy by your changes, you can add them to your future GIT commit:

$ git add Application/InstallSct/InstallSct.c

And commit it!

$ git commit

After having completed all your changes, you need to push them to the your GIT repository:

$ git push github-olivier om/installsct-fix-backup
Username for 'https://github.com': oliviermartin
Password for 'https://oliviermartin@github.com': 
Counting objects: 39, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (19/19), done.
Writing objects: 100% (19/19), 2.92 KiB | 0 bytes/s, done.
Total 19 (delta 13), reused 0 (delta 0)
To https://github.com/oliviermartin/UEFI-SCT.git
 * [new branch]      om/installsct-fix-backup -> om/installsct-fix-backup

The new branch should now be visible into your fork of UEFI-SCT project:
center

To propose your changes to the UEFI-SCT project to be merged, send a pull-request by clicking on 'Compare & pull request'.
center

After sending the pull request, the request should appear into the 'UEFI-SCT' project 'pull request' list.
center

Details of the 'pull-request' can be shown by clicking on the entry: center

User can review changes and leave comments:
center