Client Skill Init Idempotency

Client Skill Init Idempotency

Status

client-skill-init-idempotency is source-present in the docs checkout, current stable/B74.1, current B74.2, B69/B74, the live origin/feat/client-fps branch and historical release-line evidence, with Arma Soldier/non-Soldier/respawn smoke still pending as of the 2026-06-24 branch refresh. Repo docs branch HEAD@1df5200fa485 is unchanged from b2738971 for checked skill-init paths; docs/source keeps one Skill_Init.sqf call in client init at :547 and preserves the later WFBE_SK_FNC_Apply call at :571 in both maintained roots. Current stable/B74.1 origin/master@f8a76de34 carries the one-call/apply shape at :805 / :828 in both roots. Current B74.2 origin/claude/b74.2-aicom@21b62b04 keeps the same order, line-drifting source Chernarus to :828 / :851 while maintained Vanilla stays at :805 / :828. Current B69 origin/claude/b69@8d465fce and B74 origin/claude/b74-aicom-spend@b23f557f carry :805 / :828; live origin/feat/client-fps@709258e7 keeps one call before apply with Chernarus :613 / :636 and Vanilla :583 / :606. Historical release-line commits a96fdda2 and 7ff18c49 carry the single-init shape, but current origin exposes no live release/* head. Current Miksuu b8389e748243, origin/perf/quick-wins@0076040f and historical origin/feat/ai-commander@c20ce153 still duplicate Skill_Init.

What I Read

• Missions/[55-2hc]warfarev2_073v48co.chernarus/Client/Init/Init_Client.sqf
• Missions/[55-2hc]warfarev2_073v48co.chernarus/Client/Module/Skill/Skill_Init.sqf
• Missions/[55-2hc]warfarev2_073v48co.chernarus/Client/Module/Skill/Skill_Apply.sqf
• Missions/[55-2hc]warfarev2_073v48co.chernarus/Client/Functions/Client_PreRespawnHandler.sqf
• Missions/[55-2hc]warfarev2_073v48co.chernarus/Common/Init/Init_CommonConstants.sqf
• Maintained Vanilla Takistan Client/Init/Init_Client.sqf after LoadoutManager propagation.
• Current stable/B74.1 origin/master@f8a76de34, previous B74.2 d472da6a, current B74.2 origin/claude/b74.2-aicom@21b62b04, origin/claude/b69@8d465fce, origin/claude/b74-aicom-spend@b23f557f and origin/feat/client-fps@709258e7 versions of the Chernarus and maintained Vanilla client init files for current branch status.
• Current Miksuu b8389e748243, origin/perf/quick-wins@0076040f, historical origin/feat/ai-commander@c20ce153 and historical release-line commits a96fdda2 / 7ff18c49 for old-shape and release-line contrast.

Branch Status

Current branch status is:

Branch / source	Evidence	Meaning
Repo docs/source HEAD@1df5200fa485, source Chernarus	Client/Init/Init_Client.sqf:547, :551, :571; b2738971..HEAD empty for checked skill-init paths	One Skill_Init.sqf call remains before default gear selection, and (player) Call WFBE_SK_FNC_Apply still runs later.
Repo docs/source HEAD@1df5200fa485, maintained Vanilla Takistan	Client/Init/Init_Client.sqf:547, :551, :571; b2738971..HEAD empty for checked skill-init paths	Vanilla matches the source Chernarus single-init shape after propagation.
Current stable/B74.1 origin/master@f8a76de34, Chernarus and maintained Vanilla	Client/Init/Init_Client.sqf:805, :809, :828	Stable/B74.1 carries the single-init shape in both maintained roots. Arma smoke remains pending.
Current B74.2 origin/claude/b74.2-aicom@21b62b04, source Chernarus	Client/Init/Init_Client.sqf:828, :832, :851	B74.2 keeps one-call/apply order; origin/master..B74.2 and d472da6a..21b62b04 touch source-Chernarus Init_Client.sqf among checked skill paths but do not add a duplicate skill init.
Current B74.2 origin/claude/b74.2-aicom@21b62b04, maintained Vanilla Takistan	Client/Init/Init_Client.sqf:805, :809, :828	Vanilla stays current-stable-shaped for this lane; no maintained Vanilla B74.2 payload changes the checked skill-init order.
Current B69 origin/claude/b69@8d465fce, Chernarus and maintained Vanilla	Client/Init/Init_Client.sqf:805, :809, :828	B69 carries the single-init shape in both maintained roots. Arma smoke remains pending.
Current B74 origin/claude/b74-aicom-spend@b23f557f, Chernarus and maintained Vanilla	Client/Init/Init_Client.sqf:805, :809, :828	B74 matches B69 for this client-init shape. Arma smoke remains pending.
Live origin/feat/client-fps@709258e7, source Chernarus	Client/Init/Init_Client.sqf:613, :617, :636	The branch touches client init but keeps one Skill_Init.sqf call before apply.
Live origin/feat/client-fps@709258e7, maintained Vanilla Takistan	Client/Init/Init_Client.sqf:583, :587, :606	Vanilla keeps the same one-call/apply order with branch-specific line drift.
Historical release-line a96fdda2, Chernarus and maintained Vanilla	Client/Init/Init_Client.sqf:563, :567, :586	Historical release evidence carries the single-init shape, but no live release/* head was exposed on 2026-06-22.
Historical release-line 7ff18c49, Chernarus and maintained Vanilla	Client/Init/Init_Client.sqf:564, :568, :587	Later local release-line evidence also carries the single-init shape; recheck if a release ref is restored.
Current Miksuu b8389e748243, Chernarus and maintained Vanilla	Client/Init/Init_Client.sqf:560, :564, :584-585	Still duplicates Skill_Init.sqf before applying skills.
origin/perf/quick-wins 0076040f, Chernarus and maintained Vanilla	Client/Init/Init_Client.sqf:561, :565, :585-586	Still duplicates Skill_Init.sqf; perf does not carry this cleanup.
Historical origin/feat/ai-commander c20ce153, Chernarus and maintained Vanilla	Client/Init/Init_Client.sqf:561, :565, :585-586	Still duplicates Skill_Init.sqf; AI-commander branch work does not carry this cleanup.
Historical release head 3282ff3f, source Chernarus	Client/Init/Init_Client.sqf:565, :589-590	Historical release spot-check: still duplicated the init. Superseded by later release heads.
Historical release head 7195b331, Chernarus and maintained Vanilla	Client/Init/Init_Client.sqf:564, :587	Historical first release head with the single-init shape; superseded by later release-line commits.
Shared skill init module	Client/Module/Skill/Skill_Init.sqf:10; Soldier cap mutation at docs/source/client-fps/Miksuu/perf :49, current stable/B74.1/B74.2/B69/B74 Chernarus :69, current stable/B74.1/B74.2/B69/B74 Vanilla :64, local release-line 7ff18c49 :51	Compiles WFBE_SK_FNC_Apply, sets WFBE_SK_V_Type, and multiplies local WFBE_C_PLAYERS_AI_MAX by 1.5 for Soldier class.
Shared common constant	Common/Init/Init_CommonConstants.sqf:819	Default WFBE_C_PLAYERS_AI_MAX is 16.
Respawn path	Client/Functions/Client_PreRespawnHandler.sqf:5 on all checked refs	Respawn reapply calls WFBE_SK_FNC_Apply without rerunning Skill_Init.sqf.

Because the Soldier-cap mutation (docs/source Skill_Init.sqf:69; current stable/B74.2 Chernarus :69, Vanilla :64) has no applied flag or base-value reset, a Soldier client could compound the local AI cap from 16 -> 24 -> 36 during one duplicate-init path. The likely intended one-time Soldier boost is 16 -> 24.

Patch Shape

The source mission patch removes only the second Skill_Init.sqf call:

• Keep Client/Init/Init_Client.sqf:547 so WFBE_SK_V_Type exists before class-based default gear selection.
• Keep (player) Call WFBE_SK_FNC_Apply in the later skill block so the selected class still gets skill effects/actions before play.
• Do not change Skill_Init.sqf internals, because a single init call is enough for the current path.
• Propagate with Tools/LoadoutManager so Vanilla Takistan matches source.

Changed source files:

• Missions/[55-2hc]warfarev2_073v48co.chernarus/Client/Init/Init_Client.sqf

Propagated maintained Vanilla file:

• Missions_Vanilla/[61-2hc]warfarev2_073v48co.takistan/Client/Init/Init_Client.sqf

Validation

Source/Vanilla validation done:

• Chernarus Init_Client.sqf has exactly one Skill_Init.sqf call and one later WFBE_SK_FNC_Apply call.
• Vanilla Takistan has the same single-init shape after the propagation run.
• Skill_Init.sqf still compiles WFBE_SK_FNC_Apply.
• Client_PreRespawnHandler.sqf still applies skill effects on respawn.
• git diff --check passes.
• LoadoutManager/packaging details are branch-sensitive. For future propagation-only reruns, recheck the target branch's root-discovery and A2WASP_SKIP_ZIP support in Source Fix queue before relying on skip-zip behavior.

Pending smoke:

• Local/hosted: join as Soldier and confirm the visible/local AI cap is the one-time boosted value, not the compounded value.
• Local/hosted: join as non-Soldier and confirm normal cap/class behavior.
• Respawn: confirm skill actions/effects are present after death/respawn.
• Dedicated/JIP: confirm no client init regressions in JIP join path.

Modded Mission Note

Modded mission folders also show duplicate Skill_Init.sqf calls in some variants, but those folders are divergent/generated/forked targets and several stale files contain merge-conflict markers. Per repo rules, do not patch modded folders by hand until the generated/forked mission maintenance model is resolved.

Handoff

For Codex/future code owner:

• Keep this as a small client-init cleanup unless future evidence shows another Skill_Init.sqf entrypoint can run more than once.
• If another path must call Skill_Init.sqf, guard only the Soldier AI-cap mutation or store a base cap before applying the 1.5x boost.
• Pair any future modded propagation with the generated mission cleanup work from Tools-And-Build-Workflow, DR-4 and DR-32.

For Claude:

• Good contradiction check: prove whether any UI or respawn path expects cooldown variables from the removed second init call. Current source evidence says respawn uses WFBE_SK_FNC_Apply only.

Continue Reading

• Previous: Performance opportunity sweep
• Next: Feature status register