Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a banner to the top of locales.clj #37877

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Add a banner to the top of locales.clj #37877

merged 1 commit into from
Jan 18, 2024

Conversation

johnswanson
Copy link
Contributor

@johnswanson johnswanson commented Jan 18, 2024 •
edited

Just add a comment warning that the file is autogenerated and not to edit it by hand.

Fixes #36608

@johnswanson
Add a banner to the top of locales.clj
6f53a13 
Just add a comment warning that the file is autogenerated and not to
edit it by hand.
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Jan 18, 2024
@johnswanson johnswanson added the no-backport Do not backport this PR to any branch label Jan 18, 2024
@replay-io replay.io
Copy link

replay-io bot commented Jan 18, 2024 •
edited

StatusIn Progress ↗︎ 50 / 52
Commit7d2db6f
Results
⚠️ 4 Flaky
  • should allow users to provide internal urls 
      Timed out retrying after 4000ms: expected 'http://localhost:4000/' to include '/test-1'
  • should always show the most recent revision (Be a bit smarter about last-edit of dashboards #16559) 
      Timed out retrying after 4000ms: Unable to find an element by: [data-testid="dashboard-history-list"]
Ignored nodes: comments, <script />, <style />
<html
  lang="en"
  translate="no"
>
  <head>
    <meta
      charset="utf-8"
    />
    <meta
      content="IE=edge"
      http-equiv="X-UA-Compatible"
    />
    <meta
      content="width=device-width,initial-scale=1,maximum-scale=1,user-scalable=no"
      name="viewport"
    />
    <meta
      content="noindex"
      name="robots"
    />
    <meta
      content="yes"
      name="apple-mobile-web-app-capable"
    />
    <meta
      content="black-translucent"
      name="apple-mobile-web-app-status-bar-style"
    />
    <link
      href="app/assets/img/apple-touch-icon.png"
      rel="apple-touch-icon"
      sizes="180x180"
    />
    <link
      href="app/assets/img/favicon.ico"
      rel="icon"
    />
    <link
      crossorigin="use-credentials"
      href="app/assets/img/site.webmanifest"
      rel="manifest"
    />
    <meta
      content="#2d89ef"
      name="msapplication-TileColor"
    />
    <meta
      content="app/assets/img/browserconfig.xml"
      name="msapplication-config"
    />
    <meta
      content="#ffffff"
      name="theme-color"
    />
    <meta
      content="default"
      name="apple-mobile-web-app-status-bar-style"
    />
    <meta
      content="/"
      name="base-href"
    />
    <meta
      content="/dashboard/9"
      name="uri"
    />
    <title>
      16559 Dashboard · Dashboard · Metabase
    </title>
    <base
      href="/"
    />
    <link
      href="app/dist/styles.496a179b23d206251307.css"
      rel="stylesheet"
    />
    <link
      href="app/dist/app-main.8c3db53cb80ee9443da7.css"
      rel="stylesheet"
    />
  </head>
  <body>
    <div
      id="root"
    >
      <div
        class="spread emotion-1fttcpj enx0u2k2"
      >
        <header
          aria-label="Navigation bar"
          class="emotion-15xkiw5 es0756t0"
          data-testid="app-bar"
        >
          <div
            class="emotion-1pt930v e4w71dr4"
          >
            <div
              class="emotion-cxb03 e4w71dr3"
            >
              <div
                class="emotion-bjn8wh ehgm33i2"
              >
                <a
                  class="ehgm33i1 emotion-m53806 emeibx70"
                  data-metabase-event="Navbar;Logo"
                  href="/"
                >
                  <svg
                    class="Icon text-brand"
                    data-testid="main-logo"
                    fill="currentcolor"
                    height="32"
                    viewBox="0 0 66 85"
                  >
                    <path
                      d="M46.8253288,70.4935014 C49.5764899,70.4935014 51.8067467,68.1774705 51.8067467,65.3205017 C51.8067467,62.4635329 49.5764899,60.147502 46.8253288,60.147502 C44.0741676,60.147502 41.8439108,62.4635329 41.8439108,65.3205017 C41.8439108,68.1774705 44.0741676,70.4935014 46.8253288,70.4935014 Z M32.8773585,84.9779005 C35.6285197,84.9779005 37.8587764,82.6618697 37.8587764,79.8049008 C37.8587764,76.947932 35.6285197,74.6319011 32.8773585,74.6319011 C30.1261973,74.6319011 27.8959405,76.947932 27.8959405,79.8049008 C27.8959405,82.6618697 30.1261973,84.9779005 32.8773585,84.9779005 Z M32.8773585,70.4935014 C35.6285197,70.4935014 37.8587764,68.1774705 37.8587764,65.3205017 C37.8587764,62.4635329 35.6285197,60.147502 32.8773585,60.147502 C30.1261973,60.147502 27.8959405,62.4635329 27.8959405,65.3205017 C27.8959405,68.1774705 30.1261973,70.4935014 32.8773585,70.4935014 Z M18.9293882,70.4935014 C21.6805494,70.4935014 23.9108062,68.1774705 23.9108062,65.3205017 C23.9108062,62.4635329 21.6805494,60.147502 18.9293882,60.147502 C16.1782271,60.147502 13.9479703,62.4635329 13.9479703,65.3205017 C13.9479703,68.1774705 16.1782271,70.4935014 18.9293882,70.4935014 Z M46.8253288,56.0091023 C49.5764899,56.0091023 51.8067467,53.6930714 51.8067467,50.8361026 C51.8067467,47.9791337 49.5764899,45.6631029 46.8253288,45.6631029 C44.0741676,45.6631029 41.8439108,47.9791337 41.8439108,50.8361026 C41.8439108,53.6930714 44.0741676,56.0091023 46.8253288,56.0091023 Z M18.9293882,56.0091023 C21.6805494,56.0091023 23.9108062,53.6930714 23.9108062,50.8361026 C23.9108062,47.9791337 21.6805494,45.6631029 18.9293882,45.6631029 C16.1782271,45.6631029 13.9479703,47.9791337 13.9479703,50.8361026 C13.9479703,53.6930714 16.1782271,56.0091023 18.9293882,56.0091023 Z M46.8253288,26.8995984 C49.5764899,26.8995984 51.8067467,24.5835675 51.8067467,21.7265987 C51.8067467,18.8696299 49.5764899,16.553599 46.8253288,16.553599 C44.0741676,16.553599 41.8439108,18.8696299 41.8439108,21.7265987 C41.8439108,24.5835675 44.0741676,26.8995984 46.8253288,26.8995984 Z M32.8773585,41.5247031 C35.6285197,41.5247031 37.8587764,39.2086723 37.8587764,36.3517034 C37.8587764,33.4947346 35.6285197,31.1787037 32.8773585,31.1787037 C30.1261973,31.1787037 27.8959405,33.4947346 27.8959405,36.3517034 C27.8959405,39.2086723 30.1261973,41.5247031 32.8773585,41.5247031 Z M32.8773585,10.3459994 C35.6285197,10.3459994 37.8587764,8.02996853 37.8587764,5.17299969 C37.8587764,2.31603085 35.6285197,0 32.8773585,0 C30.1261973,0 27.8959405,2.31603085 27.8959405,5.17299969 C27.8959405,8.02996853 30.1261973,10.3459994 32.8773585,10.3459994 Z M32.8773585,26.8995984 C35.6285197,26.8995984 37.8587764,24.5835675 37.8587764,21.7265987 C37.8587764,18.8696299 35.6285197,16.553599 32.8773585,16.553599 C30.1261973,16.553599 27.8959405,18.8696299 27.8959405,21.7265987 C27.8959405,24.5835675 30.1261973,26.8995984 32.8773585,26.8995984 Z M18.9293882,26.8995984 C21.6805494,26.8995984 23.9108062,24.5835675 23.9108062,21.7265987 C23.9108062,18.8696299 21.6805494,16.553599 18.9293882,16.553599 C16.1782271,16.553599 13.9479703,18.8696299 13.9479703,21.7265987 C13.9479703,24.5835675 16.1782271,26.8995984 18.9293882,26.8995984 Z"
                      opacity="0.2"
                    />
                    <path
                      d="M60.773299,70.4935014 C63.5244602,70.4935014 65.754717,68.1774705 65.754717,65.3205017 C65.754717,62.4635329 63.5244602,60.147502 60.773299,60.147502 C58.0221379,60.147502 55.7918811,62.4635329 55.7918811,65.3205017 C55.7918811,68.1774705 58.0221379,70.4935014 60.773299,70.4935014 Z M4.98141795,70.3527958 C7.73257912,70.3527958 9.96283591,68.0367649 9.96283591,65.1797961 C9.96283591,62.3228273 7.73257912,60.0067964 4.98141795,60.0067964 C2.23025679,60.0067964 0,62.3228273 0,65.1797961 C0,68.0367649 2.23025679,70.3527958 4.98141795,70.3527958 Z M60.773299,56.0091023 C63.5244602,56.0091023 65.754717,53.6930714 65.754717,50.8361026 C65.754717,47.9791337 63.5244602,45.6631029 60.773299,45.6631029 C58.0221379,45.6631029 55.7918811,47.9791337 55.7918811,50.8361026 C55.7918811,53.6930714 58.0221379,56.0091023 60.773299,56.0091023 Z M32.8773585,56.0091023 C35.6285197,56.0091023 37.8587764,53.6930714 37.8587764,50.8361026 C37.8587764,47.9791337 35.6285197,45.6631029 32.8773585,45.6631029 C30.1261973,45.6631029 27.8959405,47.9791337 27.8959405,50.8361026 C27.8959405,53.6930714 30.1261973,56.0091023 32.8773585,56.0091023 Z M4.98141795,55.8683967 C7.73257912,5...
  • should reset 'another column' comparison when it becomes invalid 
      Timed out retrying after 4000ms: Unable to find an accessible element with the role "menu"
Here are the accessible roles:
  document:
  Name "":
  <body />
  --------------------------------------------------
  banner:
  Name "Navigation bar":
  <header
    aria-label="Navigation bar"
    class="emotion-15xkiw5 es0756t0"
    data-testid="app-bar"
  />
  --------------------------------------------------
  link:
  Name "":
  <a
    class="ehgm33i1 emotion-m53806 emeibx70"
    data-metabase-event="Navbar;Logo"
    href="/"
  />
  Name "test question":
  <a
    class="link emotion-93qn1h emeibx70"
    href="/question/80-test-question"
  />
  Name "database icon Sample Database":
  <a
    class="e1grb1gu2 e14o1rx32 emotion-1nzf543 emeibx70"
    href="/browse/1-sample-database"
  />
  --------------------------------------------------
  button:
  Name "Toggle sidebar":
  <button
    aria-label="Toggle sidebar"
    class="emotion-11d5pqr e11nlem11"
    data-testid="sidebar-toggle"
  />
  Name "New":
  <button
    aria-label="New"
    class="Button esqdtmv1 Button--primary emotion-1vq4u0h emiw9oj2"
    data-metabase-event="NavBar;Create Menu Click"
  />
  Name "gear icon":
  <button
    class="Button e1gdjdn70 Button--onlyIcon p1 emotion-12f2wg1 emiw9oj2"
    color="#696E7B"
  />
  Name "Filter":
  <button
    class="Button hide sm-show eanyi789 Button--large emotion-1nmhoh5 emiw9oj2"
    color="#7172AD"
    data-metabase-event="View Mode; Open Filter Modal"
    data-testid="question-filter-header"
  />
  Name "Summarize":
  <button
    class="Button hide sm-show eanyi789 Button--large emotion-1pcv2d8 emiw9oj2"
    color="#88BF4D"
    data-metabase-event="View Mode; Open Summary Widget"
  />
  Name "notebook icon":
  <button
    class="Button e1yp1x7z0 Button--medium Button--borderless p1 emotion-13dz0zp emiw9oj2"
    data-metabase-event="View Mode; Go to Notebook Mode"
  />
  Name "Refresh":
  <button
    aria-label="Refresh"
    class="Button eanyi780 RunButton eyw0xx60 Button--medium Button--onlyIcon p1 emotion-18xm8tu emiw9oj2"
    result="[object Object]"
  />
  Name "Save":
  <a
    aria-disabled="false"
    class="eanyi7811 emotion-z5l96h emeibx70"
    data-metabase-event="View Mode; Click Save"
    role="button"
  />
  Name "Count chevrondown icon":
  <button
    class="flex-full emotion-deuxar emphlav2"
    data-testid="select-button"
    type="button"
  />
  Name "Previous monthchevrondown icon":
  <li
    aria-describedby="DndDescribedBy-0"
    aria-disabled="true"
    aria-roledescription="sortable"
    class="emotion-1gwq9om e7axzyc0"
    role="button"
    tabindex="0"
  />
  Name "Previous monthchevrondown icon":
  <button
    aria-controls="mantine-sm73kgrky-dropdown"
    aria-expanded="false"
    aria-haspopup="menu"
    class="emotion-UnstyledButton-root emotion-Button-root  edqz25j4 emotion-8722i2"
    data-button="true"
    data-testid="comparisons-widget-button"
    id="mantine-sm73kgrky-target"
    type="button"
  />
  Name "Add comparison":
  <button
    class="emotion-UnstyledButton-root emotion-Button-root edqz25j6 emotion-baukqo"
    data-button="true"
    type="button"
  />
  Name "Done":
  <button
    class="Button e1xvf8sq0 emotion-1kz0nn9 emiw9oj2"
  />
  Name "Refresh":
  <button
    aria-label="Refresh"
    class="Button py2 px3 shadowed RunButton RunButton--hidden RunButton--compact circular eyw0xx60 p1 emotion-1h09fm5 emiw9oj2"
    result="[object Object]"
  />
  Name "All time chevrondown icon":
  <button
    aria-controls="mantine-x55aolo0p-dropdown"
    aria-expanded="false"
    aria-haspopup="dialog"
    class="emotion-UnstyledButton-root emotion-Button-root emotion-1qx6f78"
    data-button="true"
    data-testid="timeseries-filter-button"
    id="mantine-x55aolo0p-target"
    type="button"
  />
  Name "Month chevrondown icon":
  <button
    aria-controls="mantine-861nngurw-dropdown"
    aria-expanded="false"
    aria-haspopup="menu"
    class="emotion-UnstyledButton-root emotion-Button-root emotion-1qx6f78"
    data-button="true"
    data-testid="timeseries-bucket-button"
    id="mantine-861nngurw-target"
    type="button"
  />
  Name "Visualization":
  <button
    class="Button ehoej4n0 Button--medium emotion-389irl emiw9oj2"
    data-testid="viz-type-button"
  />
  Name "gear icon":
  <button
    class="Button ehoej4n0 Button--medium Button--onlyIcon p1 emotion-acwbo4 emiw9oj2"
    data-testid="viz-settings-button"
  />
  Name "Row count":
  <button
    aria-controls="limit-popover"
    aria-haspopup="dialog"
    aria-label="Row count"
    class="emotion-1tkmt1 etsijoa1"
    data-testid="question-row-count"
  />
  Name "share icon":
  <button
    class="Button e109xge0 Button--onlyIcon p1 emotion-33x75d emiw9oj2"
    data-disabled="false"
    data-testid="dashboard-embed-button"
  />
  --------------------------------------------------
  img:
  Name "sidebar_closed icon":
  <svg
    aria-label="sidebar_closed icon"
    class="Icon Icon-sidebar_closed emotion-8s5cwr e11nlem10"
    fill="currentcolor"
    height="24"
    role="img"
    viewBox="0 0 16 16"
    width="24"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "search icon":
  <svg
    aria-label="search icon"
    class="Icon Icon-search emotion-1ug5hwe e1bl69jj2"
    clip-rule="evenodd"
    fill="currentcolor"
    fill-rule="evenodd"
    height="16"
    role="img"
    viewBox="0 0 16 16"
    width="16"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "add icon":
  <svg
    aria-label="add icon"
    class="Icon Icon-add"
    fill="currentcolor"
    height="16"
    role="img"
    viewBox="0 0 16 16"
    width="16"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "gear icon":
  <svg
    aria-label="gear icon"
    class="Icon Icon-gear"
    fill="currentcolor"
    height="16"
    role="img"
    viewBox="0 0 16 16"
    width="16"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "database icon":
  <svg
    aria-label="database icon"
    class="Icon Icon-database emotion-1sylyko e14o1rx31"
    fill="currentcolor"
    height="16"
    role="img"
    viewBox="0 0 16 16"
    width="16"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "notebook icon":
  <svg
    aria-label="notebook icon"
    class="Icon Icon-notebook"
    fill="currentcolor"
    height="16"
    role="img"
    viewBox="0 0 16 16"
    width="16"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "refresh icon":
  <svg
    aria-label="refresh icon"
    class="Icon Icon-refresh"
    clip-rule="evenodd"
    fill="currentcolor"
    fill-rule="evenodd"
    height="16"
    role="img"
    viewBox="0 0 16 16"
    width="16"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "chevrondown icon":
  <svg
    aria-label="chevrondown icon"
    class="Icon Icon-chevrondown emotion-2llozi emphlav1"
    fill="currentcolor"
    height="12"
    role="img"
    viewBox="0 0 16 16"
    width="12"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "chevrondown icon":
  <svg
    aria-label="chevrondown icon"
    class="Icon Icon-chevrondown emotion-1q4vxyr edqz25j1"
    fill="currentcolor"
    height="14"
    role="img"
    viewBox="0 0 16 16"
    width="14"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "refresh icon":
  <svg
    aria-label="refresh icon"
    class="Icon Icon-refresh"
    clip-rule="evenodd"
    fill="currentcolor"
    fill-rule="evenodd"
    height="16"
    role="img"
    viewBox="0 0 16 16"
    width="16"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "arrow_down icon":
  <svg
    aria-label="arrow_down icon"
    class="Icon Icon-arrow_down emotion-1xnw5s4 esf69s78"
    fill="currentcolor"
    height="13"
    role="img"
    viewBox="0 0 16 16"
    width="13"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "chevrondown icon":
  <svg
    aria-label="chevrondown icon"
    class="Icon Icon-chevrondown"
    fill="currentcolor"
    height="16"
    role="img"
    viewBox="0 0 16 16"
    width="16"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "chevrondown icon":
  <svg
    aria-label="chevrondown icon"
    class="Icon Icon-chevrondown"
    fill="currentcolor"
    height="16"
    role="img"
    viewBox="0 0 16 16"
    width="16"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "gear icon":
  <svg
    aria-label="gear icon"
    class="Icon Icon-gear"
    fill="currentcolor"
    height="16"
    role="img"
    viewBox="0 0 16 16"
    width="16"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "table2 icon":
  <svg
    aria-label="table2 icon"
    class="Icon Icon-table2"
    clip-rule="evenodd"
    fill="currentcolor"
    fill-rule="evenodd"
    height="16"
    role="img"
    viewBox="0 0 16 16"
    width="16"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "smartscalar icon":
  <svg
    aria-label="smartscalar icon"
    class="Icon Icon-smartscalar"
    fill="currentcolor"
    height="16"
    role="img"
    viewBox="0 0 16 16"
    width="16"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "download icon":
  <svg
    aria-label="download icon"
    class="Icon Icon-download emotion-12lyuyu e7qpzox0"
    data-testid="download-button"
    fill="currentcolor"
    height="20"
    role="img"
    viewBox="0 0 16 16"
    width="20"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "bell icon":
  <svg
    aria-label="bell icon"
    class="Icon Icon-bell hide sm-show emotion-1xdubwg e1i8uk060"
    fill="currentcolor"
    height="20"
    role="img"
    viewBox="0 0 16 16"
    width="20"
    xmlns="http://www.w3.org/2000/svg"
  />
  Name "share icon":
  <svg
    aria-label="share icon"
    class="Icon Icon-share"
    fill="currentcolor"
    height="20"
    role="img"
    viewBox="0 0 16 16"
    width="20"
    xmlns="http://www.w3.org/2000/svg"
  />
  --------------------------------------------------
  textbox:
  Name "":
  <input
    class="emotion-vrmzis e1bl69jj3"
    maxlength="200"
    placeholder="Search…"
    value=""
  />
  --------------------------------------------------
  heading:
  Name "New":
  <h4
    class="emotion-xanfyj esqdtmv0"
  />
  Name "344":
  <h1
    class="ScalarValue emotion-tpdi78 ezakuv35"
    data-testid="scalar-value"
    font-size="4rem"
  />
  Name "Apr 2026":
  <h3
    class="fullscreen-normal-text fullscreen-night-text emotion-a9mrnm esf69s70"
  />
  Name "• vs. previous month: 527":
  <h4
    class="emotion-1cqkd53 esf69s72"
  />
  --------------------------------------------------
  main:
  Name "":
  <main
    class="emotion-kfkb8q enx0u2k0"
  />
  Name "":
  <main
    class="emotion-tbhpka eb9z3dt5"
    data-testid="query-builder-main"
  />
  --------------------------------------------------
  complementary:
  Name "":
  <aside
    class="emotion-1rpciof eyewhtm1"
    data-testid="sidebar-left"
  />
  Name "":
  <aside
    class="emotion-188fkf2 eyewhtm1"
    data-testid="sidebar-right"
  />
  --------------------------------------------------
  radiogroup:
  Name "":
  <div
    class="emotion-3gfgu0 e1wsrfy611"
    role="radiogroup"
  />
  --------------------------------------------------
  radio:
  Name "Data":
  <input
    checked=""
    class="emotion-ixhrh5 e1wsrfy66"
    name="radio-2"
    type="radio"
    value="Data"
  />
  Name "Display":
  <input
    class="emotion-ixhrh5 e1wsrfy66"
    name="radio-2"
    type="radio"
    value="Display"
  />
  --------------------------------------------------
  list:
  Name "":
  <ul
    class="emotion-19511c3 edqz25j7"
    data-testid="comparison-list"
  />
  Name "undo-list":
  <ul
    aria-label="undo-list"
    class="emotion-tclgn0 ep79zz28"
    data-testid="undo-list"
  />
  --------------------------------------------------
  status:
  Name "":
  <div
    aria-atomic="true"
    aria-live="assertive"
    id="DndLiveRegion-0"
    role="status"
    style="position: fixed; width: 1px; height: 1px; margin: -1px; border: 0px; padding: 0px; overflow: hidden; clip: rect(0px, 0px, 0px, 0px); clip-path: inset(100%); white-space: nowrap;"
  />
  --------------------------------------------------
Ignored nodes: comments, <script />, <style />
<html
  lang="en"
  translate="no"
>
  <head>
    <meta
      charset="utf-8"
    />
    <meta
      content="IE=edge"
      http-equiv="X-UA-Compatible"
    />
    <meta
      content="width=device-width,initial-scale=1,maximum-scale=1,user-scalable=no"
      name="viewport"
    />
    <meta
      content="noindex"
      name="robots"
    />
    <meta
      content="yes"
      name="apple-mobile-web-app-capable"
    />
    <meta
      content="black-translucent"
      name="apple-mobile-web-app-status-bar-style"
    />
    <link
      href="app/assets/img/apple-touch-icon.png"
      rel="apple-touch-icon"
      sizes="180x180"
    />
    <link
      href="app/assets/img/favicon.ico"
      rel="icon"
    />
    <link
      crossorigin="use-credentials"
      href="app/assets/img/site.webmanifest"
      rel="manifest"
    />
    <meta
      content="#2d89ef"
      name="msapplication-TileColor"
    />
    <meta
      content="app/assets/img/browserconfig.xml"
      name="msapplication-config"
    />
    <meta
      content="#ffffff"
      name="theme-color"
    />
    <meta
      content="default"
      name="apple-mobile-web-app-status-bar-style"
    />
    <meta
      content="/"
      name="base-href"
    />
    <meta
      content="/question/80"
      name="uri"
    />
    <title>
      Question · Metabase
    </title>
    <base
      href="/"
    />
    <link
      href="app/dist/styles.496a179b23d206251307.css"
      rel="stylesheet"
    />
    <link
      href="app/dist/app-main.8c3db53cb80ee9443da7.css"
      rel="stylesheet"
    />
  </head>
  <body>
    <div
      id="root"
    >
      <div
        class="spread emotion-1fttcpj enx0u2k2"
      >
        <header
          aria-label="Navigation bar"
          class="emotion-15xkiw5 es0756t0"
          data-testid="app-bar"
        >
          <div
            class="emotion-1pt930v e4w71dr4"
          >
            <div
              class="emotion-cxb03 e4w71dr3"
            >
              <div
                class="emotion-bjn8wh ehgm33i2"
              >
                <a
                  class="ehgm33i1 emotion-m53806 emeibx70"
                  data-metabase-event="Navbar;Logo"
                  href="/"
                >
                  <svg
                    class="Icon text-brand"
                    data-testid="main-logo"
                    fill="currentcolor"
                    height="32"
                    viewBox="0 0 66 85"
                  >
                    <path
                      d="M46.8253288,70.4935014 C49.5764899,70.4935014 51.8067467,68.1774705 51.8067467,65.3205017 C51.8067467,62.4635329 49.5764899,60.147502 46.8253288,60.147502 C44.0741676,60.147502 41.8439108,62.4635329 41.8439108,65.3205017 C41.8439108,68.1774705 44.0741676,70.4935014 46.8253288,70.4935014 Z M32.8773585,84.9779005 C35.6285197,84.9779005 37.8587764,82.6618697 37.8587764,79.8049008 C37.8587764,76.947932 35.6285197,74.6319011 32.8773585,74.6319011 C30.1261973,74.6319011 27.8959405,76.947932 27.8959405,79.8049008 C27.8959405,82.6618697 30.1261973,84.9779005 32.8773585,84.9779005 Z M32.8773585,70.4935014 C35.6285197,70.4935014 37.8587764,68.1774705 37.8587764,65.3205017 C37.8587764,62.4635329 35.6285197,60.147502 32.8773585,60.147502 C30.1261973,60.147502 27.8959405,62.4635329 27.8959405,65.3205017 C27.8959405,68.1774705 30.1261973,70.4935014 32.8773585,70.4935014 Z M18.9293882,70.4935014 C21.6805494,70.4935014 23.9108062,68.1774705 23.9108062,65.3205017 C23.9108062,62.4635329 21.6805494,60.147502 18.9293882,60.147502 C16.1782271,60.147502 13.9479703,62.4635329 13.9479703,65.3205017 C13.9479703,68.1774705 16.1782271,70.4935014 18.9293882,70.4935014 Z M46.8253288,56.0091023 C49.5764899,56.0091023 51.8067467,53.6930714 51.8067467,50.8361026 C51.8067467,47.9791337 49.5764899,45.6631029 46.8253288,45.6631029 C44.0741676,45.6631029 41.8439108,47.9791337 41.8439108,50.8361026 C41.8439108,53.6930714 44.0741676,56.0091023 46.8253288,56.0091023 Z M18.9293882,56.0091023 C21.6805494,56.0091023 23.9108062,53.6930714 23.9108062,50.8361026 C23.9108062,47.9791337 21.6805494,45.6631029 18.9293882,45.6631029 C16.1782271,45.6631029 13.9479703,47.9791337 13.9479703,50.8361026 C13.9479703,53.6930714 16.1782271,56.0091023 18.9293882,56.0091023 Z M46.8253288,26.8995984 C49.5764899,26.8995984 51.8067467,24.5835675 51.8067467,21.7265987 C51.8067467,18.8696299 49.5764899,16.553599 46.8253288,16.553599 C44.0741676,16.553599 41.8439108,18.8696299 41.8439108,21.7265987 C41.8439108,24.5835675 44.0741676,26.8995984 46.8253288,26.8995984 Z M32.8773585,41.5247031 C35.6285197,41.5247031 37.8587764,39.2086723 37.8587764,36.3517034 C37.8587764,33.4947346 35.6285197,31.1787037 32.8773585,31.1787037 C30.1261973,31.1787037 27.8959405,33.4947346 27.8959405,36.3517034 C27.8959405,39.2086723 30.1261973,41.5247031 32.8773585,41.5247031 Z M32.8773585,10.3459994 C35.6285197,10.3459994 37.8587764,8.02996853 37.8587764,5.17299969 C37.8587764,2.31603085 35.6285197,0 32.8773585,0 C30.1261973,0 27.8959405,2.31603085 27.8959405,5.17299969 C27.8959405,8.02996853 30.1261973,10.3459994 32.8773585,10.3459994 Z M32.8773585,26.8995984 C35.6285197,26.8995984 37.8587764,24.5835675 37.8587764,21.7265987 C37.8587764,18.8696299 35.6285197,16.553599 32.8773585,16.553599 C30.1261973,16.553599 27.8959405,18.8696299 27.8959405,21.7265987 C27.8959405,24.5835675 30.1261973,26.8995984 32.8773585,26.8995984 Z M18.9293882,26.8995984 C21.6805494,26.8995984 23.9108062,24.5835675 23.9108062,21.7265987 C23.9108062,18.8696299 21.6805494,16.553599 18.9293882,16.553599 C16.1782271,16.553599 13.9479703,18.8696299 13.9479703,21.7265987 C13.9479703,24.5835675 16.1782271,26.8995984 18.9293882,26.8995984 Z"
                      opacity="0.2"
                    />
                    <path
                      d="M60.773299,70.4935014 C63.5244602,70.4935014 65.754717,68.1774705 65.754717,65.3205017 C65.754717,62.4635329 63.5244602,60.147502 60.773299,60.147502 C58.0221379,60.147502 55.7918811,62.4635329 55.7918811,65.3205017 C55.7918811,68.1774705 58.0221379,70.4935014 60.773299,70.4935014 Z M4.98141795,70.3527958 C7.73257912,70.3527958 9.96283591,68.0367649 9.96283591,65.1797961 C9.96283591,62.3228273 7.73257912,60.0067964 4.98141795,60.0067964 C2.23025679,60.0067964 0,62.3228273 0,65.1797961 C0,68.0367649 2.23025679,70.3527958 4.98141795,70.3527958 Z M60.773299,56.0091023 C63.5244602,56.0091023 65.754717,53.6930714 65.754717,50.8361026 C65.754717,47.9791337 63.5244602,45.6631029 60.773299,45.6631029 C58.0221379,45.6631029 55.7918811,47.9791337 55.7918811,50.8361026 C55.7918811,53.6930714 58.0221379,56.0091023 60.773299,56.0091023 Z M32.8773585,56.0091023 C35.6285197,56.0091023 37.8587764,53.6930714 37.8587764,50.8361026 C37.8587764,47.9791337 35.6285197,45.6631029 32.8773585,45.6631029 C30.1261973,45.6631029 27.8959405,47.9791337 27.8959405,50.8361026 C27.8959405,53.6930714 30.1261973,56.0091023 32.8773585,56.0091023 Z M4.98141795,55.8683967 C7.73257912,55.8683967 9.9628359...
  • shouldn't create a rearrange revision when adding a card (Dashboard revision history revert bugs #6884) 
      Timed out retrying after 4000ms: Unable to find an element by: [data-testid="sidebar-right"]
Ignored nodes: comments, <script />, <style />
<html
  lang="en"
  translate="no"
>
  <head>
    <meta
      charset="utf-8"
    />
    <meta
      content="IE=edge"
      http-equiv="X-UA-Compatible"
    />
    <meta
      content="width=device-width,initial-scale=1,maximum-scale=1,user-scalable=no"
      name="viewport"
    />
    <meta
      content="noindex"
      name="robots"
    />
    <meta
      content="yes"
      name="apple-mobile-web-app-capable"
    />
    <meta
      content="black-translucent"
      name="apple-mobile-web-app-status-bar-style"
    />
    <link
      href="app/assets/img/apple-touch-icon.png"
      rel="apple-touch-icon"
      sizes="180x180"
    />
    <link
      href="app/assets/img/favicon.ico"
      rel="icon"
    />
    <link
      crossorigin="use-credentials"
      href="app/assets/img/site.webmanifest"
      rel="manifest"
    />
    <meta
      content="#2d89ef"
      name="msapplication-TileColor"
    />
    <meta
      content="app/assets/img/browserconfig.xml"
      name="msapplication-config"
    />
    <meta
      content="#ffffff"
      name="theme-color"
    />
    <meta
      content="default"
      name="apple-mobile-web-app-status-bar-style"
    />
    <meta
      content="/"
      name="base-href"
    />
    <meta
      content="/dashboard/9"
      name="uri"
    />
    <title>
      Test Dashboard · Dashboard · Metabase
    </title>
    <base
      href="/"
    />
    <link
      href="app/dist/styles.496a179b23d206251307.css"
      rel="stylesheet"
    />
    <link
      href="app/dist/app-main.8c3db53cb80ee9443da7.css"
      rel="stylesheet"
    />
  </head>
  <body>
    <div
      id="root"
    >
      <div
        class="spread emotion-1fttcpj enx0u2k2"
      >
        <header
          aria-label="Navigation bar"
          class="emotion-15xkiw5 es0756t0"
          data-testid="app-bar"
        >
          <div
            class="emotion-1pt930v e4w71dr4"
          >
            <div
              class="emotion-cxb03 e4w71dr3"
            >
              <div
                class="emotion-bjn8wh ehgm33i2"
              >
                <a
                  class="ehgm33i1 emotion-m53806 emeibx70"
                  data-metabase-event="Navbar;Logo"
                  href="/"
                >
                  <svg
                    class="Icon text-brand"
                    data-testid="main-logo"
                    fill="currentcolor"
                    height="32"
                    viewBox="0 0 66 85"
                  >
                    <path
                      d="M46.8253288,70.4935014 C49.5764899,70.4935014 51.8067467,68.1774705 51.8067467,65.3205017 C51.8067467,62.4635329 49.5764899,60.147502 46.8253288,60.147502 C44.0741676,60.147502 41.8439108,62.4635329 41.8439108,65.3205017 C41.8439108,68.1774705 44.0741676,70.4935014 46.8253288,70.4935014 Z M32.8773585,84.9779005 C35.6285197,84.9779005 37.8587764,82.6618697 37.8587764,79.8049008 C37.8587764,76.947932 35.6285197,74.6319011 32.8773585,74.6319011 C30.1261973,74.6319011 27.8959405,76.947932 27.8959405,79.8049008 C27.8959405,82.6618697 30.1261973,84.9779005 32.8773585,84.9779005 Z M32.8773585,70.4935014 C35.6285197,70.4935014 37.8587764,68.1774705 37.8587764,65.3205017 C37.8587764,62.4635329 35.6285197,60.147502 32.8773585,60.147502 C30.1261973,60.147502 27.8959405,62.4635329 27.8959405,65.3205017 C27.8959405,68.1774705 30.1261973,70.4935014 32.8773585,70.4935014 Z M18.9293882,70.4935014 C21.6805494,70.4935014 23.9108062,68.1774705 23.9108062,65.3205017 C23.9108062,62.4635329 21.6805494,60.147502 18.9293882,60.147502 C16.1782271,60.147502 13.9479703,62.4635329 13.9479703,65.3205017 C13.9479703,68.1774705 16.1782271,70.4935014 18.9293882,70.4935014 Z M46.8253288,56.0091023 C49.5764899,56.0091023 51.8067467,53.6930714 51.8067467,50.8361026 C51.8067467,47.9791337 49.5764899,45.6631029 46.8253288,45.6631029 C44.0741676,45.6631029 41.8439108,47.9791337 41.8439108,50.8361026 C41.8439108,53.6930714 44.0741676,56.0091023 46.8253288,56.0091023 Z M18.9293882,56.0091023 C21.6805494,56.0091023 23.9108062,53.6930714 23.9108062,50.8361026 C23.9108062,47.9791337 21.6805494,45.6631029 18.9293882,45.6631029 C16.1782271,45.6631029 13.9479703,47.9791337 13.9479703,50.8361026 C13.9479703,53.6930714 16.1782271,56.0091023 18.9293882,56.0091023 Z M46.8253288,26.8995984 C49.5764899,26.8995984 51.8067467,24.5835675 51.8067467,21.7265987 C51.8067467,18.8696299 49.5764899,16.553599 46.8253288,16.553599 C44.0741676,16.553599 41.8439108,18.8696299 41.8439108,21.7265987 C41.8439108,24.5835675 44.0741676,26.8995984 46.8253288,26.8995984 Z M32.8773585,41.5247031 C35.6285197,41.5247031 37.8587764,39.2086723 37.8587764,36.3517034 C37.8587764,33.4947346 35.6285197,31.1787037 32.8773585,31.1787037 C30.1261973,31.1787037 27.8959405,33.4947346 27.8959405,36.3517034 C27.8959405,39.2086723 30.1261973,41.5247031 32.8773585,41.5247031 Z M32.8773585,10.3459994 C35.6285197,10.3459994 37.8587764,8.02996853 37.8587764,5.17299969 C37.8587764,2.31603085 35.6285197,0 32.8773585,0 C30.1261973,0 27.8959405,2.31603085 27.8959405,5.17299969 C27.8959405,8.02996853 30.1261973,10.3459994 32.8773585,10.3459994 Z M32.8773585,26.8995984 C35.6285197,26.8995984 37.8587764,24.5835675 37.8587764,21.7265987 C37.8587764,18.8696299 35.6285197,16.553599 32.8773585,16.553599 C30.1261973,16.553599 27.8959405,18.8696299 27.8959405,21.7265987 C27.8959405,24.5835675 30.1261973,26.8995984 32.8773585,26.8995984 Z M18.9293882,26.8995984 C21.6805494,26.8995984 23.9108062,24.5835675 23.9108062,21.7265987 C23.9108062,18.8696299 21.6805494,16.553599 18.9293882,16.553599 C16.1782271,16.553599 13.9479703,18.8696299 13.9479703,21.7265987 C13.9479703,24.5835675 16.1782271,26.8995984 18.9293882,26.8995984 Z"
                      opacity="0.2"
                    />
                    <path
                      d="M60.773299,70.4935014 C63.5244602,70.4935014 65.754717,68.1774705 65.754717,65.3205017 C65.754717,62.4635329 63.5244602,60.147502 60.773299,60.147502 C58.0221379,60.147502 55.7918811,62.4635329 55.7918811,65.3205017 C55.7918811,68.1774705 58.0221379,70.4935014 60.773299,70.4935014 Z M4.98141795,70.3527958 C7.73257912,70.3527958 9.96283591,68.0367649 9.96283591,65.1797961 C9.96283591,62.3228273 7.73257912,60.0067964 4.98141795,60.0067964 C2.23025679,60.0067964 0,62.3228273 0,65.1797961 C0,68.0367649 2.23025679,70.3527958 4.98141795,70.3527958 Z M60.773299,56.0091023 C63.5244602,56.0091023 65.754717,53.6930714 65.754717,50.8361026 C65.754717,47.9791337 63.5244602,45.6631029 60.773299,45.6631029 C58.0221379,45.6631029 55.7918811,47.9791337 55.7918811,50.8361026 C55.7918811,53.6930714 58.0221379,56.0091023 60.773299,56.0091023 Z M32.8773585,56.0091023 C35.6285197,56.0091023 37.8587764,53.6930714 37.8587764,50.8361026 C37.8587764,47.9791337 35.6285197,45.6631029 32.8773585,45.6631029 C30.1261973,45.6631029 27.8959405,47.9791337 27.8959405,50.8361026 C27.8959405,53.6930714 30.1261973,56.0091023 32.8773585,56.0091023 Z M4.98141795,55.8683967 C7.73257912,55...
✅ 2189 Passed

@johnswanson johnswanson merged commit 3982a6d into master Jan 18, 2024
110 of 112 checks passed
@johnswanson johnswanson deleted the give-a-banner-to-locales-clj branch January 18, 2024 18:57
@github-actions GitHub Actions
Copy link
Contributor

@johnswanson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@johnswanson johnswanson added this to the 0.49 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahmoss noahmoss noahmoss approved these changes

Assignees

@johnswanson johnswanson

Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Milestone
0.49
Development

Successfully merging this pull request may close these issues.

have locales.clj have a banner that it is read only
2 participants
@johnswanson @noahmoss