Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLv2] Add legacy-column->metadata for converting DatasetColumn #37648

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

bshepherdson
Copy link
Contributor

The query and stage are unfortunately required to correctly handle
aggregation references.

Note that the JS version of this name is legacy_column__GT_metadata,
with the double underscore.

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@metabase-bot metabase-bot bot added the .Team/QueryProcessor :hammer_and_wrench: label Jan 12, 2024
@ranquild ranquild added the no-backport Do not backport this PR to any branch label Jan 12, 2024
Copy link

replay-io bot commented Jan 13, 2024

StatusComplete ↗︎
Commit02df403
Results
⚠️ 1 Flaky
  • should allow non-user to unsubscribe from subscription
      Timed out retrying after 4000ms: Expected to find content: 'You've unsubscribed non-user@example.com from the "Orders in a dashboard" alert.' but never did.
2218 Passed

@uladzimirdev
Copy link
Contributor

uladzimirdev commented Jan 15, 2024

fixed on FE side

bshepherdson and others added 2 commits January 15, 2024 10:29
The query and stage are unfortunately required to correctly handle
aggregation references.

Note that the JS version of this name is `legacy_column__GT_metadata`,
with the double underscore.
Copy link
Contributor

@metamben metamben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ranquild ranquild merged commit 1418a78 into master Jan 15, 2024
106 checks passed
@ranquild ranquild deleted the mblib-dataset-column-conv branch January 15, 2024 17:24
Copy link

@bshepherdson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@bshepherdson bshepherdson added this to the 0.49 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants