Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dashcard replace event to snowplow schema and e2e test #38411

Conversation

EmmadUsmani
Copy link
Contributor

@EmmadUsmani EmmadUsmani commented Feb 2, 2024

Part of #36497

Description

In #36744 we tracked dashcard replacement with a new event name, but did not add this event name to the dashboard snowplow schema.

In this PR we add the name to the schema, and update an e2e test to ensure the event is being tracked.

How to verify

Follow this guide to run snowplow, then try replacing a dashcard locally, you should see the log in the console.

Demo

Screen.Recording.2024-02-02.at.10.43.09.AM.mov

Checklist

  • Tests have been added/updated to cover changes in this PR

Copy link
Contributor Author

EmmadUsmani commented Feb 2, 2024

@metabase-bot metabase-bot bot added the .Team/DashViz Dashboard and Viz team label Feb 2, 2024
@EmmadUsmani EmmadUsmani requested review from kulyk and a team February 2, 2024 18:53
@EmmadUsmani EmmadUsmani marked this pull request as ready for review February 2, 2024 18:53
Copy link

replay-io bot commented Feb 2, 2024

StatusIn Progress ↗︎ 51 / 52
Commit8d62626
Results
⚠️ 2 Flaky
2259 Passed

@EmmadUsmani EmmadUsmani added the no-backport Do not backport this PR to any branch label Feb 2, 2024 — with Graphite App
@EmmadUsmani EmmadUsmani force-pushed the 02-02-add_snowplow_event_tracking_for_card_and_tab_duplication branch from 24ef5c3 to 0a51a1c Compare February 2, 2024 19:29
@EmmadUsmani EmmadUsmani force-pushed the 02-02-add_dashcard_replace_event_to_snowplow_schema_and_e2e_test branch from 8dd2ebd to 8d62626 Compare February 2, 2024 19:29
Base automatically changed from 02-02-add_snowplow_event_tracking_for_card_and_tab_duplication to master February 2, 2024 20:06
@EmmadUsmani EmmadUsmani force-pushed the 02-02-add_dashcard_replace_event_to_snowplow_schema_and_e2e_test branch from 8d62626 to 477e0ec Compare February 2, 2024 20:08
Copy link
Contributor Author

EmmadUsmani commented Feb 2, 2024

Merge activity

  • Feb 2, 3:09 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Feb 2, 3:51 PM EST: @EmmadUsmani merged this pull request with Graphite.

@EmmadUsmani EmmadUsmani merged commit 34c8eaf into master Feb 2, 2024
106 checks passed
@EmmadUsmani EmmadUsmani deleted the 02-02-add_dashcard_replace_event_to_snowplow_schema_and_e2e_test branch February 2, 2024 20:51
Copy link

github-actions bot commented Feb 2, 2024

@EmmadUsmani Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

npfitz pushed a commit that referenced this pull request Feb 5, 2024
Part of #36497

### Description

In #36744 we tracked dashcard replacement with a new event name, but did not add this event name to the dashboard snowplow schema.

In this PR we add the name to the schema, and update an e2e test to ensure the event is being tracked.

### How to verify

Follow this [guide](https://www.notion.so/metabase/Snowplow-integration-5da1f874beda4153b4fccfa6c1e77caa) to run snowplow, then try replacing a dashcard locally, you should see the log in the console.

### Demo

https://github.com/metabase/metabase/assets/37751258/e8566f09-b9b8-47de-b215-fe0e25c7d920

### Checklist

- [x] Tests have been added/updated to cover changes in this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/DashViz Dashboard and Viz team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants