-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dashcard replace event to snowplow schema and e2e test #38411
Merged
EmmadUsmani
merged 1 commit into
master
from
02-02-add_dashcard_replace_event_to_snowplow_schema_and_e2e_test
Feb 2, 2024
Merged
add dashcard replace event to snowplow schema and e2e test #38411
EmmadUsmani
merged 1 commit into
master
from
02-02-add_dashcard_replace_event_to_snowplow_schema_and_e2e_test
Feb 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
1 task
kulyk
approved these changes
Feb 2, 2024
|
EmmadUsmani
added
the
no-backport
Do not backport this PR to any branch
label
Feb 2, 2024
— with
Graphite App
EmmadUsmani
force-pushed
the
02-02-add_snowplow_event_tracking_for_card_and_tab_duplication
branch
from
February 2, 2024 19:29
24ef5c3
to
0a51a1c
Compare
EmmadUsmani
force-pushed
the
02-02-add_dashcard_replace_event_to_snowplow_schema_and_e2e_test
branch
from
February 2, 2024 19:29
8dd2ebd
to
8d62626
Compare
Base automatically changed from
02-02-add_snowplow_event_tracking_for_card_and_tab_duplication
to
master
February 2, 2024 20:06
EmmadUsmani
force-pushed
the
02-02-add_dashcard_replace_event_to_snowplow_schema_and_e2e_test
branch
from
February 2, 2024 20:08
8d62626
to
477e0ec
Compare
Merge activity
|
EmmadUsmani
deleted the
02-02-add_dashcard_replace_event_to_snowplow_schema_and_e2e_test
branch
February 2, 2024 20:51
@EmmadUsmani Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
npfitz
pushed a commit
that referenced
this pull request
Feb 5, 2024
Part of #36497 ### Description In #36744 we tracked dashcard replacement with a new event name, but did not add this event name to the dashboard snowplow schema. In this PR we add the name to the schema, and update an e2e test to ensure the event is being tracked. ### How to verify Follow this [guide](https://www.notion.so/metabase/Snowplow-integration-5da1f874beda4153b4fccfa6c1e77caa) to run snowplow, then try replacing a dashcard locally, you should see the log in the console. ### Demo https://github.com/metabase/metabase/assets/37751258/e8566f09-b9b8-47de-b215-fe0e25c7d920 ### Checklist - [x] Tests have been added/updated to cover changes in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #36497
Description
In #36744 we tracked dashcard replacement with a new event name, but did not add this event name to the dashboard snowplow schema.
In this PR we add the name to the schema, and update an e2e test to ensure the event is being tracked.
How to verify
Follow this guide to run snowplow, then try replacing a dashcard locally, you should see the log in the console.
Demo
Screen.Recording.2024-02-02.at.10.43.09.AM.mov
Checklist