Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLv2] Make query= treat missing :base-type as matching #37727

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

bshepherdson
Copy link
Contributor

@bshepherdson bshepherdson commented Jan 16, 2024

Make query= treat missing :base-type and :effective-type as matching
any :base-type or :effective-type on the other side.

A mismatch is still considered not-equal.

Fixes #37659.

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@metabase-bot metabase-bot bot added the .Team/QueryProcessor :hammer_and_wrench: label Jan 16, 2024
@bshepherdson bshepherdson added this to the 0.49 milestone Jan 16, 2024
@bshepherdson bshepherdson added the no-backport Do not backport this PR to any branch label Jan 16, 2024
Copy link

replay-io bot commented Jan 16, 2024

StatusComplete ↗︎
Commitc1f3a86
Results
⚠️ 3 Flaky
  • should allow non-user to unsubscribe from subscription
      Timed out retrying after 4000ms: Expected to find content: 'You've unsubscribed non-user@example.com from the "Orders in a dashboard" alert.' but never did.
  • should allow users to provide internal urls
      Timed out retrying after 4000ms: expected 'http://localhost:4000/' to include '/test-1'
  • should filter results by more than one user
      Timed out retrying after 4000ms: expected '<button.Button.ekrkmh71.e13bobqq0.emotion-1393kpf.emiw9oj2>' to have text 'Created a few seconds ago by Robert Tableton', but the text was 'Updated a few seconds ago by Robert Tableton'
2218 Passed

Copy link
Contributor

@metamben metamben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few suggestions, but LGTM overall.

src/metabase/lib/js.cljs Show resolved Hide resolved
src/metabase/lib/js.cljs Show resolved Hide resolved
src/metabase/lib/js.cljs Outdated Show resolved Hide resolved
@bshepherdson bshepherdson enabled auto-merge (squash) January 16, 2024 15:49
@bshepherdson bshepherdson enabled auto-merge (squash) January 16, 2024 16:35
@bshepherdson bshepherdson merged commit 605eaf6 into master Jan 17, 2024
109 checks passed
@bshepherdson bshepherdson deleted the mblib-query-equals branch January 17, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MLv2] [BE] [Bug] Make query= ignore absense of base-type and effective-type in field references
2 participants